Re: [PATCH v4 0/11] at91: Support PMC clock bindings

On 24/2/19 19:52, Sam Ravnborg wrote: > Hi all. > > The following patchset add supports for the PMC clk > bindings for at91. > The patchset was tested on: > - at91sam9264ek - DT enabled > - sama5d4-xplained - non DT > > Ladislav and Ahmad did some additional testing on the boards they have > ava

Re: [PATCH v2 02/16] ARM: at91: import at91bootstrap's at91_ddrsdrc.h

Hello, On 22/2/19 14:33, Roland Hieber wrote: > On Tue, Feb 19, 2019 at 06:21:36PM +0100, Ahmad Fatoum wrote: >> Instead of adding missing definitions to the existing at91sam9_ddrsdr.h >> and adapting the incoming DDRAM initialization code from at91bootstrap, >> just replace the lightly used exist

Re: [PATCH v2 14/16] ARM: at91: microchip-ksz9477-evb: implement first stage

On 22/2/19 14:45, Roland Hieber wrote: > Hi Ahmad, > > On Tue, Feb 19, 2019 at 06:21:48PM +0100, Ahmad Fatoum wrote: >> This imports the low level init code from at91bootstrap >> https://github.com/linux4sam/at91bootstrap/blob/v3.8.12/board/sama5d3_xplained/sama5d3_xplained.c > > This file is

Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable

Hello Sascha, On 20/2/19 08:55, Sascha Hauer wrote: > On Tue, Feb 19, 2019 at 10:10:02PM +0100, Ahmad Fatoum wrote: >> Hello Sam, >> >> On 19/2/19 21:42, Sam Ravnborg wrote: >>> Hi Ahmad. >>> >>> On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote: This is in line with other platform

Re: [PATCH 4/4] ARM: at91: remove duplicate get_ddram_size code

Hello Sam, On 24/2/19 13:35, Sam Ravnborg wrote: > Hi Ahmad. > > On Tue, Feb 19, 2019 at 01:06:12PM +0100, Ahmad Fatoum wrote: >> Both at91_get_ddram_size and at91sama5_get_ddram_size are the >> same if is_sdram == false and is_nb == true. >> >> is_sdram is always false, because according to the

Re: [PATCH v2 2/2] scripts/checkpatch.pl: rebase on top of upstream v5.0-rc6

Hello Antony, On 20/2/19 08:14, Antony Pavlov wrote: > On Tue, 19 Feb 2019 15:16:47 +0100 > Ahmad Fatoum wrote: > >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index 4e17347a8481..48b39fbf962a 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl > ... > >> @@

Re: [PATCH 4/4] ARM: at91: remove duplicate get_ddram_size code

Hello, On 26/2/19 10:10, Ahmad Fatoum wrote: > Thanks for the review! > Sascha, if the series is otherwise ok, could you apply Sam's patch followed > by mine as suggested? Thanks. > While talking the series over with sha, I spotted a typo in debug_ll.h. I will prepare a v2 and send this out aga

[PATCH] ARM: i.MX6UL: liteSOM: depend on DDR controller settings

Initially we depended on DDR controller settings for liteSOM and liteboard. With 33fdc89d4cbd ("dts: update to v5.0-rc1") a `device_type = "memory";` property was added to imx6ul-litesom.dtsi file, which causes "ram0" to be added with 512MB size (value in dtsi) instead of the real 256MB size that i

Re: [PATCH 2/3] ARM: rpi: save fdt that was passed from VideoCore

Hi, On Thu, Feb 21, 2019 at 10:28:47AM +0100, Tomaz Solc wrote: > On Raspberry Pi, VideoCore firmware creates a device tree that contains > information about peripherals that were initialized by VideoCore based > on settings in config.txt. Normally this device tree is passed to the > Linux kernel

Re: [PATCH 3/3] commands: add of_bootargs command.

On Thu, Feb 21, 2019 at 10:28:48AM +0100, Tomaz Solc wrote: > When booting a Raspberry Pi, it is useful to extract bootargs from the > device tree that was created by the VideoCore firmware. These bootargs > contain for example settings for the framebuffer that the kernel needs > to properly set th

Re: [PATCH] ARM: i.MX6UL: liteSOM: depend on DDR controller settings

Tested-by: Bartosz Bilas On 26.02.2019 14:05, Marcin Niestroj wrote: Initially we depended on DDR controller settings for liteSOM and liteboard. With 33fdc89d4cbd ("dts: update to v5.0-rc1") a `device_type = "memory";` property was added to imx6ul-litesom.dtsi file, which causes "ram0" to be ad

[PATCH 5/6] fs: Drop unused code in fstat()

Signed-off-by: Andrey Smirnov --- fs/fs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/fs.c b/fs/fs.c index 65de82518..878a18e17 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -848,15 +848,12 @@ static void stat_inode(struct inode *inode, struct stat *s) int fstat(int fd, struct stat *s) {

[PATCH 4/6] fs: Make use of cdev_flush()

Drop extra checks and explicit indirect call in devfs_flush() in favour of using cdev_flush(), since it already does all of the above. Signed-off-by: Andrey Smirnov --- fs/devfs.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/devfs.c b/fs/devfs.c index ce04d0243..d08

[PATCH 2/6] fs: ramfs: Drop needless OOM check

Drop needless OOM check since xzalloc() will never return NULL. Signed-off-by: Andrey Smirnov --- fs/ramfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ramfs.c b/fs/ramfs.c index 4fba40d31..3046afef3 100644 --- a/fs/ramfs.c +++ b/fs/ramfs.c @@ -403,8 +403,6 @@ static struct inode *r

[PATCH 6/6] fs: Simplify fd to FILE lookup code

Avoid a bit of repeating code by merging checking fd for correctness and fd to FILE lookup into a single routine and converting the rest of the code to use it. Signed-off-by: Andrey Smirnov --- fs/fs.c | 83 + 1 file changed, 30 insertions(

[PATCH 1/6] fs: Drop needless OOM check

Drop needless OOM check since xzalloc() will never return NULL. Signed-off-by: Andrey Smirnov --- fs/fs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/fs.c b/fs/fs.c index 1f6b3d346..65de82518 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -809,9 +809,6 @@ static int fillonedir(struct dir_con

[PATCH 3/6] fs: Make use of cdev_erase()

Drop extra checks and explicit indirect call in devfs_erase() in favour of using cdev_erase(), since it already does all of the above. Signed-off-by: Andrey Smirnov --- fs/devfs.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/devfs.c b/fs/devfs.c index a7400df1c..ce0

[PATCH] commands: uimage: Drop needless variable in uimage_flush()

Signed-off-by: Andrey Smirnov --- commands/uimage.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/commands/uimage.c b/commands/uimage.c index 7c2dca41e..982da7101 100644 --- a/commands/uimage.c +++ b/commands/uimage.c @@ -13,11 +13,7 @@ static int uimage_fd; static i

[PATCH] include: Drop mem_memmap()

Drop what looks like a leftover function prototype. Signed-off-by: Andrey Smirnov --- include/driver.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/driver.h b/include/driver.h index 731116d8f..0ed830d29 100644 --- a/include/driver.h +++ b/include/driver.h @@ -352,7 +352,6 @@ struct

[PATCH] drivers: Drop dummy_porbe()

Drop dummy_porbe() due to lack of users in the tree. Signed-off-by: Andrey Smirnov --- drivers/base/driver.c | 6 -- include/driver.h | 3 --- 2 files changed, 9 deletions(-) diff --git a/drivers/base/driver.c b/drivers/base/driver.c index 1fd6bbc01..eec2a2d8a 100644 --- a/drivers/base

[PATCH] Documentation: imx8mq-evk: fix firmware path

Since commit: "da985aac8 firmware: drop the imx subdir" the firmware is not longer placed in imx subdir. So the subdir can be removed from the documentation. Signed-off-by: Christian Hemp --- Documentation/boards/imx/nxp-imx8mq-evk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/7] ARM: imx8mq: Add node for GPC IP block

Add node for GPC IP block that is missing in upstream DTS. This patch should be reverted once that changes. Signed-off-by: Andrey Smirnov --- arch/arm/dts/imx8mq.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/dts/imx8mq.dtsi b/arch/arm/dts/imx8mq.dtsi index 9

[PATCH 1/7] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ

Port of a Linux commit 29d6b80bc36be62ae38ed8ac3f7a426975fe7dfa The PCIe IP block has an additional clock, "pcie_aux", that needs to be controlled by the driver. Add code to support it. Signed-off-by: Andrey Smirnov Signed-off-by: Lorenzo Pieralisi Reviewed-by: Lucas Stach Cc: Bjor

[PATCH 5/7] ARM: imx8mq-zii-ultra: Enable PCIE1 and PCIE2

Enable PCIE1 and PCIE2 used on both Zest and RMB3 boards. Signed-off-by: Andrey Smirnov --- arch/arm/dts/imx8mq-zii-ultra.dtsi | 62 ++ 1 file changed, 62 insertions(+) diff --git a/arch/arm/dts/imx8mq-zii-ultra.dtsi b/arch/arm/dts/imx8mq-zii-ultra.dtsi index a6b2b8

[PATCH 4/7] ARM: imx8mq: Add nodes for PCIE1 and PCIE2 IP blocks

Add node for PCE1 and PCIE2 IP block that is missing in upstream DTS. This patch should be reverted once that changes. Signed-off-by: Andrey Smirnov --- arch/arm/dts/imx8mq.dtsi | 89 1 file changed, 89 insertions(+) diff --git a/arch/arm/dts/imx8mq.dtsi

[PATCH 6/7] ARM: dts: imx8mq: Add nodes for USB IP blocks

Add node for USB IP block that is missing in upstream DTS. This patch should be reverted once that changes. Signed-off-by: Andrey Smirnov --- arch/arm/dts/imx8mq.dtsi | 73 1 file changed, 73 insertions(+) diff --git a/arch/arm/dts/imx8mq.dtsi b/arch/arm

[PATCH 0/7] i.MX8MQ PCIe/USB DT changes

Everyone: This series contains the last set of patches needed to enable both PCIe and USB on i.MX8MQ in general and ZII boards in particular. Hopefully each patch is self-explanatory. Feedback is welcome! Thanks, Andrey Smirnov Andrey Smirnov (7): PCI: imx6: Add code to request/control "pcie_

[PATCH 2/7] ARM: imx8mq: Add node for SRC IP block

Add node for SRC IP block that is missing in upstream DTS. This patch should be reverted once that changes. Signed-off-by: Andrey Smirnov --- arch/arm/dts/imx8mq.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/dts/imx8mq.dtsi b/arch/arm/dts/imx8mq.dtsi index 1ddb51f89..90

[PATCH 7/7] ARM: imx8mq-zii-ultra: Add USB related nodes

Add nodes for exposed USB ports as well as USB hub connected to one of them. Signed-off-by: Andrey Smirnov --- arch/arm/dts/imx8mq-zii-ultra-rmb3.dts | 4 +++ arch/arm/dts/imx8mq-zii-ultra.dtsi | 34 ++ 2 files changed, 38 insertions(+) diff --git a/arch/arm/dts/imx

Re: [PATCH] usb: imx: Do not disable VBUS on ehci_register()'s success

On Sun, Feb 24, 2019 at 10:52:29PM -0800, Andrey Smirnov wrote: > Original code was written to exit early on ehci_register()'s > success. As a part of e3eb0c729b, however, it was modified to to early > exit on failure instead. This resulted in VBUS being erroneously > disabled after EHCI controller

Re: [PATCH] MIPS: ath79: increase malloc size to 8 MiB

On Mon, Feb 25, 2019 at 11:27:12AM +0100, Oleksij Rempel wrote: > with 4 MiB we are not able even to start latest kernel. > > Signed-off-by: Oleksij Rempel > --- > arch/mips/configs/ath79_defconfig | 1 + > 1 file changed, 1 insertion(+) Applied. thanks Sascha -- Pengutronix e.K.

Re: [PATCH 1/6] fs: Drop needless OOM check

On Tue, Feb 26, 2019 at 11:52:58AM -0800, Andrey Smirnov wrote: > Drop needless OOM check since xzalloc() will never return NULL. > > Signed-off-by: Andrey Smirnov > --- > fs/fs.c | 3 --- > 1 file changed, 3 deletions(-) Applied, thanks Sascha -- Pengutronix e.K.

Re: [PATCH] commands: uimage: Drop needless variable in uimage_flush()

On Tue, Feb 26, 2019 at 12:06:36PM -0800, Andrey Smirnov wrote: > Signed-off-by: Andrey Smirnov > --- > commands/uimage.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Applied, thanks Sascha > > diff --git a/commands/uimage.c b/commands/uimage.c > index 7c2dca41e..982da7101 100

Re: [PATCH] include: Drop mem_memmap()

On Tue, Feb 26, 2019 at 12:06:57PM -0800, Andrey Smirnov wrote: > Drop what looks like a leftover function prototype. > > Signed-off-by: Andrey Smirnov > --- > include/driver.h | 1 - > 1 file changed, 1 deletion(-) Applied, thanks Sascha > > diff --git a/include/driver.h b/include/driver.h

Re: [PATCH] drivers: Drop dummy_porbe()

On Tue, Feb 26, 2019 at 12:07:12PM -0800, Andrey Smirnov wrote: > Drop dummy_porbe() due to lack of users in the tree. > > Signed-off-by: Andrey Smirnov > --- > drivers/base/driver.c | 6 -- > include/driver.h | 3 --- > 2 files changed, 9 deletions(-) Applied, thanks Sascha -- Pen

Re: [PATCH] Documentation: imx8mq-evk: fix firmware path

On Tue, Feb 26, 2019 at 10:07:49PM +0100, Christian Hemp wrote: > Since commit: "da985aac8 firmware: drop the imx subdir" the firmware is > not longer placed in imx subdir. So the subdir can be removed from the > documentation. > > Signed-off-by: Christian Hemp > --- > Documentation/boards/imx/n

Re: [PATCH 0/7] i.MX8MQ PCIe/USB DT changes

On Tue, Feb 26, 2019 at 07:16:50PM -0800, Andrey Smirnov wrote: > Everyone: > > This series contains the last set of patches needed to enable both > PCIe and USB on i.MX8MQ in general and ZII boards in > particular. Hopefully each patch is self-explanatory. > > Feedback is welcome! > > Thanks, >

Re: [PATCH] ARM: i.MX6UL: liteSOM: depend on DDR controller settings

On Tue, Feb 26, 2019 at 02:05:29PM +0100, Marcin Niestroj wrote: > Initially we depended on DDR controller settings for liteSOM and liteboard. > With > 33fdc89d4cbd ("dts: update to v5.0-rc1") a `device_type = "memory";` property > was added to imx6ul-litesom.dtsi file, which causes "ram0" to be a