Re: [PATCH v3] libfile: copy_file: prevent spurious error message

In all this haste, I forgot my question. What error codes should be used? For each goto its own code, in sequence, starting from -1? ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox

[PATCH v3] libfile: copy_file: prevent spurious error message

Before this, ret was falsely polluted, which caused a misleading error message if the function bailed out at a later point. Signed-off-by: Robert Karszniewicz --- lib/libfile.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/libfile.c b/lib/libfile.c index 3f3ec21

RE: barebox 2019.07 ubiformat

Looking at the Linux nand_ecc, there is something specific for512 bytes size ecc: if (eccsize_mult == 2 && (i & 0x4) == 0) rp16 ^= tmppar; code[2] = + (invparity[par & 0xf0] << 7) | + (invparity[par & 0x0f] << 6) | + (

RE: barebox 2019.07 ubiformat

Back from holidays I have not been able to repeat the issue on the upstream DA923RC. It is now booting after ubiformatting using v2019.07. Looking back in my commit history I found that in 2016.03 I replaced the barebox nand_ecc by the Linux nand_ecc file to work around this issue on ourP101

Re: MFGTools from NXP

Hello, On 10/17/19 10:40 AM, Mihaita Ivascu wrote: > Yes I have tried with 2019.01.0 barebox but no change. On linux I > cannot even connect with PUTTY even though /dev/ttyACM0 is present. On > Windows at least I can connect via PUTTY There's A Linux PuTTY client? Have you tried with a more tradi

Re: [PATCH 1/2] edit: replace %c for literal with literal directly

On Mon, Oct 14, 2019 at 10:04:07PM +0200, Ahmad Fatoum wrote: > There's no need to use %c for ESC, when we can use the appropriate > escape sequence directly. Do this and shave off 60~ bytes on my > compressed THUMB-2 barebox. > > Signed-off-by: Ahmad Fatoum > --- > commands/edit.c | 18

Re: [PATCH v4] readline: make ctrl-u to work like linux console

On Wed, Oct 16, 2019 at 11:56:44PM +0800, sendpa...@qq.com wrote: > From: DU HUANPENG > > currtly, the ctrl-u discards the whole line, in most linux > boxes, ctrl-u just erase characters before cursor to the > begginning of the line. this patch make ctrl-u to do this. > > Signed-off-by: DU HUANP

Re: [PATCH] ARM: stm32mp: select ARCH_HAS_RESET_CONTROLLER

On Wed, Oct 16, 2019 at 11:43:44AM +0200, Ahmad Fatoum wrote: > Many STM32 peripherals, including I2C, SPI, USB and SDMMC use the RCC > reset controller for reset. Enable ARCH_HAS_RESET_CONTROLLER, so drivers > depending on RESET_CONTROLLER become available for selection. > > Signed-off-by: Ahmad

Re: [PATCH] cp: complete command help

On Wed, Oct 16, 2019 at 06:39:57PM +0200, Robert Karszniewicz wrote: > Signed-off-by: Robert Karszniewicz > --- > commands/cp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks Sascha -- Pengutronix e.K. | | Indus

Re: [PATCH 1/5] efi: Fix typo in description string

On Wed, Oct 16, 2019 at 09:21:35AM +0200, Ahmad Fatoum wrote: > s/Conosle/Console/ > > Signed-off-by: Ahmad Fatoum > --- > common/efi-guid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha -- Pengutronix e.K. |

Re: [PATCH v2] MIPS: init cache before using it

On Wed, Oct 16, 2019 at 06:57:42AM +0200, Oleksij Rempel wrote: > flush_cache_all() uses 'struct cpuinfo_mips current_cpu_data' data > fields. These data fields are initialized in r4k_cache_init(). > > However in the current implementation the r4k_cache_init() function > is called __AFTER__ reloca

Re: [PATCH v2] libfile: copy_file: prevent spurious error message

Hi Robert, On Wed, Oct 16, 2019 at 01:26:06PM +0200, Robert Karszniewicz wrote: > Before this, if the function bails out somewhere at a later point, this > return value will be outdated and will produce a misleading error > message down the line. > > Signed-off-by: Robert Karszniewicz > --- > Ch

Re: [PATCH] console_simple: fix linking error when ARCH_HAS_CTRLC enabled

On Wed, Oct 16, 2019 at 01:10:05AM +0800, iu87m8...@qq.com wrote: > From: DU HUANPENG > > this error happens in sandbox with simple console, sandbox > has ARCH_HAS_CTRLC enabled by default > > $ make sandbox_defconfig > $ make menuconfig > (select CONFIG_SHELL_SIMPLE) > $ make > > LD bareb

Re: [PATCH 1/3] net: designware: socfpga: fix phy setup for Arria10

On Thu, Oct 17, 2019 at 12:40:39PM +0200, Steffen Trumtrar wrote: > Barebox-version of the Linux v5.2 patch: > > 40ae25505fe834648ce4aa70b073ee934942bfdb > net: stmmac: socfpga: fix phy and ptp_ref setup for Arria10/Stratix10 > > On the Arria10, Agilex, and Stratix10 SoC, there are a

Re: [PATCH] kbuild: remove ar-option

On Wed, Oct 16, 2019 at 01:50:02PM +0900, Masahiro Yamada wrote: > Linux commit 13dc8c029cab ("kbuild: remove ar-option and KBUILD_ARFLAGS") > removed this already. > > Barebox has never used this macro. > > Signed-off-by: Masahiro Yamada > --- > > scripts/Kbuild.include | 5 - > 1 file ch

Re: [PATCH 1/3] ARM: socfpga: reset-manager: fix Wmissing-prototypes

On Thu, Oct 17, 2019 at 08:09:26AM +0200, Steffen Trumtrar wrote: > Fix the following warnings > > arch/arm/mach-socfpga/arria10-reset-manager.c:152:6: warning: no previous > prototype for > 'arria10_reset_deassert_shared_peripherals_q1' [-Wmissing-prototypes] > 152 | void arria10_reset_deasser

Re: [PATCH] fixup! ARM: at91: build for all SoCs when AT91_MULTI_BOARDS is selected

On Tue, Oct 15, 2019 at 10:21:05AM +0200, Ahmad Fatoum wrote: > This reverts a hunk I missed after a rebase: > A previous commit restricts ARCH_BAREBOX_MAX_BARE_INIT to only > non-multi-image boards, so no need to touch it to be compatible > with the new multi-image changes. > > --- > arch/arm/ma