Re: [PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support

2020-03-05 Thread Ahmad Fatoum
Hi Sam, On 3/5/20 9:37 PM, Sam Ravnborg wrote: >> +#define sama5d2_pmc_enable_periph_clock(clk) \ >> +at91_pmc_sam9x5_enable_periph_clock(IOMEM(SAMA5D2_BASE_PMC), clk) > I see no point in this macro. It is not that this can change or will be > reused by others. It makes the code less verbose

Re: [PATCH 1/2] ARM: at91: add support for SAM9 SoC reset

2020-03-05 Thread Ahmad Fatoum
Hello Sam, On 3/5/20 9:29 PM, Sam Ravnborg wrote: >> +priv->restart.name = "at91sam9x_rst"; > Or the driver name: > at91sam9x-rst? Sounds good. Will change in v2. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http:

Re: [PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support

2020-03-05 Thread Sam Ravnborg
Hi Ahmad. On Thu, Mar 05, 2020 at 09:02:25AM +0100, Ahmad Fatoum wrote: > The Groboards Giant Board is a ATSAMA5D27C-D1G SiP-based SBC. > The board features a 500MHz ARM Cortex-A5 and 128MB DDR2 SDRAM in the > SiP as well as a MicroSD slot on the PCB. > > barebox doesn't yet support the sama5d2 S

Re: [PATCH 1/2] ARM: at91: add support for SAM9 SoC reset

2020-03-05 Thread Sam Ravnborg
Hi Ahmad. On Thu, Mar 05, 2020 at 09:02:24AM +0100, Ahmad Fatoum wrote: > System reset wasn't supported on the sama5 so far. > Add a driver to remedy this. > > Signed-off-by: Ahmad Fatoum Looked through the patch - everything looked good. One question below. With the question considered: Revie

Re: [PATCH 2/3] fastboot net: implement fastboot over UDP

2020-03-05 Thread Daniel Glöckner
Am 03/05/20 um 08:50 schrieb Sascha Hauer: >> +const char *fastboot_files = getenv("nv.fastboot.files"); > > Please don't use nv variables directly, always use the corresponding > global variable. > > For USB fastboot we have a variable global.usbgadget.fastboot_function > for the sam

Re: [PATCH] usb: host: ehci: distinguish DMA addresses

2020-03-05 Thread Peter Mamonov
On Thu, Mar 05, 2020 at 02:32:05PM +0100, Sascha Hauer wrote: > On Thu, Feb 27, 2020 at 08:26:46PM +0300, Peter Mamonov wrote: > > This patch adds translation from CPU to DMA addresses, which is required for > > proper operation on certain architectures like MIPS. > > > > This patch also fixes the

Re: barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Giorgio
Hi Rouven, thank you for your suggestion about the addresses in the DTD. The DTD I'm using is actually rather simple, tomorrow I'll try to remove everything not absolutely necessary and see if it helps. giorgio On 3/5/20 3:20 PM, Rouven Czerwinski wrote: > On Thu, 2020-03-05 at 14:54 +0100, Gior

Re: barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Rouven Czerwinski
On Thu, 2020-03-05 at 14:54 +0100, Giorgio Dal Molin wrote: > Hi Sascha, > > > > On March 5, 2020 at 2:24 PM Sascha Hauer wrote: > > > > > > On Thu, Mar 05, 2020 at 10:50:15AM +0100, Giorgio Dal Molin wrote: > > > Hi, > > > > > > thank you for the quick reply. > > > > > > here is how I regis

Re: barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Giorgio Dal Molin
Hi Sascha, > On March 5, 2020 at 2:24 PM Sascha Hauer wrote: > > > On Thu, Mar 05, 2020 at 10:50:15AM +0100, Giorgio Dal Molin wrote: > > Hi, > > > > thank you for the quick reply. > > > > here is how I register the bbu for the spi flash: > > > > imx7_bbu_internal_spi_i2c_register_handler("

Re: [PATCH] usb: host: ehci: distinguish DMA addresses

2020-03-05 Thread Sascha Hauer
On Thu, Feb 27, 2020 at 08:26:46PM +0300, Peter Mamonov wrote: > This patch adds translation from CPU to DMA addresses, which is required for > proper operation on certain architectures like MIPS. > > This patch also fixes the bug introduced by 4350744bf5 "usb: ehci-hcd: port > periodic transactio

Re: [PATCH] ARM: dts: phycore-imx6: change mtd-partition names for compatibility with kernel

2020-03-05 Thread Sascha Hauer
On Thu, Feb 27, 2020 at 10:06:55AM +0100, Yunus Bas wrote: > The NVMEM-subsystem in newer kernels does not allow identical partition > names on different subdevices. According to the recommendation, we have to > rename the partition names to be compatible with actual kernel > versions. > > To mini

Re: barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Sascha Hauer
On Thu, Mar 05, 2020 at 10:50:15AM +0100, Giorgio Dal Molin wrote: > Hi, > > thank you for the quick reply. > > here is how I register the bbu for the spi flash: > > imx7_bbu_internal_spi_i2c_register_handler("SPI", "/dev/m25p0", > BBU_HANDLER_FLAG_DEFAULT); > > and here is a hex dump of the s

Re: barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Giorgio Dal Molin
Hi, thank you for the quick reply. here is how I register the bbu for the spi flash: imx7_bbu_internal_spi_i2c_register_handler("SPI", "/dev/m25p0", BBU_HANDLER_FLAG_DEFAULT); and here is a hex dump of the spi flash after bb-updating (I hacked the 'cat' command a bit): imx7d: / cat -h -b 0x4

Re: barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Ahmad Fatoum
On 3/5/20 9:26 AM, Giorgio Dal Molin wrote: > Hi, > > does barebox support generating a bootloader image that's able to boot > from an spi nor flash (m25p0) on an imx7 soc ? > > I'm currently able to read/write/erase the flash and I can also > 'barebox_update' > the image on the flash but the im

barebox image for an spi flash (like m25p0) on an imx7 soc

2020-03-05 Thread Giorgio Dal Molin
Hi, does barebox support generating a bootloader image that's able to boot from an spi nor flash (m25p0) on an imx7 soc ? I'm currently able to read/write/erase the flash and I can also 'barebox_update' the image on the flash but the imx7 does not want to boot from it. After comparing a working

[PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support

2020-03-05 Thread Ahmad Fatoum
The Groboards Giant Board is a ATSAMA5D27C-D1G SiP-based SBC. The board features a 500MHz ARM Cortex-A5 and 128MB DDR2 SDRAM in the SiP as well as a MicroSD slot on the PCB. barebox doesn't yet support the sama5d2 SDHCI-variant, so board support is limited to toggling the LED and interfacing with

[PATCH 1/2] ARM: at91: add support for SAM9 SoC reset

2020-03-05 Thread Ahmad Fatoum
System reset wasn't supported on the sama5 so far. Add a driver to remedy this. Signed-off-by: Ahmad Fatoum --- arch/arm/mach-at91/Kconfig| 5 +++ arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/at91sam9_rst.c | 74 +++ 3 files changed, 80 insert