Re: [PATCH] arm/boards: drop various empty board files

2020-05-04 Thread Sascha Hauer
On Mon, May 04, 2020 at 10:12:17PM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König > --- > arch/arm/boards/globalscale-guruplug/Makefile | 1 - > arch/arm/boards/globalscale-guruplug/board.c| 17 - > arch/arm/boards/globalscale-mirabox/Makefile| 1 - >

Re: [PATCH 1/4] common.h: remove unused region_overlap()

2020-05-04 Thread Sascha Hauer
On Mon, May 04, 2020 at 11:24:52PM +0900, Masahiro Yamada wrote: > This is not used at all. > > Signed-off-by: Masahiro Yamada > --- > > include/common.h | 9 - > 1 file changed, 9 deletions(-) Applied, thanks Sascha > > diff --git a/include/common.h b/include/common.h > index

Re: [PATCH 1/2] scripts: bareboximd: fix write_file error handling

2020-05-04 Thread Sascha Hauer
On Mon, May 04, 2020 at 10:35:41AM +0200, Steffen Trumtrar wrote: > write will never return 0 on POSIX conformant systems. Remove this error > path. > Also, close the file on error. > > Signed-off-by: Steffen Trumtrar > --- > scripts/bareboximd.c | 17 ++--- > 1 file changed, 6

Re: [PATCH] mtd: mtdraw: Fix cdev size calculation for large NANDs

2020-05-04 Thread Sascha Hauer
On Mon, May 04, 2020 at 03:21:48PM +0200, Yunus Bas wrote: > From: Stefan Riedmueller > > Raw size for large NAND devices (> 4 GB) can exceed 32 bits, so we need > 64 bit types as factors. Both factors are of 32 bit types, as such is > the return value. At least one factor needs to be 64 bit

Re: [PATCH] kbuild: add $(always-y) to 'targets'

2020-05-04 Thread Sascha Hauer
On Mon, May 04, 2020 at 08:27:43PM +0900, Masahiro Yamada wrote: > On Thu, Apr 30, 2020 at 1:43 PM Masahiro Yamada wrote: > > > > I missed to sync this line in commit 421108c51da4 ("kbuild: rename > > hostprogs-y/always to hostprogs/always-y"). > > > > Since then, the files in always(-y) are

[PATCH] arm/boards: drop various empty board files

2020-05-04 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- arch/arm/boards/globalscale-guruplug/Makefile | 1 - arch/arm/boards/globalscale-guruplug/board.c| 17 - arch/arm/boards/globalscale-mirabox/Makefile| 1 - arch/arm/boards/globalscale-mirabox/board.c | 17 -

Re: [PATCH] mtd: nand_bbt: Skip bad blocks when searching for the BBT in NAND

2020-05-04 Thread Yunus Bas
Please skip this patch, there seems to be a problem here. Regards Y. Bas Am 04.05.20 um 15:44 schrieb Yunus Bas: From: Stefan Riedmueller The blocks containing the bad block table can become bad as well. So make sure to skip any blocks that are marked bad when searching for the bad block

[PATCH 1/4] common.h: remove unused region_overlap()

2020-05-04 Thread Masahiro Yamada
This is not used at all. Signed-off-by: Masahiro Yamada --- include/common.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/common.h b/include/common.h index d73fc3d13..3570e6aba 100644 --- a/include/common.h +++ b/include/common.h @@ -142,15 +142,6 @@ void

[PATCH 3/4] nios2: include from asm/io.h

2020-05-04 Thread Masahiro Yamada
is a collection of default of various accessors. All the other architectures include as a fallback. Do likewise for NIOS2. Signed-off-by: Masahiro Yamada --- arch/nios2/include/asm/io.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/nios2/include/asm/io.h

[PATCH 4/4] common.h: move the generic IOMEM definition to asm-generic/io.h

2020-05-04 Thread Masahiro Yamada
arch/mips/include/asm/io.h defines arch-specific IOMEM(). The generic definition of IOMEM() should go to asm-generic/io.h because it is a collection of fallback defaults when there is no specific definition in . Signed-off-by: Masahiro Yamada --- include/asm-generic/io.h | 4

[PATCH 2/4] common.h: move and rename lregion_overlap()

2020-05-04 Thread Masahiro Yamada
lregion_overlap() is only used by common/startup.c There is no need to define it in include/common.h While I was here, I also renamed it to region_overlap(), and got rid of the 'inline' keyword. Signed-off-by: Masahiro Yamada --- common/startup.c | 14 -- include/common.h | 14

[PATCH] mtd: nand_bbt: Skip bad blocks when searching for the BBT in NAND

2020-05-04 Thread Yunus Bas
From: Stefan Riedmueller The blocks containing the bad block table can become bad as well. So make sure to skip any blocks that are marked bad when searching for the bad block table. Signed-off-by: Stefan Riedmueller Signed-off-by: Christian Hemp Signed-off-by: Yunus Bas ---

[PATCH] mtd: mtdraw: Fix cdev size calculation for large NANDs

2020-05-04 Thread Yunus Bas
From: Stefan Riedmueller Raw size for large NAND devices (> 4 GB) can exceed 32 bits, so we need 64 bit types as factors. Both factors are of 32 bit types, as such is the return value. At least one factor needs to be 64 bit type when calculating the size. Signed-off-by: Stefan Riedmueller

Re: [PATCH] kbuild: add $(always-y) to 'targets'

2020-05-04 Thread Masahiro Yamada
On Thu, Apr 30, 2020 at 1:43 PM Masahiro Yamada wrote: > > I missed to sync this line in commit 421108c51da4 ("kbuild: rename > hostprogs-y/always to hostprogs/always-y"). > > Since then, the files in always(-y) are needlessly rebuilt. This line is not precise because the files in $(always) are

[PATCH 1/2] scripts: bareboximd: fix write_file error handling

2020-05-04 Thread Steffen Trumtrar
write will never return 0 on POSIX conformant systems. Remove this error path. Also, close the file on error. Signed-off-by: Steffen Trumtrar --- scripts/bareboximd.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/scripts/bareboximd.c

[PATCH 2/2] common: imd: handle error in imd_write_crc32

2020-05-04 Thread Steffen Trumtrar
Don't just ignore the return value of write_file. Signed-off-by: Steffen Trumtrar --- common/imd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common/imd.c b/common/imd.c index 526308effa3c..5544a0131cc9 100644 --- a/common/imd.c +++ b/common/imd.c @@ -370,6 +370,7

[PATCH 0/5] net: cpsw: dual_emac mode

2020-05-04 Thread Michael Grzeschik
This series enables the dual_emac mode for cpsw controller. It enables both ports to be used individually. Michael Grzeschik (5): net: cpsw: fix cpsw_slave_regs register offsets net: cpsw: move generic setup code to probe net: cpsw: cpsw_process should only handle rx channels for its own

[PATCH 1/5] net: cpsw: fix cpsw_slave_regs register offsets

2020-05-04 Thread Michael Grzeschik
The cpsw_slave_regs struct also start with max_blks register, so here we also have to skip the first two bytes like for .host_port_reg_ofs --- drivers/net/cpsw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c index

[PATCH 2/5] net: cpsw: move generic setup code to probe

2020-05-04 Thread Michael Grzeschik
All generic cpsw code can move to probe, so the controller is only reset and configured once. Signed-off-by: Michael Grzeschik --- drivers/net/cpsw.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c index

[PATCH 4/5] net: cpsw: add vlan handling for dual_emac mode

2020-05-04 Thread Michael Grzeschik
From TI am335x Reference Manual: 14.3.2.10.2 Dual Mac Mode When operating in dual mac mode the intention is to transfer packets between ports 0 and 1 and ports 0 and 2, but not between ports 1 and 2. Each CPGMAC_SL appears as a single MAC with no bridging between MAC’s. Each CPGMAC_SL has at

[PATCH 3/5] net: cpsw: cpsw_process should only handle rx channels for its own port

2020-05-04 Thread Michael Grzeschik
The driver is currently processing the whole channel list, so it is possible that it handles a channel of the wrong interface. We limit the rx_chan handling for its desired port. The cpsw_send is removing finished tx_chan transfers on each send, so this has no directional limitation.

[PATCH 5/5] net: cpsw: make cpsw_send directional

2020-05-04 Thread Michael Grzeschik
For dual_emac mode, the driver needs to send on the individual ports. We set the directional bits on each packet so the controller knows where to send its. >From TI am335x Reference Manual: 14.3.2.10.2 Dual Mac Mode - Packets from the host (port 0) to ports 1 and 2 should be directed.

Re: [PATCH 1/2] scripts: imd: fix uninitialized variable read

2020-05-04 Thread Steffen Trumtrar
Hi, Sascha Hauer writes: On Wed, Apr 29, 2020 at 08:40:39AM +0200, Ahmad Fatoum wrote: Errors are propagated in the loop and ret is never set. Remove it. Signed-off-by: Ahmad Fatoum --- scripts/bareboximd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH] spi: Kconfig: drop unneeded dependency

2020-05-04 Thread Sascha Hauer
On Fri, May 01, 2020 at 07:08:30PM +0300, Antony Pavlov wrote: > The 'config DRIVER_SPI_MXS' section is already under 'if SPI' > so 'depends on SPI' is unneeded. > > Signed-off-by: Antony Pavlov > --- > drivers/spi/Kconfig | 1 - > 1 file changed, 1 deletion(-) Applied, thanks Sascha > >

Re: [PATCH] arm: zylonite: drop empty header

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 11:00:11AM +0200, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König > --- > arch/arm/boards/zylonite/board.c| 2 -- > arch/arm/boards/zylonite/zylonite.h | 19 --- > 2 files changed, 21 deletions(-) > delete mode 100644

Re: [PATCH 1/4] kbuild: do not delete $@ explicitly on failure

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 02:13:54PM +0900, Masahiro Yamada wrote: > The .DELETE_ON_ERROR special target is specified in scripts/Kbuild.include > > You do not need to delete $@ explicitly when the command fails. > GNU Make automatically does it. > > Signed-off-by: Masahiro Yamada > --- Applied,

Re: [PATCH 1/2] mips: remove unused INCDIR and BOARD variables in Makefile

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 01:44:48PM +0900, Masahiro Yamada wrote: > The variable INCDIR is not used by anyone. > > The variable BOARD is not set by anyone, so $(BOARD) is always empty. > > Signed-off-by: Masahiro Yamada > --- Applied, thanks Sascha > > arch/mips/Makefile | 13 -

Re: [PATCH] arm: remove empty config.h

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 01:43:57PM +0900, Masahiro Yamada wrote: > These are not included by anyone because these boards are not added > to board-y. The top Makefile creates the empty include/config.h if > a board-specific config.h deos not exist. > > Signed-off-by: Masahiro Yamada > ---

Re: [PATCH] kbuild: add $(always-y) to 'targets'

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 01:42:51PM +0900, Masahiro Yamada wrote: > I missed to sync this line in commit 421108c51da4 ("kbuild: rename > hostprogs-y/always to hostprogs/always-y"). > > Since then, the files in always(-y) are needlessly rebuilt. > > Fixes: 421108c51da4 ("kbuild: rename

Re: [PATCH 0/5] move arch/ppc to arch/powerpc

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 02:34:14AM +0900, Masahiro Yamada wrote: > > This needs to go for-next/kbuild branch. > > > > Masahiro Yamada (5): > ppc: remove unneeded -D CONFIG_PPC > ppc: pass -mno-spe and -mspe=no to cc-option > ppc: add arch/ppc/Kbuild > image: support 'powerpc' for

Re: [PATCH 2/5] ppc: pass -mno-spe and -mspe=no to cc-option

2020-05-04 Thread Sascha Hauer
On Thu, Apr 30, 2020 at 02:34:16AM +0900, Masahiro Yamada wrote: > My compiler does not understand -mno-spe or -msped=n. > > powerpc-linux-gcc: error: unrecognized command line option '-mno-spe'; did > you mean '-fno-see'? > powerpc-linux-gcc: error: unrecognized command line option '-mspe=no' >