Re: Some USB memory sticks not (fully) recognized

2020-08-10 Thread Sascha Hauer
On Tue, Aug 11, 2020 at 08:10:17AM +0200, Christian Eggers wrote: > Hi Sascha, > > On Monday, 10 August 2020, 21:26:43 CEST, Sascha Hauer wrote: > > Hi Christian, > > > > On Mon, Aug 10, 2020 at 01:52:01PM +0200, Christian Eggers wrote: > > > On Thursday, 6 August 2020, 16:29:13 CEST, Christian Eg

Re: Some USB memory sticks not (fully) recognized

2020-08-10 Thread Christian Eggers
Hi Sascha, On Monday, 10 August 2020, 21:26:43 CEST, Sascha Hauer wrote: > Hi Christian, > > On Mon, Aug 10, 2020 at 01:52:01PM +0200, Christian Eggers wrote: > > On Thursday, 6 August 2020, 16:29:13 CEST, Christian Eggers wrote: > > > I got a bug report that some newer USB memory sticks do not w

Re: [PATCH v3 14/14] usb: dwc2: Add ulpi phy function

2020-08-10 Thread Sascha Hauer
On Tue, Jul 21, 2020 at 02:06:00PM +0200, Jules Maselbas wrote: > Signed-off-by: Jules Maselbas > --- > drivers/usb/dwc2/core.c | 33 + > drivers/usb/dwc2/dwc2.h | 3 +++ > 2 files changed, 36 insertions(+) The functions introduced in this patch are unused, it se

Re: [PATCH v3 02/14] usb: dwc2: Add host controller driver

2020-08-10 Thread Sascha Hauer
On Tue, Jul 21, 2020 at 02:05:48PM +0200, Jules Maselbas wrote: > The host driver is taken from U-Boot and mix with some part from Linux. Which versions exactly? Having the base version helps when we later want to update the driver from newer U-Boot or Kernel versions. Sascha -- Pengutronix e

Re: [PATCH v3 00/14] usb: dwc2: Add host and gadget driver

2020-08-10 Thread Sascha Hauer
Hi Jules, On Tue, Jul 21, 2020 at 02:05:46PM +0200, Jules Maselbas wrote: > This patchset add USB host and gadget support for the DWC2 controller > The host driver is ported from the U-Boot driver, some part are taken > taken from Linux. > > The gadget driver is ported from Linux and only support

Re: [PATCH] ARM: boards: phytec-som-imx6: Add mmc and emmc-boot bbu update handler

2020-08-10 Thread Sascha Hauer
On Mon, Jul 20, 2020 at 12:13:18PM +0200, Robert Karszniewicz wrote: > From: Stefan Riedmueller > > Add mmc and emmc-boot bbu update handler to update barebox on SD card > and eMMC boot partitions easily. > > Signed-off-by: Stefan Riedmueller > Signed-off-by: Robert Karszniewicz > --- > arch/

Re: [PATCH 1/5] clk: imx7: add IMX7D_OCOTP_CLK

2020-08-10 Thread Sascha Hauer
Hi Rouven, On Wed, Jul 15, 2020 at 07:56:04AM +0200, Rouven Czerwinski wrote: > Otherwise barebox is not able to resolve the clock from the device tree > node. > > Signed-off-by: Rouven Czerwinski > --- > drivers/clk/imx/clk-imx7.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. Th

Re: [PATCH v2] arm: baltos: add environment node

2020-08-10 Thread Sascha Hauer
On Fri, Jul 17, 2020 at 07:45:45PM +0200, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Use the fourth SPL partition in NAND for environment storage. > > Signed-off-by: Yegor Yefremov > --- > Changes: >v2: use the fourth SPL partition and a partition phandle Applied, thanks

Re: [PATCH] console_countdown: Add CR as valid return key

2020-08-10 Thread Sascha Hauer
Hi Jules, On Thu, Jul 16, 2020 at 03:27:53PM +0200, Jules Maselbas wrote: > Now both LF ('\n') and CR ('\r') are valid keys to abort > console_countdown when using CONSOLE_COUNTDOWN_RETURN flag. I have no problem with this change, but out of curiosity: In which case do you need it? Regards, Sas

Re: [PATCH] treewide: remove stale instances of struct device

2020-08-10 Thread Sascha Hauer
On Tue, Aug 04, 2020 at 02:02:16PM +0900, Masahiro Yamada wrote: > On Tue, Aug 4, 2020 at 6:22 AM Sascha Hauer wrote: > > > > On Tue, Jul 21, 2020 at 08:15:23AM +0200, Ahmad Fatoum wrote: > > > We call it struct device_d, any instances of struct device are likely > > > left-over code after porting

Re: Some USB memory sticks not (fully) recognized

2020-08-10 Thread Sascha Hauer
Hi Christian, On Mon, Aug 10, 2020 at 01:52:01PM +0200, Christian Eggers wrote: > On Thursday, 6 August 2020, 16:29:13 CEST, Christian Eggers wrote: > > Barebox version: 2020.07.0 > > Hardware: i.MX6 ULL with external Microchip USB Hub attached > > > > I got a bug report that some newer USB memor

[PATCH v3] bootm: add global.bootm.root_dev env var for booting via PARTUUID

2020-08-10 Thread Robert Karszniewicz
Introduces a new env var which specifies which device is the rootfs device to be used in Linux, passed to Linux via bootargs, identified by the rootfs partition's PARTUUID. global.bootm.root_dev supplements global.bootm.appendroot, in that it overrides appendroot's naïve default, which picks the p

[PATCH v2] bootm: add global.bootm.root_dev env var for booting via PARTUUID

2020-08-10 Thread Robert Karszniewicz
Introduces a new env var which specifies which device is the rootfs device to be used in Linux, passed to Linux via bootargs, identified by the rootfs partition's PARTUUID. global.bootm.root_dev supplements global.bootm.appendroot, in that it overrides appendroot's naïve default, which picks the p

[PATCH] bootm: add global.bootm.root_dev env var for booting via PARTUUID

2020-08-10 Thread Robert Karszniewicz
This patch introduces a new env var which specifies which device is the rootfs device to be used in Linux, passed to Linux via bootargs, identified by the rootfs partition's PARTUUID. global.bootm.root_dev supplements global.bootm.appendroot, in that it overrides appendroot's naïve default, which

Re: Some USB memory sticks not (fully) recognized

2020-08-10 Thread Christian Eggers
On Thursday, 6 August 2020, 16:29:13 CEST, Christian Eggers wrote: > Barebox version: 2020.07.0 > Hardware: i.MX6 ULL with external Microchip USB Hub attached > > I got a bug report that some newer USB memory sticks do not work with > barebox. While with barebox-2020.01 these devices are not recog

[PATCH 1/3] fs: squashfs: set s_op in time

2020-08-10 Thread Sascha Hauer
When calling squashfs_mount() s_op needs to be set already, otherwise calling alloc_inode() yields in a NULL pointer derefence. Signed-off-by: Sascha Hauer --- fs/squashfs/squashfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/squashfs/squashfs.c b/fs/squashfs/squash

[PATCH 2/3] fs: squashfs: Do not free root inode

2020-08-10 Thread Sascha Hauer
With inode reference counting in place the core will free the root inode, so do not free it in the squashfs code. Signed-off-by: Sascha Hauer --- fs/squashfs/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c index e2b7b8d5a1..35df3a0307 100644 -

[PATCH 0/3] squashfs: Fix current master

2020-08-10 Thread Sascha Hauer
squashfs is broken since 43902e5763 ("fs: free inodes we no longer need"). This series fixes it. Sascha Hauer (3): fs: squashfs: set s_op in time fs: squashfs: Do not free root inode fs: Use iget_locked() rather than squashfs specific function fs/squashfs/inode.c| 18 +-

[PATCH 3/3] fs: Use iget_locked() rather than squashfs specific function

2020-08-10 Thread Sascha Hauer
Use iget_locked() to let the core allocate the inode. This properly initializes all fields in the new inode, especially it adds the new inode to the list of all inodes for the filesystem. This prevents a NULL pointer derefence when iput() removes the inode from that list. This fixes squashfs suppo

Re: [PATCH 04/11] fs: free inodes we no longer need

2020-08-10 Thread Sascha Hauer
Hi Ahmad, On Tue, Aug 04, 2020 at 12:02:37AM +0200, Ahmad Fatoum wrote: > Hello Sascha, > > On 6/15/20 8:02 AM, Sascha Hauer wrote: > > So far we freed the no longer needed inodes only at unmount time. > > Let's trust our reference counting a bit more and free them once > > the reference counter

Re: [RFC PATCH v2 3/3] bootm: handle global.bootm.root_dev

2020-08-10 Thread Sascha Hauer
Hi Robert, On Wed, Aug 05, 2020 at 12:15:50PM +0200, Robert Karszniewicz wrote: > On 8/5/20 12:10 PM, Robert Karszniewicz wrote: > > --- > > common/bootm.c | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/common/bootm.c b/common/bootm.c > > index 734

Re: [PATCH v2 0/2] ARM: i.MX: Add support for IMX7 based board

2020-08-10 Thread Sascha Hauer
On Tue, Aug 04, 2020 at 11:41:56PM +0200, Anees Rehman wrote: > The first patch adds support for the IMX7 to load image from SD/MMC similar to > IMX6 and IMX8. > > The second patch adds support for Atlas Copco's IXB tool which comes with > IMX7D, 1GB lpddr2 and has most of the interfaces supported

Re: [PATCH v2 2/2] ARM: i.MX: Add atlascopco sxb board

2020-08-10 Thread Marco Felsch
On 20-08-10 10:31, Anees Rehman wrote: > On Thu, Aug 06, 2020 at 02:41:27PM +0200, Marco Felsch wrote: > > On 20-08-04 23:41, Anees Rehman wrote: > > > > ... > > > > > +static noinline void imx7d_sxb_sram_setup(void) > > > +{ > > > + int ret; > > > + > > > + relocate_to_current_adr(); > > > + set

Re: [PATCH 3/3] ARM: i.MX: setup ENET_CLK_SEL in imx6_init for every imx6q/imx6d

2020-08-10 Thread Marco Felsch
On 20-08-10 09:16, Sascha Hauer wrote: > Hi Marco, > > On Thu, Aug 06, 2020 at 11:29:19AM +0200, Marco Felsch wrote: > > Setup the ENET TX reference clk to get it from the internal clock from > > anatop. This is the default value for newer imx6 processors like: 6sx, > > 6ul, 6ull. So it should be

Re: [PATCH v2 2/2] ARM: i.MX: Add atlascopco sxb board

2020-08-10 Thread Anees Rehman
On Thu, Aug 06, 2020 at 02:41:27PM +0200, Marco Felsch wrote: > On 20-08-04 23:41, Anees Rehman wrote: > > ... > > > +static noinline void imx7d_sxb_sram_setup(void) > > +{ > > + int ret; > > + > > + relocate_to_current_adr(); > > + setup_c(); > > + > > + pr_debug("configuring ddr...\n");

Re: Getting serial console output on new imx7d tqma7 board UART4

2020-08-10 Thread Sascha Hauer
On Wed, Aug 05, 2020 at 05:00:06PM +0200, Lars Pedersen wrote: > Hi. Thanks for your patience :D > > /Lars Pedersen > > On Wed, 5 Aug 2020 at 14:30, Ahmad Fatoum wrote: > > > > Hello, > > > > On 8/5/20 1:12 PM, Lars Pedersen wrote: > > >> Text base is ignored, when you are relocatable. If you ar

Re: [PATCH 3/3] ARM: i.MX: setup ENET_CLK_SEL in imx6_init for every imx6q/imx6d

2020-08-10 Thread Sascha Hauer
Hi Marco, On Thu, Aug 06, 2020 at 11:29:19AM +0200, Marco Felsch wrote: > Setup the ENET TX reference clk to get it from the internal clock from > anatop. This is the default value for newer imx6 processors like: 6sx, > 6ul, 6ull. So it should be safe to set it as default for imx6q/d too. I don't