Re: [PATCH 0/2] imx-usb-loader: fixes in displaying version number

On Fri, May 26, 2023 at 06:59:46PM +0200, Johannes Zink wrote: > As Ahmad pointed out in [1], compilation failed if the prepare make > target was not called before compiling the imx-usb-loader, which caused > the generated file not to exist when building for the sandbox target and > broke the build

Re: [PATCH v2] Porting barebox to a new SoC

Hello Lior, On 29.05.23 15:34, Lior Weintraub wrote: > Hi Ahmad, > > I have revised the addresses and used DRAM address @ 0 instead: > #define UARTBASE(0xD000307000) > #define DRAM_ADDR (0x) > #define MY_STACK_TOP(0x + SZ_2M) // Set the stack 2MB from DRAM > sta

RE: [PATCH v2] Porting barebox to a new SoC

Hi Ahmad, I have revised the addresses and used DRAM address @ 0 instead: #define UARTBASE(0xD000307000) #define DRAM_ADDR (0x) #define MY_STACK_TOP(0x + SZ_2M) // Set the stack 2MB from DRAM start static inline void spider_serial_putc(void *base, int c) { *

Re: [PATCH v2 1/3] commands: add pwm manipulation command

On Mon, May 29, 2023 at 09:03:52PM +1000, m...@cpdesign.com.au wrote: > Hi, > > Thanks for your comments. .. > ... > > > + error = pwm_apply_state(pwm, &state); > > > + > > > + if (stop > 0) { > > > + state.p_enable = false; > > > + error = pwm_apply_state(pwm, &state); > > > + }

[PATCH v3 2/3] commands: pwm: add pwm_get command

Signed-off-by: Marc Reilly --- commands/Kconfig | 7 ++ commands/pwm.c | 56 2 files changed, 63 insertions(+) diff --git a/commands/Kconfig b/commands/Kconfig index cc7585bbb2..f2a6d22f69 100644 --- a/commands/Kconfig +++ b/commands/Kconfi

[PATCH v3 3/3] include: pwm: minor function doc fix for pwm_set_relative_duty_cycle()

Signed-off-by: Marc Reilly --- include/pwm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pwm.h b/include/pwm.h index 643ef4d7ee..02af7d0a5f 100644 --- a/include/pwm.h +++ b/include/pwm.h @@ -71,7 +71,7 @@ unsigned int pwm_get_period(struct pwm_device *pwm); * @sc

Adding PWM commands

Thanks again all for comments so far. Changes in v3: - fix minor typos - remove unused 'error' var in pwm_get Changes in v2: - remove '-n' option to specify device by number - fix freeing resources on all return paths - add pwm_get command

[PATCH v3 1/3] commands: add pwm manipulation command

This introduces a command to set parameters for a pwm device. Signed-off-by: Marc Reilly --- commands/Kconfig | 11 commands/Makefile | 1 + commands/pwm.c| 143 ++ 3 files changed, 155 insertions(+) create mode 100644 commands/pwm.c dif

Re: [PATCH v2 1/3] commands: add pwm manipulation command

Hi, Thanks for your comments. .. > > + if ((state.period_ns == 0) > > + && (freq < 0) && (duty < 0) && (period < 0)) { > > + printf(" need to know some timing info; freq or dury/ period\n"); > > typo: s/dury/duty/ > > > + pwm_free(pwm); > > indentation >

Re: [PATCH v2 01/13] Documentation: sunxi: Add some documentation

I will have to fix this On Thu, May 25, 2023 at 01:43:16AM +0200, Jules Maselbas wrote: > Add some informations about Allwinner sunxi boardssupport: the general > boot process, how to use sunxi-fel tool, and how to create a bootable > image disk. > > Signed-off-by: Jules Maselbas > --- > Docume

Re: [PATCH v2 1/3] commands: add pwm manipulation command

Hi, On Mon, May 29, 2023 at 10:13:16AM +1000, Marc Reilly wrote: > This introduces a command to set parameters for a pwm device. > > Signed-off-by: Marc Reilly > --- > commands/Kconfig | 11 > commands/Makefile | 1 + > commands/pwm.c| 143 ++

Re: [PATCH v2 2/3] commands: pwm: add pwm_get command

Hi Marc, I have some minor remarks/suggestions, see below On Mon, May 29, 2023 at 10:13:17AM +1000, Marc Reilly wrote: > Signed-off-by: Marc Reilly > --- > commands/Kconfig | 7 ++ > commands/pwm.c | 57 > 2 files changed, 64 insertions(+)