[PATCH] fixup! commands: devlookup: add support for cdev aliases

commands: devlookup: fix memory leak in error case There's a string_list_free after out:, which we are skipping when we directly return. Signed-off-by: Ahmad Fatoum --- commands/devlookup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/commands/devlookup.c b/commands/dev

Re: [PATCH 1/2] commands: devlookup: add support for cdev aliases

On Mon, 14 Apr 2025 08:25:29 +0200, Ahmad Fatoum wrote: > To allow easier observability into the newly added cdev alias > functionality, extend devlookup to be able to resolve them. > > Applied, thanks! [1/2] commands: devlookup: add support for cdev aliases https://git.pengutronix.de/c

Re: [PATCH 1/2] Documentation: user: versioning: fix formatting

On Thu, 24 Apr 2025 13:06:30 +0200, Ahmad Fatoum wrote: > Apparently, Sphinx is space sensitive in literal ``blocks`` and > currently interprets `` literally and doesn't end the literal > then. > > Applied, thanks! [1/2] Documentation: user: versioning: fix formatting https://git.pengut

Re: [PATCH] clocksource: omit seeding of RNG in PBL

On Thu, 24 Apr 2025 10:48:33 +0200, Ahmad Fatoum wrote: > We do not maintain a PRNG in the PBL, so we should omit the call to > srand_xor in PBL, otherwise it expands to BUG() and breaks the newly > introduced PBL clocksource support. > > Applied, thanks! [1/1] clocksource: omit seeding of RN

Re: [PATCH] kbuild: treat char as always unsigned

On Tue, 22 Apr 2025 08:39:10 +0200, Ahmad Fatoum wrote: > The C standard makes it implementation defined whether a plain char is > unsigned or signed and the architectures where barebox is compiled for > differ in that, e.g. chars are traditionally unsigned on ARM, but on x86 > for example they t

Re: [PATCH v2 2/4] parted: add support for gpt-location

On 25-04-24, Sascha Hauer wrote: > On Wed, Apr 23, 2025 at 04:09:11PM +0200, Marco Felsch wrote: > > Add support to place the GPT partition entries to random places instead > > of LBA2. > > > > Signed-off-by: Marco Felsch > > --- > > v2: > > - new > > > > commands/parted.c | 29

Re: [PATCH v2 4/4] ARM: riotboard: drop static barebox-environment handling

Hello All! What happens if the required GUID identifier is both in the SD card and in the MMC? Thanks! чт, 24 апр. 2025 г. в 11:02, Ahmad Fatoum : > > Hi Marco, > > On 23.04.25 16:09, Marco Felsch wrote: > > Since commit 9f868f78bc54 ("environment: use barebox environment from > > GPT partitions

Re: [PATCH v3] environment: support reading and writing of efivar

Am Fr., 4. Apr. 2025 um 16:51 Uhr schrieb Ahmad Fatoum : > > Hello Jonas, Hello Ahmad, > > On 20.03.25 10:22, Jonas Licht wrote: > > Skip the detect code when __BAREBOX__ is defined as well. > > I've noticed that the first pread in detect_efi_vars never comes back > > in __BAREBOX__ , when the efiv

Re: [PATCH v2 1/4] partitions: efi: add support to specify gpt-location

On Wed, Apr 23, 2025 at 04:09:10PM +0200, Marco Felsch wrote: > -static __maybe_unused struct partition_desc > *efi_partition_create_table(struct block_device *blk) > +static __maybe_unused struct partition_desc * > +efi_partition_create_table(struct block_device *blk, sector_t gpt_location) > {

Re: [PATCH v2 3/4] defaultenv-2: add support to automatically create an initial GPT table

On Wed, Apr 23, 2025 at 04:09:12PM +0200, Marco Felsch wrote: > This adds the support to automatically create a minimal GPT table. > > gpt-add: A script to add a minimal GPT table compatible to i.MX3/5/6/7 > devices. The initial GPT only contains a barebox-environment partition. > The script check

Re: [PATCH v2 2/4] parted: add support for gpt-location

On Wed, Apr 23, 2025 at 04:09:11PM +0200, Marco Felsch wrote: > Add support to place the GPT partition entries to random places instead > of LBA2. > > Signed-off-by: Marco Felsch > --- > v2: > - new > > commands/parted.c | 29 +++-- > 1 file changed, 27 insertions(+), 2

[PATCH v4] environment: support reading and writing of efivar

scripts/bareboxenv: skip file creation to allow reading the destination file, when existing. In envfs_load before reading the superblock, we check with fstatfs if the file descriptor is pointing to an efi vars. If this is the case we skip reading the four bytes variable attributes. For envfs_save

[PATCH 2/2] Documentation: user: versioning: reduce indentation

The bullet points are indented a lot, reduce them to normal. Signed-off-by: Ahmad Fatoum --- Documentation/user/versioning.rst | 36 +++ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/Documentation/user/versioning.rst b/Documentation/user/versioning.

[PATCH 1/2] Documentation: user: versioning: fix formatting

Apparently, Sphinx is space sensitive in literal ``blocks`` and currently interprets `` literally and doesn't end the literal then. Signed-off-by: Ahmad Fatoum --- Documentation/user/versioning.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/user/versioning.

[PATCH] clocksource: omit seeding of RNG in PBL

We do not maintain a PRNG in the PBL, so we should omit the call to srand_xor in PBL, otherwise it expands to BUG() and breaks the newly introduced PBL clocksource support. Signed-off-by: Ahmad Fatoum --- common/clock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common

Re: [PATCH v2 4/4] ARM: riotboard: drop static barebox-environment handling

On 25-04-24, Ahmad Fatoum wrote: > Hi Marco, > > On 23.04.25 16:09, Marco Felsch wrote: > > Since commit 9f868f78bc54 ("environment: use barebox environment from > > GPT partitions") barebox can try to find the barebox-environment based > > on a GPT partition GUID. > > > > Make use of this mechan

Re: [PATCH v2 4/4] ARM: riotboard: drop static barebox-environment handling

Hi Marco, On 23.04.25 16:09, Marco Felsch wrote: > Since commit 9f868f78bc54 ("environment: use barebox environment from > GPT partitions") barebox can try to find the barebox-environment based > on a GPT partition GUID. > > Make use of this mechanism and drop the barebox local of-partition. This