Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index 72b5fa2..0ca0652 100644
--- a/drivers/clk/imx/clk-imx6ul.c
+++ b/drivers/clk/imx/clk-imx6ul.c
The anatop_base pointer was unused, but instead of removing it, assign
and use it for readability like clk-imx6 and clk-imx6sx do.
Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk
The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index f28660d..5879661 100644
The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register.
Reviewed-by: Fabio Estevam
Signed-off-by: Robin van der Gracht
---
drivers/clk/imx/clk-imx6ul.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
Hello,
Currently i'm writing a BSP for our new board. I quickly figured out
there are no
driver sections: hwmon and power. Why don't they exist (yet)?
Can i give a shot at creating them?
reguards,
--
Robin van der Gracht
Protonic Holland.
tel.: +31 (0) 229 212928
fax.: +31 (0)
ondering how and where this is done for the boards mentioned before.
Reguards,
--
Robin van der Gracht
Protonic Holland.
tel.: +31 (0) 229 212928
fax.: +31 (0) 229 210930
Factorij 36 / 1689 AL Zwaag
___
barebox mailing list
barebox@lists.infradead.org
The imx6q_ocotp_data struct is incomplete resulting in a crash when trying
to read/blow fuses.
Signed-off-by: Robin van der Gracht
---
drivers/nvmem/ocotp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
index 356e9bf11..cee50955e 100644
event. This can occur if there are more events of a single
type than the event buffer (data) can hold.
Telling the user to recompile with an incomplete additional size
suggestion seems useless so I changed it to something more generic.
Signed-off-by: Robin van der Gracht
---
drivers/hab/habv4.c
The protonic-imx6 board code calls imx_ocotp_read/write_field functions.
Compiling without IMX_OCOTP results in a build failure.
Signed-off-by: Robin van der Gracht
---
arch/arm/mach-imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx
When the parameter has no set function the previous (saved_value) is not
freed up on completion.
Signed-off-by: Robin van der Gracht
---
lib/parameter.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/parameter.c b/lib/parameter.c
index adc3c7cdea..fe7e7b1ba4 100644
Removing this unused pointer pointer relieves the caller from freeing the
memory afterwards.
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boards/protonic-imx6/board.c
b
The memory required to store the string needs to be freed on success
as well since it's no longer used.
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boards/protonic
The usb check needs to be skipped unless both keys are pressed
simultaneously.
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/protonic-imx6/board.c
b/arch/arm/boards/protonic-imx6
It's only used in one function right now.
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boards/protonic-imx6/board.c
b/arch/arm/boards/protonic-imx6/board.c
index 2c4f3
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boards/protonic-imx6/board.c
b/arch/arm/boards/protonic-imx6/board.c
index dd2c041e07..8436903fd8 100644
--- a
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boards/protonic-imx6/board.c
b/arch/arm/boards/protonic-imx6/board.c
index 3116f3ac42..76c26fe296 100644
--- a/arch/arm/boards/protonic-imx6/board.c
+++ b
boot entry to avoid the race condition we now have.
The patchstack also includes some minor fixes/changes I found during
implementation of the above.
- Robin
Robin van der Gracht (9):
ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low
ARM: boards: protonic-imx6: Update comment
Read board serial number from GP1 fuses if available and fall-back to the
i2c RFID eeprom (current method) otherwise.
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 44 ++-
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a
Fixes: 1e817b64bc45968320597344e6b05463edd9c5e5
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/protonic-imx6/board.c
b/arch/arm/boards/protonic-imx6/board.c
index 8f8a0c745e
it to boot.default
it will always run first when the autoboot timeout expires. If the usb boot
entry fails boot will just fallback to the next entry (i.e. bootchooser).
Signed-off-by: Robin van der Gracht
---
arch/arm/boards/protonic-imx6/board.c | 108 +++---
1 file change
On 2022-06-16 15:50, Sascha Hauer wrote:
On Thu, Jun 16, 2022 at 02:50:40PM +0200, Robin van der Gracht wrote:
When the parameter has no set function the previous (saved_value) is not
freed up on completion.
Signed-off-by: Robin van der Gracht
---
lib/parameter.c | 4 +++-
1 file changed, 3
On 2022-06-17 09:00, Sascha Hauer wrote:
On Thu, Jun 16, 2022 at 03:11:07PM +0200, Robin van der Gracht wrote:
Fixes: 1e817b64bc45968320597344e6b05463edd9c5e5
We don't have this commit in mainline, could you reference the
corresponding upstream commit instead? Please write as
aabbccd
On 2022-06-16 18:38, Oleksij Rempel wrote:
Am 16.06.22 um 18:28 schrieb Oleksij Rempel:
Hi Robin,
On Thu, Jun 16, 2022 at 03:11:06PM +0200, Robin van der Gracht wrote:
The usb check needs to be skipped unless both keys are pressed
simultaneously.
Signed-off-by: Robin van der Gracht
Hi Ahmand,
On 2022-06-20 09:51, Ahmad Fatoum wrote:
Hello,
On 17.06.22 10:44, Marco Felsch wrote:
On 22-06-17, Sascha Hauer wrote:
Or, it is active low and your patch is correct :D
If they are, can we add a comment or _N suffix to the names?
Does barebox not have gpiod? The board code jus
Hi,
Today I tried to run barebox with CONFIG_KEYBOARD_GPIO=y added to my config.
and noticed my board hangs during boot. When I modify the probe function to
run without registering the poller[1] it boots as expected.
I started digging into the code to see how far the boot gets when I do
register
Hello Ahmad,
On 2022-06-20 09:51, Ahmad Fatoum wrote:
Hello,
On 17.06.22 10:44, Marco Felsch wrote:
On 22-06-17, Sascha Hauer wrote:
Or, it is active low and your patch is correct :D
If they are, can we add a comment or _N suffix to the names?
Does barebox not have gpiod? The board code j
Hi Sascha,
On 2022-06-21 09:46, Sascha Hauer wrote:
Hi Robin,
On Mon, Jun 20, 2022 at 04:33:02PM +0200, Robin van der Gracht wrote:
Hi,
Today I tried to run barebox with CONFIG_KEYBOARD_GPIO=y added to my
config.
and noticed my board hangs during boot. When I modify the probe function to
On 2022-06-21 09:46, Sascha Hauer wrote:
Hi Robin,
...
We should only ever
clear the bits we have handled, like sdhci_transfer_data_dma() does with
sdhci_write32(sdhci, SDHCI_INT_STATUS, SDHCI_INT_DMA);
I just noticed that the tegra-sdmmc mci driver might have the same issue.
https:
here. Since it's not
evaluated a second time, clearing it at the start of the function is
sufficient so we can just remove the erroneous status write.
Signed-off-by: Robin van der Gracht
---
drivers/mci/imx-esdhc-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mci
We should add 1 to the max_register index since counting is zero based.
i.e. the stm32mp151 bsec has registers 0 - 95 with reg_stride 4.
Size should be (95 + 1) * 4 = 384 bytes otherwise we can't access bsec
register 95 (last one).
Signed-off-by: Robin van der Gracht
---
drivers/nvmem/reg
/dev/stm32-bsec 0x017c+4
read: Invalid argument
On 2023-12-19 15:14, Robin van der Gracht wrote:
We should add 1 to the max_register index since counting is zero based.
i.e. the stm32mp151 bsec has registers 0 - 95 with reg_stride 4.
Size should be (95 + 1) * 4 = 384 bytes otherwise we can
n use that.
Signed-off-by: Robin van der Gracht
---
v2: Fix the size calculation in nvmem_regmap_read() as well.
drivers/nvmem/regmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/regmap.c b/drivers/nvmem/regmap.c
index fa5405d7a8..b923c5787d 100644
Hi Ahmad,
On 2023-12-20 10:00, Ahmad Fatoum wrote:
Hello Robin,
Thanks for the fix.
On 20.12.23 09:29, Robin van der Gracht wrote:
- if (roffset + rbytes > stride * regmap_get_max_register(map))
+ if (roffset + rbytes > regmap_size_bytes(map) * stride)
Shouldn't st
s: 094ce0ee7cdf ("nvmem: bsec: correct regmap's max_register")
> Reported-by: Robin van der Gracht
> Signed-off-by: Ahmad Fatoum
> ---
> drivers/nvmem/bsec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/bsec.c b/driv
Hello Ahmad,
On Mon, 8 Jan 2024 11:44:00 +0100
Ahmad Fatoum wrote:
> Hello Robin,
>
> On 08.01.24 11:29, Robin van der Gracht wrote:
> > Hi Ahmad,
> >
> > Comments are below.
> >
> > On Tue, 2 Jan 2024 18:00:55 +0100
> > Ahmad Fatoum wrote:
&g
On Mon, 8 Jan 2024 12:17:09 +0100
Robin van der Gracht wrote:
...
> >
> > barebox@Linux Automation MC-1 board:/ ls -l /dev/stm32-bsec
> > crw---384 /dev/stm32-bsec
>
> Thats more like it. I'll apply the full series and recheck.
This works as
Thanks!
Acked-by: Robin van der Gracht
On Thu, 11 Jan 2024 08:34:12 +0100
Ahmad Fatoum wrote:
> We already have documentation for the member that was taken from Linux,
> but still managed to use it wrongly at multiple places that were
> recently fixed. To prevent such issues from re
buffer: probe of 19ca9000.framebuffer failed
with error -12
If I understand correctly, this is due to the use of ioremap_wc on a RAM
region. I was hoping you could tell me what I'm doing wrong here, or if
I'm looking at a bug.
My mtype = MT_DEVICE_WC. (Due to the in kernel use of ioremap_wc())
My pfn = 0x19ca9
In my kernel .config i have:
CONFIG_HAVE_ARCH_PFN_VALID=y
Kind regards,
Robin van der Gracht
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
38 matches
Mail list logo
