Re: [PATCH 10/15] ARM: remove non PBL Atmel boards

2024-04-26 Thread Sam Ravnborg
On Fri, Apr 26, 2024 at 12:59:10PM +0200, Sascha Hauer wrote: > Hi Sam, > > On Thu, Apr 25, 2024 at 06:56:48PM +0200, Sam Ravnborg wrote: > > Hi Sascha > > > > On Thu, Apr 25, 2024 at 01:54:34PM +0200, Sascha Hauer wrote: > > > Some Atmel AT91 boards still d

Re: [PATCH 10/15] ARM: remove non PBL Atmel boards

2024-04-25 Thread Sam Ravnborg
Hi Sascha On Thu, Apr 25, 2024 at 01:54:34PM +0200, Sascha Hauer wrote: > Some Atmel AT91 boards still do not have PBL support which becomes > mandatory soon. Remove these boards. > > Signed-off-by: Sascha Hauer > --- > arch/arm/boards/Makefile | 3 - > arch/arm/boards/sa

Re: [PATCH v3 11/15] ARM: at91: skov-arm9cpu: Add SD-Card xload support

2024-02-21 Thread Sam Ravnborg
Hi Ahmad, On Tue, Feb 20, 2024 at 10:25:37AM +0100, Ahmad Fatoum wrote: > Hello Sam, > > > On 15.02.24 23:29, Sam Ravnborg wrote: > >> +static noinline void continue_skov_arm9cpu_xload_mmc(void) > >> +{ > >> + sam9263_lowlevel_init(0x2031B004, 0x10053

Re: [PATCH v3 00/15] ARM: at91: skov-arm9cpu (SAM9263) first stage support

2024-02-15 Thread Sam Ravnborg
rg/ > thanks for picking up this work and finish it. There we several fixes in the patch-set I would never have found - nice work! All patches are: Reviewed-by: Sam Ravnborg Except "ARM: at91: skov-arm9cpu: Add SD-Card xload support" - see my comment about the hardcoded hex-values

Re: [PATCH v3 11/15] ARM: at91: skov-arm9cpu: Add SD-Card xload support

2024-02-15 Thread Sam Ravnborg
Hi Ahmad, On Thu, Feb 15, 2024 at 05:30:05PM +0100, Ahmad Fatoum wrote: > From: Sam Ravnborg > > This updates skov-arm9cpu with xload support, and we can now > use barebox as a replacement for at91bootstrap > > Only boot via SD card is supported. > > Signed-off-by: Sa

Re: [PATCH 3/8] mci: Add dwcmshc-sdhci driver

2023-07-10 Thread Sam Ravnborg
Hi Jules. On Mon, Jul 10, 2023 at 07:23:30PM +0200, Jules Maselbas wrote: > This driver initially started as a modification of dove-sdhci driver, > it has been heavily reworked to be closer to rockchip-dwcmshc-sdhci by > using more common sdhci code. > > Signed-off-by: Jules Maselbas > --- > dr

[PATCH v1 2/2] ARM: add sama5d4_wifx to at91_multi_defconfig

2023-04-07 Thread Sam Ravnborg
With this change we have more chances to catch build issues during refactoring. The board is added to get build coverage, it is not verified if it actually boots with this config. Signed-off-by: Sam Ravnborg --- arch/arm/configs/at91_multi_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v1 1/2] ARM: sama5d4_wifx: fix build with moved mach files

2023-04-07 Thread Sam Ravnborg
Signed-off-by: Sam Ravnborg --- arch/arm/boards/sama5d4_wifx/lowlevel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boards/sama5d4_wifx/lowlevel.c b/arch/arm/boards/sama5d4_wifx/lowlevel.c index 0c3529e659..c47b14c55b 100644 --- a/arch/arm/boards

Re: [PATCH 0/3] mtd: nand: atmel: legacy: fix boot on USB-A9G20

2023-03-21 Thread Sam Ravnborg
Hi all. Correcting myself here. > > > > Super interesting about the A9263 setup code. I missed it so far. Does > > that mean that barebox can replace the at91bootstrap? > Yes. The patch series I pointed at generates a bare variant that I > successfully used to boot my board direct from ROMBOOT. >

Re: [PATCH 0/3] mtd: nand: atmel: legacy: fix boot on USB-A9G20

2023-03-21 Thread Sam Ravnborg
Hi Wolfram. On Tue, Mar 21, 2023 at 06:20:45PM +0100, Wolfram Sang wrote: > Hi Sascha! > > > Nice to hear from you here ;) > > Yeah, it has been only 10 years... :) > > > I have no idea how the SDRAM setup is done on the USB-A9G20. There seems > > to be SDRAM setup code for the USB-A9263, but n

Re: [PATCH 0/3] mtd: nand: atmel: legacy: fix boot on USB-A9G20

2023-03-21 Thread Sam Ravnborg
Hi Alexander. On Tue, Mar 21, 2023 at 10:44:25AM +0100, Alexander Dahl wrote: > Hello Sascha, > > Am Tue, Mar 21, 2023 at 09:58:48AM +0100 schrieb Sascha Hauer: > > Hi Wolfram, > > > > Nice to hear from you here ;) > > > > On Sun, Mar 19, 2023 at 10:28:07PM +0100, Wolfram Sang wrote: > > > Hi S

Re: [PATCH 0/3] mtd: nand: atmel: legacy: fix boot on USB-A9G20

2023-03-19 Thread Sam Ravnborg
Hi Wolfram. On Sun, Mar 19, 2023 at 04:49:06PM +0100, Wolfram Sang wrote: > While trying to unbrick my Calao USB-A9G20, barebox couldn't read the > NAND BB tables unlike the binary-only barebox from 2013. The first two > patches fix that. The third one is a cleanup. It is only a few weeks ago I a

Re: [PATCH 0/9] ARM: misc cleanups

2023-03-02 Thread Sam Ravnborg
Hi Sascha. On Wed, Mar 01, 2023 at 08:53:24AM +0100, Sascha Hauer wrote: > On Tue, Feb 28, 2023 at 06:37:08PM +0100, Sam Ravnborg wrote: > > Hi Sascha, > > > > On Tue, Feb 28, 2023 at 03:30:22PM +0100, Sascha Hauer wrote: > > > I am working on making it possible

Re: [PATCH 0/9] ARM: misc cleanups

2023-02-28 Thread Sam Ravnborg
Hi Sascha, On Tue, Feb 28, 2023 at 03:30:22PM +0100, Sascha Hauer wrote: > I am working on making it possible to build support for multiple > arch/arm/mach-*/ into the same barebox. Here are some misc cleanups > I stumbled upon while preparing multi arch support. > > Sascha Hauer (9): > ARM: mx

Re: [PATCH 00/11] ARM: at91: sama5d4: add basic Wifx L1 support

2022-12-28 Thread Sam Ravnborg
Hi Ahmad. > I have also resynced the Atmel NAND driver with > Linux to get support for the new EBI binding, but I'll send that out > as a separate patch once this is in. (If you need it for your hacking, > I can push it somewhere before that though). No need for the new EBI binding atm, so no reas

Re: [PATCH 00/11] ARM: at91: sama5d4: add basic Wifx L1 support

2022-12-27 Thread Sam Ravnborg
e individual patches - they all looked good. The DT file in patch 11 looks like a file that would be a good linux kernel candidate - but I guess this is for someone else to do. Full series are: Acked-by: Sam Ravnborg I look forward to the day where the remaining three sama5d boards are all multi-

Re: [PATCH v2] ARM: dts: fix wrong display-timings native-mode binding

2022-12-21 Thread Sam Ravnborg
hange as the default mode would've been the first element, > which is the same element the malformed native-mode was meant to point > at anyway. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Sam Ravnborg Sam

Re: [PATCH] ARM: dts: skov-imx6: fix wrong display-timings native-mode binding

2022-12-19 Thread Sam Ravnborg
Hi Ahmad. On Mon, Dec 19, 2022 at 07:18:39PM +0100, Ahmad Fatoum wrote: > The value of the native-mode property is supposed to be a phandle to > the entry in question, but instead the full node path was used because > the were missing. Fix this. This should not involve any > functional change as

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Hi Ahmad, On Tue, Jun 28, 2022 at 11:12:39PM +0200, Ahmad Fatoum wrote: > Hello Sam, > > On 28.06.22 21:23, Sam Ravnborg wrote: > > Hi Ahmad, > > On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: > >> The following is the current set of patches so far to

Re: [PATCH v2 10/11] ARM: at91: Add xload support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Hi myself, On Tue, Jun 28, 2022 at 10:38:48PM +0200, Sam Ravnborg wrote: > This updates skov-arm9cpu with xload support, and we can now > use barebox as a replacment for at91bootstrap. > > Only boot via SD card is supported. > > Includes several suggestions from: Ahm

[WIP PATCH v2 09/11] atmel_lcdfb: add support for updated DT bindings

2022-06-28 Thread Sam Ravnborg
specifying a backlight node as part of the panel node. Signed-off-by: Sam Ravnborg --- drivers/video/atmel_lcdfb.c | 6 ++ drivers/video/atmel_lcdfb.h | 4 + drivers/video/atmel_lcdfb_core.c | 125 +-- 3 files changed, 113 insertions(+), 22 deletions

[PATCH v2 10/11] ARM: at91: Add xload support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
[ ] barebox.bin can start a linux kernel [ ] support default SD card boots and nfsboot [x] update Kconfig to work with xload [x] xload image support Signed-off-by: Sam Ravnborg --- arch/arm/boards/skov-arm9cpu/board.c| 17 +-- arch/arm/boards/skov-arm9cpu/lowlevel.c | 158

[PATCH v2 01/11] pwm: atmel: Fix build and update

2022-06-28 Thread Sam Ravnborg
The pwm-atmel driver was not updated to use the atomic api and did not build. Update the driver from linux kernel 5.16-rc7 and adapt to barebox to get the latest fixes including the conversion to atomic api. Signed-off-by: Sam Ravnborg --- drivers/pwm/pwm-atmel.c | 383

[PATCH v2 08/11] ARM: at91: Add lowlevel helpers for at91sam9263

2022-06-28 Thread Sam Ravnborg
Add lowlevel helpers like we already have for sama5d2 etc. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile| 1 + arch/arm/mach-at91/include/mach/sam92_ll.h | 54 ++ arch/arm/mach-at91/sam9263_ll.c| 215 + 3 files changed, 270

[PATCH v2 02/11] ARM: at91: Make sdramc.h useable in multi image builds

2022-06-28 Thread Sam Ravnborg
There is no need to ifdef out all the static inlines as the headers no longer conflicts. Drop the ifdefs so we can now use the header in multi image builds. Signed-off-by: Sam Ravnborg --- .../mach-at91/include/mach/at91sam9_sdramc.h | 45 ++- 1 file changed, 4 insertions

[PATCH v2 04/11] ARM: at91: Provide at91_mux_pio_pin for use in lowlevel

2022-06-28 Thread Sam Ravnborg
similar to the already existing at91_mux_pio3_pin function Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include/mach/gpio.h | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h index

[PATCH v2 03/11] ARM: at91: Add initialize function to sdramc

2022-06-28 Thread Sam Ravnborg
Port the sdramc initialize function from at91bootstrap. It is needed from lowlevel code and is a replacement for the sdramc init code in at91sam926x_board_init.h Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile | 2 +- arch/arm/mach-at91/at91sam9_sdramc_ll.c

[WIP PATCH v2 11/11] ARM: at91: Update DTS for skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
updated bindings for the display node. Signed-off-by: Sam Ravnborg --- arch/arm/dts/at91-skov-arm9cpu.dts | 107 + 1 file changed, 49 insertions(+), 58 deletions(-) diff --git a/arch/arm/dts/at91-skov-arm9cpu.dts b/arch/arm/dts/at91-skov-arm9cpu.dts index 8e4fddfd3

[PATCH 0/11] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
is to resurrect my drm driver for at91sam9 and with that the update the binding file. But timeline for this work is unknowm. In other words - I assume patch 1 to 8 + 10 as ready. Patch 9 + 11 are WIP. Sam Sam Ravnborg (11): pwm: atmel: Fix build and update ARM: at91: Make

[PATCH v2 07/11] ARM: at91: Add extra register definitions

2022-06-28 Thread Sam Ravnborg
Copied from at91bootstrap. Required in subsequent patches. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include/mach/at91_pmc.h| 2 + arch/arm/mach-at91/include/mach/at91sam9263.h | 14 +++ .../include/mach/at91sam9263_matrix.h | 23 +++- arch/arm/mach-at91/include/mach

[PATCH v2 06/11] ARM: at91: Add at91sam9 xload_mmc for PBL use

2022-06-28 Thread Sam Ravnborg
Add xload support to at91sam9263 similar to what is already present for the sama5d3. The xload supports reading barebox.bin from a SDCARD from the PBL and load the full barebox.bin and starts it. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91

[PATCH v2 05/11] mci: atmel_mci: Add PBL helper to configure highcapacity

2022-06-28 Thread Sam Ravnborg
Older atmel SoC's like at91sam9263 do not support highcapacity SD cards. Add helper that can be used to disable highcapacity support in the PBL code - as probing for the SD card type is not an option. Suggested-by: Ahmad Fatoum Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Hi Ahmad, On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: > The following is the current set of patches so far to support > PBL for the skov-arm9cpu. ... > This is an RFC - because the code does not yet work :-( > It fails to mount the SD Card - for reasons I am yet

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-05-30 Thread Sam Ravnborg
On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: > The following is the current set of patches so far to support > PBL for the skov-arm9cpu. > > The pwm is not really part of this - but it is part of the story. > The patch-set was triggered when someone reported a bug

Re: [PATCH v1 8/8] ARM: at91: Add xload support to skov-arm9cpu

2022-05-16 Thread Sam Ravnborg
Hi Ahmad, On Mon, May 16, 2022 at 01:15:42PM +0200, Ahmad Fatoum wrote: > Hello Sam, Thanks for your feedback - very appreciated! > > On 15.05.22 21:38, Sam Ravnborg wrote: > > This updates skov-arm9cpu with xload support, and we can now > > use barebox as a replacm

Re: [PATCH v1 7/8] ARM: at91: Add initialize function to sdramc

2022-05-16 Thread Sam Ravnborg
Hi Ahmad, On Mon, May 16, 2022 at 12:47:52PM +0200, Ahmad Fatoum wrote: > Hello Sam, > > On 15.05.22 21:38, Sam Ravnborg wrote: > > +int at91sam9_sdramc_initialize(const struct at91sam9_sdramc_config *config, > > + unsigned int sdram_address) > &

[PATCH v1 7/8] ARM: at91: Add initialize function to sdramc

2022-05-15 Thread Sam Ravnborg
Port the sdramc initialize function from at91bootstrap. It is needed from lowlevel code and is a replacement for the sdramc init code in at91sam926x_board_init.h Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile | 2 +- arch/arm/mach-at91/at91sam9_sdramc_ll.c

[PATCH v1 8/8] ARM: at91: Add xload support to skov-arm9cpu

2022-05-15 Thread Sam Ravnborg
used for div/mul - there is some confusion [ ] load barebox.bin and boots it. Right now mount fails [ ] barebox.bin can start a linux kernel [ ] support default SD card boots and nfsboot [x] update Kconfig to work with xload [x] xload image support Signed-off-by: Sam Ravnborg --- arch/arm/boards

[PATCH v1 3/8] ARM: at91: Add at91sam9 xload_mmc for PBL use

2022-05-15 Thread Sam Ravnborg
Add xload support to at91sam9263 similar to what is already present for the sama5d3. The xload supports reading barebox.bin from a SDCARD from the PBL and load the full barebox.bin and starts it. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91

[PATCH v1 4/8] ARM: at91: Add extra register definitions

2022-05-15 Thread Sam Ravnborg
Copied from at91bootstrap. Required in subsequent patches. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include/mach/at91_pmc.h| 2 + arch/arm/mach-at91/include/mach/at91sam9263.h | 14 +++ .../include/mach/at91sam9263_matrix.h | 23 +++- arch/arm/mach-at91/include/mach

[PATCH v1 2/8] ARM: at91: Provide at91_mux_pio_pin for use in lowlevel

2022-05-15 Thread Sam Ravnborg
similar to the already existing at91_mux_pio3_pin function Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include/mach/gpio.h | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h index

[PATCH v1 1/8] pwm: atmel: Fix build and update

2022-05-15 Thread Sam Ravnborg
The pwm-atmel driver was not updated to use the atomic api and did not build. Update the driver from linux kernel 5.16-rc7 and adapt to barebox to get the latest fixes including the conversion to atomic api. Signed-off-by: Sam Ravnborg --- drivers/pwm/pwm-atmel.c | 383

[PATCH v1 5/8] ARM: at91: Add lowlevel helpers for at91sam9263

2022-05-15 Thread Sam Ravnborg
Add lowlevel helpers like we already have for sama5d2 etc. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile| 1 + arch/arm/mach-at91/include/mach/sam92_ll.h | 54 ++ arch/arm/mach-at91/sam9263_ll.c| 216 + 3 files changed, 271

[RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-05-15 Thread Sam Ravnborg
in the works and I may return to this later - no promises on the timeframe though. Sam Sam Ravnborg (8): pwm: atmel: Fix build and update ARM: at91: Provide at91_mux_pio_pin for use in lowlevel ARM: at91: Add at91sam9 xload_mmc for PBL use ARM: at91: Add extra

[PATCH v1 6/8] ARM: at91: Make sdramc.h useable in multi image builds

2022-05-15 Thread Sam Ravnborg
There is no need to ifdef out all the static inlines as the headers no longer conflicts. Drop the ifdefs so we can now use the header in multi image builds. Signed-off-by: Sam Ravnborg --- .../mach-at91/include/mach/at91sam9_sdramc.h | 45 ++- 1 file changed, 4 insertions

Re: One barebox image for multiple boards

2022-05-13 Thread Sam Ravnborg
Hi Matthias On Fri, May 13, 2022 at 10:55:02AM +0200, Matthias Fend wrote: > Hi, > > I'm looking for a solution to support multiple boards with just one barebox > image. The few core components that are relevant for barebox are the same on > all boards, so that the same barebox image runs on all

Re: Q about bootstrap support for at91sam92* boards and proposal for retirement

2022-01-11 Thread Sam Ravnborg
Hi Ahmad, > > I have the code locally - but this time I will not have it posted before > > it is tested. > > > > Then I cloned the latest at91bootstrap - but they no longer support old > > at91sam92xx CPUs. > > So it was time to enable bootstrap support for at91sam9263. > > > > In the past I had

Re: Q about bootstrap support for at91sam92* boards and proposal for retirement

2022-01-10 Thread Sam Ravnborg
Hi Oleksij, > > By porting sama5d3 I noticed that bootROM is resetting configuration for > at least some of ip cores. So, the main question is, do everything needed > for uart is still pre-configured? For example pllc and clk settings? I found this in the data sheet that agrees with you: "

Re: Q about bootstrap support for at91sam92* boards and proposal for retirement

2022-01-09 Thread Sam Ravnborg
Hi, > > Can anyone (Ahmad?) help me a little how to get the bootstrap > functionality working on the at91sam9263? To answer the obvious questions - what have I done so far. - I have an at91bootstrap generated BOOT.BIN that works. This ruins out a lot of possible issues with the SD card as t

Q about bootstrap support for at91sam92* boards and proposal for retirement

2022-01-09 Thread Sam Ravnborg
Hi all. This little detour started because Ahmad pointed out I had made a stupid mistake in pwm-atmel. So I decided I wanted to give it a spin to verify if it actually works now. The first challenge I encountered was that said driver had bit-rotted as it used the old pwm framework - so I updated

Re: [PATCH master 1/5] pwm: atmel: point MMIO accesses at correct address

2022-01-03 Thread Sam Ravnborg
On Mon, Jan 03, 2022 at 05:11:53PM +0100, Sam Ravnborg wrote: > Hi Ahmad, > > On Mon, Jan 03, 2022 at 12:57:14PM +0100, Ahmad Fatoum wrote: > > The base address for MMIO writes was the address of the resource struct, > > not the start address pointed at by it. > >

Re: [PATCH master 1/5] pwm: atmel: point MMIO accesses at correct address

2022-01-03 Thread Sam Ravnborg
Hi Ahmad, On Mon, Jan 03, 2022 at 12:57:14PM +0100, Ahmad Fatoum wrote: > The base address for MMIO writes was the address of the resource struct, > not the start address pointed at by it. > > Change untested, but it doesn't look like this driver could ever have > worked. You are right that I ne

Re: [PATCH 3/5] Documentation: boards: at91: remove done TODOs

2021-09-22 Thread Sam Ravnborg
Hi Ahmad, On Wed, Sep 22, 2021 at 08:49:59AM +0200, Ahmad Fatoum wrote: > All DT-enabled boards are now in the at91_multi_defconfig. > The SAMA5 ones also generate first stage bootloaders with the same > config. > > Cc: Sam Ravnborg > Signed-off-by: Ahmad Fatoum Nice to

Re: [PATCH] ARM: AT91: Add skov-arm9cpu board support

2021-06-19 Thread Sam Ravnborg
Hi Sasha, On Wed, Apr 14, 2021 at 02:21:43PM +0200, Sascha Hauer wrote: > From: Sam Ravnborg > > This adds support for an older SKOV board, the arm9cpu. Thanks for takiing care of this old stuff. Now I need to dig the board out and check if everything works :-)

Re: [PATCH 1/2] doc: at91: delete done TODOs

2020-10-14 Thread Sam Ravnborg
Hi Ahmad. On Wed, Oct 14, 2020 at 04:09:50PM +0200, Ahmad Fatoum wrote: > e52a250d2381 ("ARM: boards: Harmonize barebox_arm_reset_vector() prototype") > has unified the prototype, so we can drop this TODO item. > > Cc: Sam Ravnborg > Signed-off-by: Ahmad Fatoum Nice

Re: [PATCH 1/3] video: add simple, transparent, bridge implementation

2020-08-20 Thread Sam Ravnborg
Hi Ahmad. On Thu, Aug 20, 2020 at 02:24:56PM +0200, Ahmad Fatoum wrote: > Hi Sam, > > On 8/17/20 8:38 AM, Sam Ravnborg wrote: > > Hi Ahmad. > > > > On Mon, Aug 17, 2020 at 06:53:30AM +0200, Ahmad Fatoum wrote: > >> This enables support for simple bridges

Re: [PATCH 1/3] video: add simple, transparent, bridge implementation

2020-08-16 Thread Sam Ravnborg
Hi Ahmad. On Mon, Aug 17, 2020 at 06:53:30AM +0200, Ahmad Fatoum wrote: > This enables support for simple bridges, i.e. bridges that can be > used without initialization. > > This is e.g. the case with bridges that have persistent configuration, > the kernel has a full-fledged driver to configure

Re: [PATCH 0/2] Allow parsing more than one memory node

2020-03-17 Thread Sam Ravnborg
Hi Clement. On Mon, Mar 16, 2020 at 12:00:06PM +0100, Clement Leger wrote: > Currently, barebox can only parse one memory node. This means that > all other memory nodes (with device_type == "memory") will be ignored > while parsing memory. > This patchset add a function of_probe_memory which will

Re: [PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support

2020-03-08 Thread Sam Ravnborg
Hi Ahmad. On Fri, Mar 06, 2020 at 07:06:26AM +0100, Ahmad Fatoum wrote: > Hi Sam, > > On 3/5/20 9:37 PM, Sam Ravnborg wrote: > >> +#define sama5d2_pmc_enable_periph_clock(clk) \ > >> + at91_pmc_sam9x5_enable_periph_clock(IOMEM(SAMA5D2_BASE_PMC), clk) > > I see

Re: [PATCH 2/2] ARM: at91: add sama5d27-based Groboards Giant Board support

2020-03-05 Thread Sam Ravnborg
igned-off-by: Ahmad Fatoum Browsed the patch - everything looked good. A few nit for you to consider. With the nits considered, and not necessarily any changes: Acked-by: Sam Ravnborg Sam > --- > arch/arm/boards/Makefile | 1 + > arch/arm/boards/sama5d

Re: [PATCH 1/2] ARM: at91: add support for SAM9 SoC reset

2020-03-05 Thread Sam Ravnborg
estion considered: Reviewed-by: Sam Ravnborg Sam > --- > arch/arm/mach-at91/Kconfig| 5 +++ > arch/arm/mach-at91/Makefile | 1 + > arch/arm/mach-at91/at91sam9_rst.c | 74 +++ > 3 files changed, 80 insertions(+) > create mode 10064

Re: [PATCH] lds: Fix alignment of initcall table

2020-01-17 Thread Sam Ravnborg
Hi Christian. Thanks for the patch. On Fri, Jan 17, 2020 at 10:50:13AM +0100, Christian Eggers wrote: > Depending on the preceding *(.rodata*) sections, the contents of the > RO_DATA_SECTION macro may be unaligned. > > In my case, the initcall table was unaligned, because the preceding > .rodata

Re: [PATCH] lds: align RO_DATA_SECTION members

2019-12-26 Thread Sam Ravnborg
n next. Seems it has not been pushed out in the xmas rush. You can add a: Tested-by: Sam Ravnborg # fixes barebox startup on at91sam9263 in case it is relevant / doable. Sam > --- > include/asm-generic/barebox.lds.h | 11 +++ > 1 file changed, 11 insertions(+) >

Re: [PATCH] lds: align RO_DATA_SECTION members

2019-12-09 Thread Sam Ravnborg
Hi Lucas. On Mon, Dec 09, 2019 at 09:00:29AM +0100, Lucas Stach wrote: > When using the RO_DATA_SECTION macro, all the individual components > are put into the rodata section. As they now end up in the same > section there is no alignment enforced between them anymore. This > leads to unaligned st

Re: [PATCH 6/7] lds: remove more unnecessary alignments

2019-10-02 Thread Sam Ravnborg
Hi Sascha. On Wed, Oct 02, 2019 at 04:44:29PM +0200, Sascha Hauer wrote: > The alignemnt in the DTB and clk_of_table shouldn't be needed. Remove s/alignemnt/alignment/g I do this type of spelling error all the time :-( Sam Acked-by: Sam Ravnborg > them. > > Sign

Re: [PATCH 5/7] X86: lds: remove unnecessary alignments

2019-10-02 Thread Sam Ravnborg
Hi Sascha. On Wed, Oct 02, 2019 at 04:44:28PM +0200, Sascha Hauer wrote: > We do not seem to need all these alignments in the rodata sections > except the one for the command array. Remove them and put the alignment > for the command array into the BAREBOX_CMDS define. The changelog does not matc

Re: [PATCH 3/7] lds: Move start/end address variables into defines

2019-10-02 Thread Sam Ravnborg
gh the patch but no testing. Sam Acked-by: Sam Ravnborg ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox

Re: Holidays

2019-07-19 Thread Sam Ravnborg
On Fri, Jul 19, 2019 at 02:54:00PM +0200, Sascha Hauer wrote: > Hi All, > > I'm on vacation for the next two weeks and will be back on August 5th. > Your patches won't be lost, I'll look at them once I am back. > > Have fun! Likewise! Enjoy the days of in the hot summer. Sam ___

Re: [PATCH v2] treewide: remove CONFIG_DEBUG_INFO from defconfigs

2019-06-20 Thread Sam Ravnborg
Hi Sascha. On Thu, Jun 20, 2019 at 04:29:45PM +0200, Sascha Hauer wrote: > On Thu, Jun 20, 2019 at 10:54:21AM +0200, Sam Ravnborg wrote: > > Hi Antony > > > > On Thu, Jun 20, 2019 at 11:25:09AM +0300, Antony Pavlov wrote: > > > The commit b917f7864115a35 ("r

Re: [PATCH v2] treewide: remove CONFIG_DEBUG_INFO from defconfigs

2019-06-20 Thread Sam Ravnborg
Hi Antony On Thu, Jun 20, 2019 at 11:25:09AM +0300, Antony Pavlov wrote: > The commit b917f7864115a35 ("remove CONFIG_DEBUG_INFO") > has dropped Kconfig DEBUG_INFO option however we > still have very many DEBUG_INFO mentions in defconfig > files. Drop them using sed: > > find -iname '*defconfig

Re: [PATCH 4/7] ARM: stm32mp1: enable watchdog in oftree and defconfig

2019-06-03 Thread Sam Ravnborg
Hi Ahmad. Subject: [PATCH 4/7] ARM: stm32mp1: enable watchdog in oftree and defconfig ^ Someone just renamed this arch to stm32mp... Sam ___ barebox mailing list barebox@lists.infradead.org http://lists.infrade

Re: [RFC 0/4] riscv: add initial LiteX SoC support

2019-06-02 Thread Sam Ravnborg
Hi Antony Nice patch series, thanks for sharing. On Sun, Jun 02, 2019 at 10:30:57AM +0300, Antony Pavlov wrote: > This RFC patchseries adds initial LiteX RISC-V SoC support for barebox. > > You can obtain this patchseries from github: > > $ git clone -b 20190602.litex https://github.com/fra

Re: [PATCH] ARM: panic with a message when relocation type is unknown

2019-05-31 Thread Sam Ravnborg
Hi Ahmad. On Fri, May 31, 2019 at 11:02:23AM +0200, Ahmad Fatoum wrote: > Currently such failures result in a > > > > > ### ERROR ### Please RESET the board ### > > With this patch this now becomes > > > > Unknown relocation type >

Re: [PATCH v3] gpio: add driver for PCF857x, PCA{85, 96}7x, and MAX732[89] I2C GPIO expanders

2019-05-27 Thread Sam Ravnborg
p, offset, value); > +} > + > +/*-----*/ > + > +static struct gpio_ops pcf857x_gpio_ops = { > + .direction_input = pcf857x_input, > + .direction_output = pcf857x_output, > + .get = pcf857x_get, > + .set = pcf857x_set, > +}; > + > +static int pcf857x_probe(struct device_d *dev) > +{ > + struct i2c_client *client = to_i2c_client(dev); > + struct device_node *np = dev->device_node; > + struct pcf857x *gpio; > + unsigned long driver_data; > + unsigned intn_latch = 0; > + int ret; > + > + if (IS_ENABLED(CONFIG_OF) && np) > + of_property_read_u32(np, "lines-initial-states", &n_latch); So we no longer need the IS_ENABLED(CONFIG_OF) part. And consider what to do if np is NULL (error out?). With the few comments fixed: Reviewed-by: Sam Ravnborg Sam ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v3 0/9] ARM: at91: misc fixes and cleanup

2019-05-23 Thread Sam Ravnborg
ill be a while before I get back to barebox hacking. All patches are now: Reviewed-by: Sam Ravnborg ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 1/2] clk: at91: fix compilation errors in sama5d2.c

2019-05-23 Thread Sam Ravnborg
p. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Sam Ravnborg ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2 2/2] clk: at91: delete dead i2s/audio code

2019-05-23 Thread Sam Ravnborg
Hi again. On Thu, May 23, 2019 at 04:29:33PM +0200, Ahmad Fatoum wrote: > They aren't used anywhere, thus drop them. Thanks again. > > Suggested-by: Sam Ravnborg > Signed-off-by: Ahmad Fatoum Reviewed-by: Sam Ravnborg ___ bar

Re: [PATCH] gpio: add driver for PCF857x, PCA{85, 96}7x, and MAX732[89] I2C GPIO expanders

2019-05-18 Thread Sam Ravnborg
Hi Michael On Sat, May 18, 2019 at 01:36:06AM +0200, Michael Grzeschik wrote: > This driver was derived from the kernel driver gpio-pcf857x.c by removing > locking and interrupt support. > > Signed-off-by: Michael Grzeschik > --- > drivers/gpio/Kconfig| 24 +++ > drivers/gpio/Makef

Re: [PATCH 2/4] ARM: rpi: add clock for sdhost

2019-04-27 Thread Sam Ravnborg
Hi Lucas. On Sat, Apr 27, 2019 at 08:36:25PM +0200, Lucas Stach wrote: > The sdhost is driven by the core clock. > > Signed-off-by: Lucas Stach > --- > arch/arm/boards/raspberry-pi/rpi-common.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boards/raspberry-pi/rpi-co

Re: [PATCH 2/5] ARM: imx: work around i.MX6UL ERR008958 (ARM errata 814220)

2019-04-23 Thread Sam Ravnborg
Hi Ahmad. On Tue, Apr 23, 2019 at 07:18:49PM +0200, Ahmad Fatoum wrote: > The Cortex-A7 in both the i.MX6UL[1] and i.MX6ULL[2] is affected by the > errata ERR008958 "Arm/MP: 814220—B-Cache maintenance by set/way operations > can execute out of order". > > select ARM_ERRATA_814220 to address this.

Re: [PATCH 1/5] ARM: cache-armv7: add work-around for errata 814220

2019-04-23 Thread Sam Ravnborg
Hi Ahmad. On Tue, Apr 23, 2019 at 07:18:48PM +0200, Ahmad Fatoum wrote: > The v7 ARM states that all cache and branch predictor maintenance operations > that do not specify an address execute, relative to each other, in program > order. However, because of this erratum, an L2 set/way cache mainten

Re: [PATCH v3 06/15] ARM: at91: import lowlevel clock initialization from at91bootstrap

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. > >> @@ -1,4 +1,5 @@ > >> obj-y += setup.o > >> +pbl-y += at91_pmc_ll.o > > > > Will this always make my pbl image larger or do we have some linker > > magic that throws away the unused code? > > My understanding is that barebox instructs GCC to place each out-of-line > function > in

Re: [PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-02 Thread Sam Ravnborg
ence would've been that AT91SAM9G45_BASE_DDRSDRC0 already expands > to a void __iomem *. The main idea was to get rid of the bool argument and use more explicit function names. Moving IOMEM() was the added extra. > We could do that in a follow-up patch. Agreed, maybe later if we do it. T

Re: [PATCH v3 05/15] ARM: at91: watchdog: implement at91_wdt_disable

2019-04-02 Thread Sam Ravnborg
On Tue, Apr 02, 2019 at 08:39:56PM +0200, Ahmad Fatoum wrote: > Hello Sam, > > On 2/4/19 19:38, Sam Ravnborg wrote: > > Hi Ahmad. > > > > On Mon, Apr 01, 2019 at 12:18:13PM +0200, Ahmad Fatoum wrote: > >> Low level init code might want to disable the watchdog

Re: [PATCH v3 00/15] ARM: at91: microchip-kz9477-evb: support first stage boot

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. It is super that you are working on this and I hope we can have bootstrap support for more at91 variants in the near future. > This is (the hopefully final and bestest) v3 of a series that pulls in > enough of at91bootstrap to make barebox usable as first stage bootloader > for the SAMA

Re: [PATCH v3 15/15] doc: microchip-ksz9477-evb: add documentation

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. Thanks for adding the docs. On Mon, Apr 01, 2019 at 12:18:23PM +0200, Ahmad Fatoum wrote: > Signed-off-by: Ahmad Fatoum > --- > .../boards/at91/microchip-ksz9477-evb.rst | 38 ++- > 1 file changed, 36 insertions(+), 2 deletions(-) > > diff --git a/Documentation/bo

Re: [PATCH v3 14/15] ARM: at91: microchip-ksz9477: provide board code fallback

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. On Mon, Apr 01, 2019 at 12:18:22PM +0200, Ahmad Fatoum wrote: > The newly added device tree based first stage fails to load the second > stage from MMC, which might be in relation to a preceding atmel_mci > "command/data timeout" message. I had similar troubles with MMC on at91sam9263.

Re: [PATCH v3 10/15] images: at91: differentiate between first and second stage images

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. On Mon, Apr 01, 2019 at 12:18:18PM +0200, Ahmad Fatoum wrote: > Incoming microchip-ksz9477-evb first stage will add one more entry point > for the first stage. As there is a little reason to use the same piggy > data for both images (BOOT.BIN, the first stage, is limited to 64K), have >

Re: [PATCH v3 06/15] ARM: at91: import lowlevel clock initialization from at91bootstrap

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. On Mon, Apr 01, 2019 at 12:18:14PM +0200, Ahmad Fatoum wrote: > For use by future at91 first stage bootloaders, this commit imports > https://github.com/linux4sam/at91bootstrap/blob/v3.8.12/driver/pmc.c > > Signed-off-by: Ahmad Fatoum > --- > arch/arm/mach-at91/Makefile

Re: [PATCH v3 05/15] ARM: at91: watchdog: implement at91_wdt_disable

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. On Mon, Apr 01, 2019 at 12:18:13PM +0200, Ahmad Fatoum wrote: > Low level init code might want to disable the watchdog in PBL. > Provide a helper to do so. > > Signed-off-by: Ahmad Fatoum > --- > arch/arm/mach-at91/include/mach/at91_wdt.h | 16 > 1 file changed, 16 in

Re: [PATCH v3 04/15] ARM: at91: replace at91sam9_ddrsdr.h with at91bootstrap's at91_ddrsdrc.h

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. On Mon, Apr 01, 2019 at 12:18:12PM +0200, Ahmad Fatoum wrote: > Instead of adding missing definitions to the existing at91sam9_ddrsdr.h > and adapting the incoming DDRAM initialization code from at91bootstrap, > just replace the lightly used existing header with: > https://github.com/lin

Re: [PATCH] clk: at91: fix compilation errors in sama5d2.c

2019-04-02 Thread Sam Ravnborg
Hi Ahmad. Thanks for looking into this. On Mon, Apr 01, 2019 at 12:32:57PM +0200, Ahmad Fatoum wrote: > sama5d2 was added along with the update to the upstream > device tree bindings, but wasn't wired in anywhere. > > To prepare for usage in future sama5d2 support, fix > compilation errors relat

Re: [PATCH v2 11/10] clk: at91: fix warning about missing const-safety

2019-04-02 Thread Sam Ravnborg
ames, parent_names, parents_array_size); > ~~~^ > > Avoid this by replacing the xzalloc+memcpy pair with xmemdup. > Zero-initialization of the buffer isn't necessary, because > memcpy spans the whole buffer. > > Suggested-by: Sam Ra

Re: [PATCH v2 10/10] clk: at91: fix warning about missing const-safety

2019-04-01 Thread Sam Ravnborg
Hi Ahmad. On Mon, Apr 01, 2019 at 11:31:06AM +0200, Ahmad Fatoum wrote: > compiling clk-main.c results in: > > warning: passing argument 1 of 'memcpy' discards 'const' qualifier from > pointer target type [-Wdiscarded-qualifiers] > memcpy(clkmain->clk.parent_names, parent_names, parents_array_s

Re: [PATCH v2 09/10] ARM: at91: remove at91sama5_get_ddram_size helper

2019-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2019 at 11:31:05AM +0200, Ahmad Fatoum wrote: > Substitute the current #ifdefery in at91sam9_ddrsdr.h by > open-coding at91sama5_get_ddram_size wherever it was called. > > Suggested-by: Sascha Hauer > Signed-off-by: Ahmad Fatoum Reviewed-b

Re: [PATCH v2 07/10] ARM: at91: remove at91sam9n12_get_ddram_size helper

2019-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2019 at 11:31:03AM +0200, Ahmad Fatoum wrote: > Substitute the current #ifdefery in at91sam9_ddrsdr.h by > open-coding at91sam9n12_get_ddram_size wherever it was called. > > Suggested-by: Sascha Hauer > Signed-off-by: Ahmad Fatoum Reviewed-b

Re: [PATCH v2 06/10] ARM: at91: remove at91sam9g45_get_ddram_size helper

2019-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2019 at 11:31:02AM +0200, Ahmad Fatoum wrote: > Substitute the current #ifdefery in at91sam9_ddrsdr.h by > open-coding at91sam9g45_get_ddram_size wherever it was called. > > Suggested-by: Sascha Hauer > Signed-off-by: Ahmad Fatoum Reviewed-b

Re: [PATCH v2 08/10] ARM: at91: remove at91sam9x5_get_ddram_size helper

2019-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2019 at 11:31:04AM +0200, Ahmad Fatoum wrote: > Substitute the current #ifdefery in at91sam9_ddrsdr.h by > open-coding at91sam9x5_get_ddram_size wherever it was called. > > Suggested-by: Sascha Hauer > Signed-off-by: Ahmad Fatoum Reviewed-b

Re: [PATCH 1/6] include: add SPDX GPL-2.0-only license tags where applicable

2019-03-10 Thread Sam Ravnborg
Hi Roland. On Sun, Mar 10, 2019 at 09:42:25PM +0100, Roland Hieber wrote: > Hi, > > this thread has been open for some time now without any more responses. > The only motion against it was from Oleksij, who asked me remove the > license headers in favour of having only the SPDX-License-Identifier

Re: [PATCH 4/6] ddr_spd: Add function to read eeprom

2019-03-04 Thread Sam Ravnborg
Hi Sascha On Mon, Mar 04, 2019 at 12:38:21PM +0100, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer > --- > common/ddr_spd.c | 81 +++ > include/ddr_spd.h | 6 > 2 files changed, 87 insertions(+) > > diff --git a/common/ddr_spd.c b/common/ddr

  1   2   3   4   5   6   >