Re: [PATCH master 3/4] ddr: imx8m: workaround old spreadsheets not initializing ADDRMAP7

2022-06-23 Thread Teresa Remmet
Am Donnerstag, dem 23.06.2022 um 14:04 +0200 schrieb Ahmad Fatoum: > On 23.06.22 13:47, Teresa Remmet wrote: > > Am Donnerstag, dem 23.06.2022 um 13:26 +0200 schrieb Teresa Remmet: > > > Am Donnerstag, dem 23.06.2022 um 13:14 +0200 schrieb Ahmad > > > Fatoum: > >

Re: [PATCH master 3/4] ddr: imx8m: workaround old spreadsheets not initializing ADDRMAP7

2022-06-23 Thread Teresa Remmet
Hello Ahmad, Am Donnerstag, dem 23.06.2022 um 13:26 +0200 schrieb Teresa Remmet: > Am Donnerstag, dem 23.06.2022 um 13:14 +0200 schrieb Ahmad Fatoum: > > Hi Teresa, > > > > On 23.06.22 12:59, Teresa Remmet wrote: > > > Hello Ahmad, > > > > > &

Re: [PATCH master 3/4] ddr: imx8m: workaround old spreadsheets not initializing ADDRMAP7

2022-06-23 Thread Teresa Remmet
Am Donnerstag, dem 23.06.2022 um 13:14 +0200 schrieb Ahmad Fatoum: > Hi Teresa, > > On 23.06.22 12:59, Teresa Remmet wrote: > > Hello Ahmad, > > > > Am Donnerstag, dem 23.06.2022 um 12:30 +0200 schrieb Ahmad Fatoum: > > > Older NXP DDR spreadsheets don't

Re: [PATCH master 3/4] ddr: imx8m: workaround old spreadsheets not initializing ADDRMAP7

2022-06-23 Thread Teresa Remmet
Hello Ahmad, Am Donnerstag, dem 23.06.2022 um 12:30 +0200 schrieb Ahmad Fatoum: > Older NXP DDR spreadsheets don't initialize ADDRMAP7, leaving it at > its > POR default of zero. Now that barebox looks at ADDRMAP7 to be able to > correctly detect bigger memory sizes, barebox proper on out-of-tree

Re: [PATCH] arm: imx: mmdc_size: Increase row_max for imx8m

2022-06-21 Thread Teresa Remmet
Hi! Am Montag, dem 20.06.2022 um 15:19 +0200 schrieb Ahmad Fatoum: > Hi, > > On 20.06.22 14:47, Teresa Remmet wrote: > > Am Montag, dem 20.06.2022 um 14:38 +0200 schrieb Ahmad Fatoum: > > > On 20.06.22 14:27, Teresa Remmet wrote: > > > > I have set the DDRC_A

Re: [PATCH] arm: imx: mmdc_size: Increase row_max for imx8m

2022-06-20 Thread Teresa Remmet
Am Montag, dem 20.06.2022 um 14:38 +0200 schrieb Ahmad Fatoum: > Hello Teresa, > > On 20.06.22 14:27, Teresa Remmet wrote: > > Hello Ahmad, > > > > Am Montag, dem 20.06.2022 um 14:02 +0200 schrieb Ahmad Fatoum: > > > Hello, > > > > > &

Re: [PATCH] arm: imx: mmdc_size: Increase row_max for imx8m

2022-06-20 Thread Teresa Remmet
Hello Ahmad, Am Montag, dem 20.06.2022 um 14:02 +0200 schrieb Ahmad Fatoum: > Hello, > > On 20.05.22 16:23, Teresa Remmet wrote: > > As DDRC_ADDRMAP7_ROW_B16 and DDRC_ADDRMAP7_ROW_B17 are used > > now for the row size calculation we need to increase row_max to 18. > >

Re: [PATCH] ARM: imx: esdctl: fix LPDDR4 size calculation

2022-05-20 Thread Teresa Remmet
Am Freitag, dem 20.05.2022 um 16:33 +0200 schrieb Lucas Stach: > Hi Teresa, > > Am Freitag, dem 20.05.2022 um 14:16 + schrieb Teresa Remmet: > > Hello Lucas, > > > > Am Freitag, dem 13.05.2022 um 16:16 +0200 schrieb Lucas Stach: > > > The DDRC only use

[PATCH] arm: imx: mmdc_size: Increase row_max for imx8m

2022-05-20 Thread Teresa Remmet
be set and calculation will lead to wrong results even with this patch. Fixes: dad2b5636bd8 ("ARM: imx: Add imx8 support for 18 bit SDRAM row size handle") Signed-off-by: Teresa Remmet --- arch/arm/mach-imx/esdctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] ARM: imx: esdctl: fix LPDDR4 size calculation

2022-05-20 Thread Teresa Remmet
Hello Lucas, Am Freitag, dem 13.05.2022 um 16:16 +0200 schrieb Lucas Stach: > The DDRC only uses the DEVICE_CONFIG field for memory types other > than > LPDDR4. While LPDDR4 always has a bus width of x32, the script aid this is not true for i.MX8M Nano. This SoC has only x16. This is probably why

[PATCH] mtd: nand: nand_omap_gpmc: Fix mtd_info usage

2019-09-29 Thread Teresa Remmet
The mtd_info has not been set correctly in the omap gpmc probe. Remove the mtd_info in the private struct like it has been done in other nand drivers. And update the driver accordingly. Fixes: 76b6f74c5397 ("mtd: nand: Embed struct mtd_info into struct nand_chip") Signed-off-by: Ter

Re: Boards possibly broken due to dts merge of v5.1-rc1

2019-04-08 Thread Teresa Remmet
Hello Sascha, Am Montag, den 08.04.2019, 10:26 +0200 schrieb Sascha Hauer: > On Mon, Apr 08, 2019 at 10:16:02AM +0200, Sascha Hauer wrote: > > Hi, > > > > I had to squash the attached patch into the patch of the v5.1-rc1 > > dts > > kernel merge. Some boards may be broken due to this, please chec

[PATCH] common: bootchooser: Fix compile warning

2019-04-08 Thread Teresa Remmet
Make bootchooser_get_target() static to prevent following warning: common/bootchooser.c:633:28: warning: no previous prototype for ‘bootchooser_get_target’ [-Wmissing-prototypes] struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc) Signed-off-by: Teresa Remmet

[PATCH v2 7/7] arm: dts: am335x-phytec: Use phy-handle instead of phy_id

2019-02-13 Thread Teresa Remmet
Update am335x-phytec som device trees and use phy-handle instead of phy_id. Signed-off-by: Teresa Remmet --- arch/arm/dts/am335x-phytec-phycard-som.dtsi | 7 ++- arch/arm/dts/am335x-phytec-phycore-som.dtsi | 7 ++- arch/arm/dts/am335x-phytec-phyflex-som.dtsi | 12 ++-- 3 files

[PATCH v2 4/7] drivers: of: Add function to enable and register a device by alias

2019-02-13 Thread Teresa Remmet
In some cases node names are not unique and passing the full path is really long. So make add a new device by passing the alias string possible. Signed-off-by: Teresa Remmet --- drivers/of/platform.c | 19 +++ include/of.h | 8 2 files changed, 27 insertions

[PATCH v2 5/7] arm: mach-omap: am335x_generic: Enable nodes by alias where needed

2019-02-13 Thread Teresa Remmet
With the interconnet target module hierarchy the node names used to enable boot devices are not unique any more. Find those nodes by alias now. Signed-off-by: Teresa Remmet --- arch/arm/mach-omap/am33xx_generic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch

[PATCH v2 3/7] arm: configs: am33xx_mlo_defconfig: Enable ti-sysc bus driver

2019-02-13 Thread Teresa Remmet
Signed-off-by: Teresa Remmet --- arch/arm/configs/am335x_mlo_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/am335x_mlo_defconfig b/arch/arm/configs/am335x_mlo_defconfig index 58034b6cea15..b58b71a85937 100644 --- a/arch/arm/configs

[PATCH v2 6/7] net: ethernet: cpsw: cpsw-phy-sel: Use phandle for phy sel

2019-02-13 Thread Teresa Remmet
patch is based on the upstream kernel patch: 18eb8aea7fb2 ("net: ethernet: cpsw-phy-sel: prefer phandle for phy sel") Signed-off-by: Teresa Remmet --- drivers/net/cpsw.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/cpsw.c b/drivers/

[PATCH v2 2/7] arm: configs: omap_defconfig: Enable ti-sysc bus driver

2019-02-13 Thread Teresa Remmet
Signed-off-by: Teresa Remmet --- arch/arm/configs/omap_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/omap_defconfig b/arch/arm/configs/omap_defconfig index 128027a6406b..8615283453d4 100644 --- a/arch/arm/configs/omap_defconfig +++ b/arch/arm

[PATCH v2 1/7] drivers: bus: Add ti-sysc bus driver

2019-02-13 Thread Teresa Remmet
Adds minimal support for the sysc interconnect target module found on many TI SoCs. With this device tree includes have been rearagned. We need the driver to probe the child devices of the bus. Signed-off-by: Teresa Remmet --- Changes in v2: - set driver in Kconfig to default y - Use

Re: AM335x broken

2019-02-13 Thread Teresa Remmet
Am Montag, den 11.02.2019, 20:21 +0100 schrieb Sascha Hauer: > Hi Teresa, > > On Mon, Feb 11, 2019 at 03:44:28PM +0100, Teresa Remmet wrote: > > Hello, > > > > AM335x is broken on current master in multiple ways. > > NAND and and SPI boot are not working ri

Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver

2019-02-13 Thread Teresa Remmet
Am Dienstag, den 12.02.2019, 16:56 -0800 schrieb Andrey Smirnov: > On Tue, Feb 12, 2019 at 5:13 AM Teresa Remmet > wrote: > > > > Hello Andrey, > > > > Am Montag, den 11.02.2019, 18:57 -0800 schrieb Andrey Smirnov: > > > On Mon, Feb 11, 2019 at 7

Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver

2019-02-12 Thread Teresa Remmet
Hello Sascha, Am Dienstag, den 12.02.2019, 09:10 +0100 schrieb Sascha Hauer: > On Mon, Feb 11, 2019 at 04:16:34PM +0100, Teresa Remmet wrote: > > Adds minimal support for the sysc interconnect target module found > > on many TI SoCs. With this device tree includes have been > &

Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver

2019-02-12 Thread Teresa Remmet
Hello Sascha and Sam, Am Dienstag, den 12.02.2019, 09:09 +0100 schrieb Sascha Hauer: > Hi Sam, > > On Mon, Feb 11, 2019 at 04:41:38PM +0100, Sam Ravnborg wrote: > > Hi Teresa. > > > > On Mon, Feb 11, 2019 at 04:16:34PM +0100, Teresa Remmet wrote: > > &g

Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver

2019-02-12 Thread Teresa Remmet
Hello Andrey, Am Montag, den 11.02.2019, 18:57 -0800 schrieb Andrey Smirnov: > On Mon, Feb 11, 2019 at 7:16 AM Teresa Remmet > wrote: > > > > Adds minimal support for the sysc interconnect target module found > > on many TI SoCs. With this device tree includes have be

[PATCH 7/7] arm: dts: am335x-phytec: Use phy-handle instead of phy_id

2019-02-11 Thread Teresa Remmet
Update am335x-phytec som device trees and use phy-handle instead of phy_id. Signed-off-by: Teresa Remmet --- arch/arm/dts/am335x-phytec-phycard-som.dtsi | 7 ++- arch/arm/dts/am335x-phytec-phycore-som.dtsi | 7 ++- arch/arm/dts/am335x-phytec-phyflex-som.dtsi | 12 ++-- 3 files

[PATCH 5/7] arm: mach-omap: am335x_generic: Enable nodes by alias where needed

2019-02-11 Thread Teresa Remmet
With the interconnet target module hierarchy the node names used to enable boot devices are not unique any more. Find those nodes by alias now. Signed-off-by: Teresa Remmet --- arch/arm/mach-omap/am33xx_generic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch

[PATCH 4/7] drivers: of: Add function to enable and register a device by alias

2019-02-11 Thread Teresa Remmet
In some cases node names are not unique and passing the full path is really long. So make add a new device by passing the alias string possible. Signed-off-by: Teresa Remmet --- drivers/of/platform.c | 19 +++ include/of.h | 8 2 files changed, 27 insertions

[PATCH 6/7] net: ethernet: cpsw: cpsw-phy-sel: Use phandle for phy sel

2019-02-11 Thread Teresa Remmet
patch is based on the upstream kernel patch: 18eb8aea7fb2 ("net: ethernet: cpsw-phy-sel: prefer phandle for phy sel") Signed-off-by: Teresa Remmet --- drivers/net/cpsw.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/cpsw.c b/drivers/

[PATCH 2/7] arm: configs: omap_defconfig: Enable ti-sysc bus driver

2019-02-11 Thread Teresa Remmet
Signed-off-by: Teresa Remmet --- arch/arm/configs/omap_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/omap_defconfig b/arch/arm/configs/omap_defconfig index 128027a6406b..8615283453d4 100644 --- a/arch/arm/configs/omap_defconfig +++ b/arch/arm

[PATCH 3/7] arm: configs: am33xx_mlo_defconfig: Enable ti-sysc bus driver

2019-02-11 Thread Teresa Remmet
Signed-off-by: Teresa Remmet --- arch/arm/configs/am335x_mlo_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/am335x_mlo_defconfig b/arch/arm/configs/am335x_mlo_defconfig index 58034b6cea15..b58b71a85937 100644 --- a/arch/arm/configs

[PATCH 0/7] Add ti-sysc bus driver

2019-02-11 Thread Teresa Remmet
ti-sysc bus. Teresa Teresa Remmet (7): drivers: bus: Add ti-sysc bus driver arm: configs: omap_defconfig: Enable ti-sysc bus driver arm: configs: am33xx_mlo_defconfig: Enable ti-sysc bus driver drivers: of: Add function to enable and register a device by alias arm: mach-omap

[PATCH 1/7] drivers: bus: Add ti-sysc bus driver

2019-02-11 Thread Teresa Remmet
Adds minimal support for the sysc interconnect target module found on many TI SoCs. With this device tree includes have been rearagned. We need the driver to probe the child devices of the bus. Signed-off-by: Teresa Remmet --- drivers/bus/Kconfig | 7 +++ drivers/bus/Makefile | 1

AM335x broken

2019-02-11 Thread Teresa Remmet
Hello, AM335x is broken on current master in multiple ways. NAND and and SPI boot are not working right now as the image size can not be found: barebox 2019.01.0-00305-g96abbe544e19 #1682 Mon Feb 11 15:20:00 CET 2019 Board: Phytec phyCORE AM335x nand: ONFI flash detected nand: NAND device: Man

[PATCH 4/4] arm: boards: phytec-som-am335x: Add bootchooser to bootsource

2019-01-07 Thread Teresa Remmet
From: Daniel Schultz Add bootchooser as primary boot source for NAND and eMMC. Signed-off-by: Daniel Schultz Signed-off-by: Teresa Remmet --- .../phytec-som-am335x/defaultenv-physom-am335x/init/bootsource| 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch

[PATCH 1/4] ARM: configs: omap_defconfig: Add bootchooser

2019-01-07 Thread Teresa Remmet
From: Daniel Schultz Signed-off-by: Daniel Schultz Signed-off-by: Teresa Remmet --- arch/arm/configs/omap_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/omap_defconfig b/arch/arm/configs/omap_defconfig index e41757b9190b..128027a6406b 100644 --- a/arch/arm

[PATCH 0/4] arm: boards: phytec-som-am335x: Add bootchooser support

2019-01-07 Thread Teresa Remmet
Hello, this patchstack from Daniel adds bootchooser support to phytec am335x boards. I updated the patchstack to a more recent barebox version and added some small fixes. Teresa Daniel Schultz (4): ARM: configs: omap_defconfig: Add bootchooser ARM: dts: am335x-phytec-state: Reduce partition

[PATCH 3/4] ARM: dts: am335x-phytec-state: Add state partition for bootchooser

2019-01-07 Thread Teresa Remmet
From: Daniel Schultz Signed-off-by: Daniel Schultz Signed-off-by: Teresa Remmet --- arch/arm/dts/am335x-phytec-state.dtsi | 57 +-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/am335x-phytec-state.dtsi b/arch/arm/dts/am335x

[PATCH 2/4] ARM: dts: am335x-phytec-state: Reduce partition size

2019-01-07 Thread Teresa Remmet
From: Daniel Schultz Partition size was not calculated correct. Set the correct size. Signed-off-by: Daniel Schultz Signed-off-by: Teresa Remmet --- arch/arm/dts/am335x-phytec-state.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/am335x-phytec-state.dtsi

[PATCH for next] mtd: nand: nand_omap_gpmc: Fix GPMC_BCH_RESULT offset

2018-12-19 Thread Teresa Remmet
Using BCH rom code mode we start calculating with GPMC_BCH_RESULTx_1. Fix offset for correct error correction. Fixes: d4077860c902 ("mtd: nand: omap: unbreak BCH8 support") Signed-off-by: Teresa Remmet --- drivers/mtd/nand/nand_omap_gpmc.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] commands: nand-bitflip: Add documentation for option '-c'

2018-12-18 Thread Teresa Remmet
Signed-off-by: Teresa Remmet --- commands/nand-bitflip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/commands/nand-bitflip.c b/commands/nand-bitflip.c index a8a97c153aa0..cfde2f4040e7 100644 --- a/commands/nand-bitflip.c +++ b/commands/nand-bitflip.c @@ -107,6 +107,7

[PATCH for next] mtd: nand: nand_base: Fix compile warning if CONFIG_MTD_WRITE is not enabled

2018-12-17 Thread Teresa Remmet
drivers/mtd/nand/nand_base.c:337:12: warning: 'nand_default_block_markbad' defined but not used [-Wunused-function] Add __maybe_unused again to silence warning when CONFIG_MTD_WRITE is not enabled. Signed-off-by: Teresa Remmet --- drivers/mtd/nand/nand_base.c | 2 +- 1 file

Re: AM335x NAND boot on next

2018-12-17 Thread Teresa Remmet
Hello Sascha, Am Montag, den 17.12.2018, 12:14 +0100 schrieb Sascha Hauer: > Hi Teresa, > > On Mon, Dec 17, 2018 at 11:54:30AM +0100, Teresa Remmet wrote: > > > > Hello Sascha, > > > > I watend to test the gpmc driver changes for our am335x boards > >

[PATCH 2/2] arm: dts: am335x strip: Don't strip timer2 anymore

2018-12-17 Thread Teresa Remmet
dmtimer has been converted to a real driver and needs a device now. am335x devices are taken from dt also in mlo. Don't strip the dmtimer device from the include as we need it now. Signed-off-by: Teresa Remmet --- arch/arm/dts/am33xx-clocks-strip.dtsi | 2 -- arch/arm/dts/am33xx-strip

[PATCH 1/2] arm: boards: vscom-baltos: Run environment_initcall only on correct board

2018-12-17 Thread Teresa Remmet
Check for the correct hardware before reading the eeprom. Signed-off-by: Teresa Remmet --- arch/arm/boards/vscom-baltos/board.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boards/vscom-baltos/board.c b/arch/arm/boards/vscom-baltos/board.c index 39f40a6061f8..c64864d43200

Re: [PATCH 14/23] ARM: omap: dmtimer: Turn into a driver

2018-12-17 Thread Teresa Remmet
Hello Sascha, ... > diff --git a/arch/arm/mach-omap/dmtimer.c > b/drivers/clocksource/timer-ti-dm.c > similarity index 72% > rename from arch/arm/mach-omap/dmtimer.c > rename to drivers/clocksource/timer-ti-dm.c > index e223b8cc8f..635b860cf9 100644 > --- a/arch/arm/mach-omap/dmtimer.c > +++ b/dr

AM335x NAND boot on next

2018-12-17 Thread Teresa Remmet
Hello Sascha, I watend to test the gpmc driver changes for our am335x boards using latest next. I noticed that booting from nand is not working correct any more. The MLO can not correctly obtain the image size of the barebox image. barebox 2018.11.0-00199-g5a1a5ed2537d #1549 Mon Dec 17 10:46:01 C

Re: Transferring files over tftp

2018-11-29 Thread Teresa Remmet
Hello Sascha, Am Freitag, den 16.11.2018, 08:32 +0100 schrieb Sascha Hauer: ... > > --8<- > - > > From bf3de3391c958c9c44fcfa54b2c1a6a29e68a5a4 Mon Sep 17 00:00:00 > 2001 > From: Sascha Hauer > Date: Fri, 16 Nov 2018 08:24:06

Re: Transferring files over tftp

2018-11-20 Thread Teresa Remmet
Hello Sascha, Am Freitag, den 16.11.2018, 08:32 +0100 schrieb Sascha Hauer: > Hi Teresa, > > On Thu, Nov 15, 2018 at 04:24:18PM +0100, Teresa Remmet wrote: > > > > Hello, > > > > I am facing tftp issues when trying to transfer files &

[PATCH] arm: boards: phytec-som-am335x: Fix mac overwrite from state

2018-11-20 Thread Teresa Remmet
state_read_mac() returns 0 on success so mac never was overwritten. Fix this and add check for valid mac address. Signed-off-by: Teresa Remmet --- arch/arm/boards/phytec-som-am335x/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boards/phytec-som-am335x

Transferring files over tftp

2018-11-15 Thread Teresa Remmet
Hello, I am facing tftp issues when trying to transfer files > 2GB. This ends up in a crash: barebox@Phytec phyCORE AM335x:/ cp /mnt/tftp/2GB_plus_1M . eth0: 100Mbps full duplex link detected T T T T T T T T T T T T T T read: Connection timed out unable to handle paging request at address 0x200d

[PATCH] arm: mach-omap: xload: Enable network interface

2018-11-14 Thread Teresa Remmet
Since f0624a701513 ("net: Do not route traffic to interfaces that are not up") interfaces need to be "up" before used. To make enthernet boot work again enable the interface after dhcp is set up. Signed-off-by: Teresa Remmet --- arch/arm/mach-omap/xload.c | 2 ++ 1 file c

[PATCH] arm: boards: phytec-som-am335x: Rename kernel image

2018-09-05 Thread Teresa Remmet
Use zImage instead of linuximage for kernel. Signed-off-by: Teresa Remmet --- arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/emmc | 2 +- arch/arm/boards/phytec-som-am335x/defaultenv-physom-am335x/boot/mmc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 34/56] UBI: introduce the VID buffer concept

2018-08-29 Thread Teresa Remmet
store the actual pointer of the underlying buffer, but will soon add the number of VID headers contained in the buffer. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger [Fix conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 40 +-- drivers/m

[PATCH 32/56] UBI: provide an helper to query LEB information

2018-08-29 Thread Teresa Remmet
Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 17 + drivers/mtd/ubi/fastmap.c | 8 ++-- drivers/mtd/ubi/ubi.h | 17 + 3 files changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b

[PATCH 50/56] ubi: Fix copy/paste error in function documentation

2018-08-29 Thread Teresa Remmet
From: Sascha Hauer The function documentation of leb_write_trylock is copied from leb_write_lock. Replace the function name with the correct one. Signed-off-by: Sascha Hauer Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 2 +- 1 file changed, 1

[PATCH 56/56] ubi: Initialize Fastmap checkmapping correctly

2018-08-29 Thread Teresa Remmet
From: Richard Weinberger We cannot do it last, otherwithse it will be skipped for dynamic volumes. Reported-by: Lachmann, Juergen Fixes: 34653fd8c46e ("ubi: fastmap: Check each mapping only once") Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/v

[PATCH 55/56] mtd: ubi: Update ubi-media.h to dual license

2018-08-29 Thread Teresa Remmet
Signed-off-by: Richard Weinberger [Fixed conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/ubi-media.h | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi/ubi-media.h index 43584843542f..195ff8ca8211 100644

[PATCH 52/56] ubi: fastmap: Correctly handle interrupted erasures in EBA

2018-08-29 Thread Teresa Remmet
nberger [Fixed compile issue] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 88 ++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 69a6242e054a..c0653122ffc5 100644 --- a/

[PATCH 53/56] ubi: fastmap: Check each mapping only once

2018-08-29 Thread Teresa Remmet
From: Richard Weinberger Maintain a bitmap to keep track of which LEB->PEB mapping was checked already. That way we have to read back VID headers only once. Signed-off-by: Richard Weinberger [Fixed Conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/build.c | 1 + drivers/mtd/

[PATCH 51/56] mtd: ubi: wl: Fix error return code in ubi_wl_init()

2018-08-29 Thread Teresa Remmet
on Signed-off-by: Richard Weinberger [Fixed conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/wl.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c index 8d45b318f5c1..fa1b8137024a 100644 --- a/drivers/mtd/ubi/wl.c +++

[PATCH 54/56] ubi: fastmap: Detect EBA mismatches on-the-fly

2018-08-29 Thread Teresa Remmet
From: Richard Weinberger Now we have the machinery to detect EBA mismatches on-the-fly by comparing the in-memory volume ID and LEB number with the found VID header. This helps to detect malfunction of Fastmap. Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd

[PATCH 49/56] ubi: Fastmap: Fix typo

2018-08-29 Thread Teresa Remmet
From: Sascha Hauer Fix misspelling of 'available' in function name. Signed-off-by: Sascha Hauer Signed-off-by: Richard Weinberger [Fixed conficts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap-wl.c | 2 +- drivers/mtd/ubi/wl.c | 2 +- drivers/mtd/ubi/wl.h

[PATCH 47/56] ubi: fastmap: Clean up the initialization of pointer p

2018-08-29 Thread Teresa Remmet
x27;p' during its initialization is never read Signed-off-by: Colin Ian King Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/f

[PATCH 48/56] ubi: fastmap: Erase outdated anchor PEBs during attach

2018-08-29 Thread Teresa Remmet
. The easiest way to make that sure is to erase all outdated fastmap anchor PEBs synchronously during attach. Signed-off-by: Sascha Hauer Reviewed-by: Richard Weinberger Fixes: dbb7d2a88d2a ("UBI: Add fastmap core") Cc: Signed-off-by: Richard Weinberger [Fixed conflicts] Signed-off-by

[PATCH 45/56] ubi: fastmap: fix spelling mistake: "invalidiate" -> "invalidate"

2018-08-29 Thread Teresa Remmet
From: Colin Ian King Trivial fix to spelling mistake in ubi_err error message Signed-off-by: Colin Ian King Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 43/56] ubi: fastmap: Fix slab corruption

2018-08-29 Thread Teresa Remmet
24>] (kmem_cache_free+0x3e0/0x450) [<80272024>] (kmem_cache_free) from [<8057cb88>] (destroy_ai+0x150/0x1e8) [<8057cb88>] (destroy_ai) from [<8057ef1c>] (ubi_attach+0x2c4/0x450) [<8057ef1c>] (ubi_attach) from [<8056fe70>] (u

[PATCH 44/56] ubi: pr_err() strings should end with newlines

2018-08-29 Thread Teresa Remmet
From: Ben Dooks In ubi_attach_mtd_dev() the pr_err() calls should have their messgaes terminated with a new-line to avoid other messages being concatenated onto the end. Signed-off-by: Ben Dooks Signed-off-by: Richard Weinberger [Fix conflics] Signed-off-by: Teresa Remmet --- drivers/mtd

[PATCH 46/56] UBI: Fix two typos in comments

2018-08-29 Thread Teresa Remmet
From: Uwe Kleine-König Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/ubi-media.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi/ubi-media.h index

[PATCH 42/56] ubi/upd: Always flush after prepared for an update

2018-08-29 Thread Teresa Remmet
e-marker set. The patch looks bigger and I doubt it is worth it since usually the write() will wait from time to time for a new EB since usually there not that many spare EB that can be used. Cc: sta...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Richard Weinberger Si

[PATCH 26/56] UBI: provide helpers to allocate and free aeb elements

2018-08-29 Thread Teresa Remmet
Weinberger [Fixed kzalloc/free conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 69 ++- drivers/mtd/ubi/fastmap.c | 29 +--- drivers/mtd/ubi/ubi.h | 3 +++ drivers/mtd/ubi/vtbl.c| 3 ++- 4 files changed, 69

[PATCH 41/56] UBI: Fix typos

2018-08-29 Thread Teresa Remmet
From: "Andrew F. Davis" Signed-off-by: Andrew F. Davis Signed-off-by: Jiri Kosina Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/Kconfig | 2 +- drivers/mtd/ubi/io.c| 2 +- drivers/mtd/ubi/ubi.h | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 22/56] UBI: factorize code used to manipulate volumes at attach time

2018-08-29 Thread Teresa Remmet
From: Boris Brezillon Volume creation/search code is duplicated in a few places (fastmap and non fastmap code). Create some helpers to factorize the code. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 151

[PATCH 28/56] UBI: simplify recover_peb() code

2018-08-29 Thread Teresa Remmet
[Fix conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 114 -- 1 file changed, 74 insertions(+), 40 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 9decc0e1ecce..bc2dc2ef4371 100644 --- a/drivers/mtd

[PATCH 30/56] UBI: add an helper to check lnum validity

2018-08-29 Thread Teresa Remmet
From: Boris Brezillon ubi_leb_valid() is here to replace the lnum < 0 || lnum >= vol->reserved_pebs checks. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger [Fixed conflicts due missing cdev] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/kapi.c | 12 ++--

[PATCH 20/56] UBI: fastmap: avoid multiple be32_to_cpu() when unneccesary

2018-08-29 Thread Teresa Remmet
From: Boris Brezillon process_pool_aeb() does several times the be32_to_cpu(new_vh->vol_id) operation. Create a temporary variable and do it once. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger [Fix conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c

[PATCH 18/56] UBI: fastmap: use ubi_find_volume() instead of open coding it

2018-08-29 Thread Teresa Remmet
From: Boris Brezillon process_pool_aeb() re-implements the logic found in ubi_find_volume(). Call ubi_find_volume() to avoid this duplication. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 23

[PATCH 16/56] ubi: Check whether the Fastmap anchor matches the super block

2018-08-29 Thread Teresa Remmet
From: Richard Weinberger This helps to detect cases where an user copies an UBI image to another target with different bad blocks. Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[PATCH 39/56] UBI: Fix crash in try_recover_peb()

2018-08-29 Thread Teresa Remmet
pointer from the VID buffer, like is done everywhere else. Fixes: 3291b52f9ff0acc8 ("UBI: introduce the VID buffer concept") Signed-off-by: Geert Uytterhoeven Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 1 + 1 fi

[PATCH 40/56] ubi: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()

2018-08-29 Thread Teresa Remmet
-by: Boris Brezillon Acked-by: Sheng Yong Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index cf5abef8c2a7..52f24

[PATCH 24/56] UBI: fastmap: use ubi_rb_for_each_entry() in unmap_peb()

2018-08-29 Thread Teresa Remmet
From: Boris Brezillon Use the ubi_rb_for_each_entry() macro instead of open-coding it. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a

[PATCH 38/56] ubi: fix swapped arguments to call to ubi_alloc_aeb

2018-08-29 Thread Teresa Remmet
eviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index bd7abf55b768..cf5abef8c2a7 100644 --- a/drive

[PATCH 33/56] UBI: hide EBA internals

2018-08-29 Thread Teresa Remmet
, which will be needed to support the LEB consolidation concept. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger [Fix conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/build.c | 2 +- drivers/mtd/ubi/eba.c | 166 drivers

[PATCH 29/56] UBI: simplify LEB write and atomic LEB change code

2018-08-29 Thread Teresa Remmet
each error path. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger [Fix conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 271 +- 1 file changed, 113 insertions(+), 158 deletions(-) diff --git a/drivers/mtd/ubi

[PATCH 37/56] ubi: Fix Fastmap's update_vol()

2018-08-29 Thread Teresa Remmet
("UBI: Add fastmap core") Signed-off-by: Richard Weinberger Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger [Fix conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubi/f

[PATCH 36/56] ubi: Fix races around ubi_refill_pools()

2018-08-29 Thread Teresa Remmet
face power cut the freshly written PEB will not scanned and unnoticed. Solve the issue by locking the pools until Fastmap is written. Cc: Fixes: dbb7d2a88d ("UBI: Add fastmap core") Signed-off-by: Richard Weinberger [Fix conflicts] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fa

[PATCH 31/56] UBI: provide an helper to check whether a LEB is mapped or not

2018-08-29 Thread Teresa Remmet
erger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 12 drivers/mtd/ubi/kapi.c | 4 ++-- drivers/mtd/ubi/ubi.h | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index fd8368286825..704f67dfb6a1 100644

[PATCH 35/56] ubi: Deal with interrupted erasures in WL

2018-08-29 Thread Teresa Remmet
. Cc: Fixes: dbb7d2a88d ("UBI: Add fastmap core") Signed-off-by: Richard Weinberger [Fix conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/wl.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/

[PATCH 27/56] UBI: move the global ech and vidh variables into struct ubi_attach_info

2018-08-29 Thread Teresa Remmet
global variable. And also because global variables should be avoided in general. Signed-off-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 39 +++ drivers/mtd/ubi/ubi.h| 4 2 files

[PATCH 23/56] UBI: factorize destroy_av() and ubi_remove_av() code

2018-08-29 Thread Teresa Remmet
ned-off-by: Richard Weinberger [Fix conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c index d450f6c0d65b..f42c33a10fef 100644 --

[PATCH 25/56] UBI: fastmap: use ubi_io_{read, write}_data() instead of ubi_io_{read, write}()

2018-08-29 Thread Teresa Remmet
: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 683ac0d9c4ab..2bf626f8075e 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -809,7

[PATCH 21/56] UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header

2018-08-29 Thread Teresa Remmet
ned-off-by: Richard Weinberger [Fixed conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/fastmap.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 6ef94189b612..c10ef0650760 100644 --- a/drivers/mtd/ubi

[PATCH 19/56] UBI: fix add_fastmap() to use the vid_hdr passed in argument

2018-08-29 Thread Teresa Remmet
: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c index a5d48932ed33..4d3a936ae861 100644 --- a/drivers/mtd/ubi/attach.c +++ b/drivers/mtd/ubi/attach.c

[PATCH 07/56] UBI: Fix static volume checks when Fastmap is used

2018-08-29 Thread Teresa Remmet
eported-by: Ezequiel Garcia Tested-by: Ezequiel Garcia Signed-off-by: Richard Weinberger [Fixed conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 21 +++-- drivers/mtd/ubi/fastmap.c | 1 + drivers/mtd/ubi/ubi.h | 2 ++ 3 files changed, 22 insertions(+),

[PATCH 15/56] ubi: Rework Fastmap attach base code

2018-08-29 Thread Teresa Remmet
: Teresa Remmet --- drivers/mtd/ubi/attach.c | 100 -- drivers/mtd/ubi/fastmap.c | 36 +++-- drivers/mtd/ubi/ubi.h | 28 - drivers/mtd/ubi/wl.c | 39 ++ 4 files changed, 160 insertions(+), 43 deletions

[PATCH 17/56] ubi: Be more paranoid while seaching for the most recent Fastmap

2018-08-29 Thread Teresa Remmet
root cause much more difficult. So, be debug friendly and fall back to scanning mode of we're facing an ECC error while scanning for Fastmap. Cc: Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/attach.c | 28 drivers/mtd/ubi/

[PATCH 08/56] ubi: Make recover_peb power cut aware

2018-08-29 Thread Teresa Remmet
Jörg Pfähler Reviewed-by: Jörg Pfähler Signed-off-by: Richard Weinberger [Fixed minor conflict] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/eba.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 6e09cfb

[PATCH 09/56] ubi: Fix race condition between ubi device creation and udev

2018-08-29 Thread Teresa Remmet
] Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/build.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 40fa890c9e59..d5c3719482cf 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -633,6

[PATCH 05/56] UBI: Clean up return in ubi_remove_volume()

2018-08-29 Thread Teresa Remmet
From: Dan Carpenter My static checker says that "err" can be uninitialized if "vol->reserved_pebs" is <= 0. I don't think that can happen but returning a literal is cleaner anyway. Signed-off-by: Dan Carpenter Signed-off-by: Richard Weinberger Signed-off-by:

[PATCH 06/56] UBI: Set free_count to zero before walking through erase list

2018-08-29 Thread Teresa Remmet
to zero in wl_init(), so the free_count variable always has the maybe wrong value 0 in U-Boot. Signed-off-by: Heiko Schocher Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Teresa Remmet --- drivers/mtd/ubi/wl.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

  1   2   3   4   >