Re: [PATCH 1/3] ARM v7: fix mmu-off operation

2013-05-17 Thread Enrico Scholz
Sascha Hauer writes: >> So you can drop this stack push by using r12 instead of r10. That's fine >> I think, but should be a patch of its own. Can you resend this as two >> patches? > > Oh, I just saw you can't since then r12 would be corrupted when > v7_mmu_cache_flush is called from v7_mmu_cach

Re: [PATCH 1/3] ARM v7: fix mmu-off operation

2013-05-17 Thread Sascha Hauer
On Wed, May 15, 2013 at 08:28:11AM +0200, Sascha Hauer wrote: > Hi Enrico, > > On Tue, May 14, 2013 at 03:14:54PM +0200, Enrico Scholz wrote: > > Although conclusions in 50d1b2de8ea0f3b8d89fe3a97ce64315996ed4cb "ARM > > v7: Fix register corruption in v7_mmu_cache_off" are correct, the > > implemen

Re: [PATCH 1/3] ARM v7: fix mmu-off operation

2013-05-14 Thread Sascha Hauer
Hi Enrico, On Tue, May 14, 2013 at 03:14:54PM +0200, Enrico Scholz wrote: > Although conclusions in 50d1b2de8ea0f3b8d89fe3a97ce64315996ed4cb "ARM > v7: Fix register corruption in v7_mmu_cache_off" are correct, the > implemented fix is not complete because the following failure can > happen: > > 1

[PATCH 1/3] ARM v7: fix mmu-off operation

2013-05-14 Thread Enrico Scholz
Although conclusions in 50d1b2de8ea0f3b8d89fe3a97ce64315996ed4cb "ARM v7: Fix register corruption in v7_mmu_cache_off" are correct, the implemented fix is not complete because the following failure can happen: 1. d-cache contains the cache line around 'sp' 2. v7_mmu_cache_off() disables cache 3.