Re: [PATCH 1/3] ARM64: entry: save/restore potentially clobbered registers

2019-12-20 Thread Ahmad Fatoum
Hi, On 12/20/19 4:42 PM, Lucas Stach wrote: >> I did the same in <20191002075754.9257-1-a.fat...@pengutronix.de>, except for >> x4-x6 instead of x19-x21, but Rouven* [was missing here] > reported that his i.MX8 still didn't boot. > > I have not thoroughly analyzed the called cache maintenance f

Re: [PATCH 1/3] ARM64: entry: save/restore potentially clobbered registers

2019-12-20 Thread Lucas Stach
Hi Ahmad, On Fr, 2019-12-20 at 16:34 +0100, Ahmad Fatoum wrote: > Hello Lucas, > > On 12/19/19 10:13 AM, Lucas Stach wrote: > > While the comment is correct that currently arm_early_mmu_cache_invalidate() > > is only a call to to v8_invalidate_icache_all() , which doesn't clobber > > x0-x2, > >

Re: [PATCH 1/3] ARM64: entry: save/restore potentially clobbered registers

2019-12-20 Thread Ahmad Fatoum
Hello Lucas, On 12/19/19 10:13 AM, Lucas Stach wrote: > While the comment is correct that currently arm_early_mmu_cache_invalidate() > is only a call to to v8_invalidate_icache_all() , which doesn't clobber x0-x2, > this starts to fall apart as soon as we do something more in this function. > > M

[PATCH 1/3] ARM64: entry: save/restore potentially clobbered registers

2019-12-19 Thread Lucas Stach
While the comment is correct that currently arm_early_mmu_cache_invalidate() is only a call to to v8_invalidate_icache_all() , which doesn't clobber x0-x2, this starts to fall apart as soon as we do something more in this function. Make sure to properly save/restore the parameters passed to the en