Re: [PATCH 11/18] block: parse partition table on block device registration

2023-06-06 Thread Ahmad Fatoum
On 01.06.23 09:42, Sascha Hauer wrote: > On Wed, May 31, 2023 at 04:59:20PM +0200, Ahmad Fatoum wrote: >> Every instance where we register a block device, it's followed by an >> attempt to parse the partition table, most often with a warning when >> it fails. Thus let's move partition table parsing

Re: [PATCH 11/18] block: parse partition table on block device registration

2023-06-01 Thread Ahmad Fatoum
On 01.06.23 10:31, Ahmad Fatoum wrote: > On 01.06.23 10:24, Ulrich Ölmann wrote: >> Hi Ahmad, >> >> again a small typo: >> >> On Wed, May 31 2023 at 16:59 +0200, Ahmad Fatoum >> wrote: >>> Every instance where we register a block device, it's followed by an >> >> s/device, it's/device is/ > > I

Re: [PATCH 11/18] block: parse partition table on block device registration

2023-06-01 Thread Marco Felsch
On 23-06-01, Sascha Hauer wrote: > On Wed, May 31, 2023 at 04:59:20PM +0200, Ahmad Fatoum wrote: > > Every instance where we register a block device, it's followed by an > > attempt to parse the partition table, most often with a warning when > > it fails. Thus let's move partition table parsing in

Re: [PATCH 11/18] block: parse partition table on block device registration

2023-06-01 Thread Ahmad Fatoum
On 01.06.23 10:24, Ulrich Ölmann wrote: > Hi Ahmad, > > again a small typo: > > On Wed, May 31 2023 at 16:59 +0200, Ahmad Fatoum > wrote: >> Every instance where we register a block device, it's followed by an > > s/device, it's/device is/ I don't think that's correct. Should I change it to b

Re: [PATCH 11/18] block: parse partition table on block device registration

2023-06-01 Thread Ulrich Ölmann
Hi Ahmad, again a small typo: On Wed, May 31 2023 at 16:59 +0200, Ahmad Fatoum wrote: > Every instance where we register a block device, it's followed by an s/device, it's/device is/ Best regards Ulrich > attempt to parse the partition table, most often with a warning when > it fails. Thus

Re: [PATCH 11/18] block: parse partition table on block device registration

2023-06-01 Thread Sascha Hauer
On Wed, May 31, 2023 at 04:59:20PM +0200, Ahmad Fatoum wrote: > Every instance where we register a block device, it's followed by an > attempt to parse the partition table, most often with a warning when > it fails. Thus let's move partition table parsing into > blockdevice_register. > > Signed-of

Re: [PATCH 11/18] block: parse partition table on block device registration

2023-05-31 Thread Marco Felsch
On 23-05-31, Ahmad Fatoum wrote: > Every instance where we register a block device, it's followed by an > attempt to parse the partition table, most often with a warning when > it fails. Thus let's move partition table parsing into > blockdevice_register. > > Signed-off-by: Ahmad Fatoum Reviewed

[PATCH 11/18] block: parse partition table on block device registration

2023-05-31 Thread Ahmad Fatoum
Every instance where we register a block device, it's followed by an attempt to parse the partition table, most often with a warning when it fails. Thus let's move partition table parsing into blockdevice_register. Signed-off-by: Ahmad Fatoum --- arch/sandbox/board/hostfile.c | 4 common/bl