Re: [PATCH 15/19] fastboot net: implement fastboot over UDP

2020-06-19 Thread Sascha Hauer
On Thu, Jun 18, 2020 at 08:33:03PM +0200, Daniel Glöckner wrote: > Hello Sascha, > > Am 18.06.20 um 13:59 schrieb Sascha Hauer: > > On Wed, Jun 17, 2020 at 09:32:45PM +0200, Daniel Glöckner wrote: > >>> +static void fastboot_start_download_net(struct fastboot *fb) > >>> +{ > >>> + struct fastboot_

Re: [PATCH 15/19] fastboot net: implement fastboot over UDP

2020-06-18 Thread Daniel Glöckner
Hello Sascha, Am 18.06.20 um 13:59 schrieb Sascha Hauer: > On Wed, Jun 17, 2020 at 09:32:45PM +0200, Daniel Glöckner wrote: >>> +static void fastboot_start_download_net(struct fastboot *fb) >>> +{ >>> + struct fastboot_net *fbn = container_of(fb, struct fastboot_net, >>> +

Re: [PATCH 15/19] fastboot net: implement fastboot over UDP

2020-06-18 Thread Sascha Hauer
On Wed, Jun 17, 2020 at 09:32:45PM +0200, Daniel Glöckner wrote: > Hello Sascha, > > Am 17.06.20 um 10:11 schrieb Sascha Hauer: > > > + ret = fastboot_net_wait_may_send(fbn); > > + if (ret) > > + return ret; > > Where is the part that aborts the session on timeout? Ok, will add it

Re: [PATCH 15/19] fastboot net: implement fastboot over UDP

2020-06-17 Thread Daniel Glöckner
Hello Sascha, Am 17.06.20 um 10:11 schrieb Sascha Hauer: > + ret = fastboot_net_wait_may_send(fbn); > + if (ret) > + return ret; Where is the part that aborts the session on timeout? > +static void fastboot_start_download_net(struct fastboot *fb) > +{ > + struct fastboot

[PATCH 15/19] fastboot net: implement fastboot over UDP

2020-06-17 Thread Sascha Hauer
From: Edmund Henniges This implements the UDP variant of the fastboot protocol. The only way to start the service for now is to compile with CONFIG_FASTBOOT_NET_ON_BOOT. The service will bind to the network interface that provides the IPv4 gateway. Sending an OKAY packet before performing a rest