Re: [PATCH 3/4] ratp: implement support for GPIO commands

2018-08-22 Thread Sascha Hauer
On Tue, Aug 21, 2018 at 05:20:00PM +0200, Aleksander Morgado wrote: > Introduce three new RATP commands that allow getting and setting GPIO > values as well as configuring the direction of the GPIO pins. > Same here as with the i2c bus/address thing. Being to able to use names for the GPIOs would

Re: [PATCH 3/4] ratp: implement support for GPIO commands

2018-08-21 Thread Andrey Smirnov
On Tue, Aug 21, 2018 at 8:20 AM Aleksander Morgado wrote: > > Introduce three new RATP commands that allow getting and setting GPIO > values as well as configuring the direction of the GPIO pins. > I avoided repeating nits I already mentioned in i2c patch, some additional nits are below >

[PATCH 3/4] ratp: implement support for GPIO commands

2018-08-21 Thread Aleksander Morgado
Introduce three new RATP commands that allow getting and setting GPIO values as well as configuring the direction of the GPIO pins. Signed-off-by: Aleksander Morgado --- common/ratp/Makefile | 1 + common/ratp/gpio.c | 148 +++ include/ratp_bb.h|