We currently build all defconfigs when no architecture was specified,
which leads to surprising behavior, e.g.

  ./MAKEALL some_defconfig

will start building for all architectures and ignore the argument
completely. Improve upon this by calling do_build_all only if
there are no positional arguments.

Signed-off-by: Ahmad Fatoum <a.fat...@pengutronix.de>
---
 MAKEALL | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index df318c6d123c..68ebe6ef98a3 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -281,20 +281,20 @@ then
        REGEX="*"
 fi
 
-if [ ! "${ARCH}" ] || [ ! -d arch/${ARCH} ]
-then
-       do_build_all
-       if [ $? -eq 0 ]
-       then
-               echo "You need to specify the ARCH or CROSS_COMPILE_<arch> or 
CROSS_COMPILE_<target> in your config file"
-               usage
-               exit 1
-       fi
-       exit 0
-fi
-
 if [ $# -eq 0 ]
 then
+       if [ ! "${ARCH}" ] || [ ! -d arch/${ARCH} ]
+       then
+               do_build_all
+               if [ $? -eq 0 ]
+               then
+                       echo "You need to specify the ARCH or 
CROSS_COMPILE_<arch> or CROSS_COMPILE_<target> in your config file"
+                       usage
+                       exit 1
+               fi
+               exit 0
+       fi
+
        do_build ${ARCH} "${REGEX}"
 else
        for i in $*; do
-- 
2.39.2


Reply via email to