Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-03-01 Thread Sascha Hauer
On Wed, 28 Feb 2024 19:03:20 +0100, Ahmad Fatoum wrote: > OP-TEE header is checked once in PBL, saved into scratch area after > verification and then checked again in barebox proper. > > The check in PBL fails silently, but the check in barebox proper that > should always follow, because the hea

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 12:13, Marco Felsch wrote: > On 24-02-29, Ahmad Fatoum wrote: >> On 29.02.24 10:33, Marco Felsch wrote: >>> On 24-02-29, Ahmad Fatoum wrote: hdr is a valid pointer for me, but it doesn't point at a header, which causes me to get an error message. >>> >>> Yes, I have noti

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Marco Felsch
On 24-02-29, Ahmad Fatoum wrote: > On 29.02.24 10:33, Marco Felsch wrote: > > On 24-02-29, Ahmad Fatoum wrote: > >> hdr is a valid pointer for me, but it doesn't point at a header, which > >> causes > >> me to get an error message. > > > > Yes, I have noticed the code path for non-pbl part as wel

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 10:33, Marco Felsch wrote: > On 24-02-29, Ahmad Fatoum wrote: >> hdr is a valid pointer for me, but it doesn't point at a header, which causes >> me to get an error message. > > Yes, I have noticed the code path for non-pbl part as well now :/ > > I was thinking about: > > if (

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Marco Felsch
On 24-02-29, Ahmad Fatoum wrote: > On 29.02.24 10:10, Marco Felsch wrote: > > Hi Ahmad, > > > > On 24-02-28, Ahmad Fatoum wrote: > >> OP-TEE header is checked once in PBL, saved into scratch area after > >> verification and then checked again in barebox proper. > >> > >> The check in PBL fails sil

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Ahmad Fatoum
On 29.02.24 10:10, Marco Felsch wrote: > Hi Ahmad, > > On 24-02-28, Ahmad Fatoum wrote: >> OP-TEE header is checked once in PBL, saved into scratch area after >> verification and then checked again in barebox proper. >> >> The check in PBL fails silently, but the check in barebox proper that >> sh

Re: [PATCH master] optee: don't warn about missing OP-TEE header

2024-02-29 Thread Marco Felsch
Hi Ahmad, On 24-02-28, Ahmad Fatoum wrote: > OP-TEE header is checked once in PBL, saved into scratch area after > verification and then checked again in barebox proper. > > The check in PBL fails silently, but the check in barebox proper that > should always follow, because the header isn't writ

[PATCH master] optee: don't warn about missing OP-TEE header

2024-02-28 Thread Ahmad Fatoum
OP-TEE header is checked once in PBL, saved into scratch area after verification and then checked again in barebox proper. The check in PBL fails silently, but the check in barebox proper that should always follow, because the header isn't written to the scratch area is printed with error log leve