Re: [PATCH master v2 1/2] hab: habv4: use explicitly unsigned types for pointers into SRAM

2024-01-11 Thread Sascha Hauer
On Thu, 11 Jan 2024 14:00:14 +0100, Ahmad Fatoum wrote: > char is generally unsigned on ARM, but we shouldn't rely on that. HAB > code does though and compare a char against 0xdb, which would never > succeed if chars were signed. Switch to an explicitly unsigned type to > fix this. > >

[PATCH master v2 1/2] hab: habv4: use explicitly unsigned types for pointers into SRAM

2024-01-11 Thread Ahmad Fatoum
char is generally unsigned on ARM, but we shouldn't rely on that. HAB code does though and compare a char against 0xdb, which would never succeed if chars were signed. Switch to an explicitly unsigned type to fix this. Signed-off-by: Ahmad Fatoum --- v1 -> v2: - no change ---