Re: [PATCH v2 1/2] usb: gadget: dfu: Rework print messages

2021-02-16 Thread Jules Maselbas
Hi Sascha, On Tue, Feb 16, 2021 at 10:27:29AM +0100, Sascha Hauer wrote: > > > @@ -209,7 +210,7 @@ dfu_bind(struct usb_configuration *c, struct > > > usb_function *f) > > > dfu->dnreq = usb_ep_alloc_request(c->cdev->gadget->ep0); > > > if (!dfu->dnreq) { > > > - printf

Re: [PATCH v2 1/2] usb: gadget: dfu: Rework print messages

2021-02-16 Thread Jules Maselbas
Hi Bartek, On Tue, Feb 16, 2021 at 10:19:00AM +0100, Bartosz Bilas wrote: > > @@ -209,7 +210,7 @@ dfu_bind(struct usb_configuration *c, struct > > usb_function *f) > > dfu->dnreq = usb_ep_alloc_request(c->cdev->gadget->ep0); > > if (!dfu->dnreq) { > > - printf("usb_ep_alloc_requ

Re: [PATCH v2 1/2] usb: gadget: dfu: Rework print messages

2021-02-16 Thread Sascha Hauer
On Tue, Feb 16, 2021 at 10:19:00AM +0100, Bartosz Bilas wrote: > Hello Jules, > > On 15.02.2021 15:18, Jules Maselbas wrote: > > Replace printf with pr_err and debug with pr_debug. > > Defines "dfu :" as a prefix for formatted prints. > > > > --- > > v1 -> v2: > > - add `pr_fmt(fmt) "dfu: " fmt

Re: [PATCH v2 1/2] usb: gadget: dfu: Rework print messages

2021-02-16 Thread Bartosz Bilas
Hello Jules, On 15.02.2021 15:18, Jules Maselbas wrote: Replace printf with pr_err and debug with pr_debug. Defines "dfu :" as a prefix for formatted prints. --- v1 -> v2: - add `pr_fmt(fmt) "dfu: " fmt` - change debug call to pr_debug - remove "dfu: " in print messages Signed-off-by: Ju

[PATCH v2 1/2] usb: gadget: dfu: Rework print messages

2021-02-15 Thread Jules Maselbas
Replace printf with pr_err and debug with pr_debug. Defines "dfu :" as a prefix for formatted prints. --- v1 -> v2: - add `pr_fmt(fmt) "dfu: " fmt` - change debug call to pr_debug - remove "dfu: " in print messages Signed-off-by: Jules Maselbas --- drivers/usb/gadget/dfu.c | 11 ++-