Re: [PATCH v2 2/2] habv4: use hab rom implementation of report_event

2024-01-16 Thread Stefan Kerkmann
Hello Ahmad, Hello Sascha, On 17.01.24 08:20, Sascha Hauer wrote: On Tue, Jan 16, 2024 at 09:13:48AM +0100, Ahmad Fatoum wrote: Hello Stefan, On 12.01.24 16:21, Stefan Kerkmann wrote: +static enum hab_status hab_sip_report_event(enum hab_status status, +

Re: [PATCH v2 2/2] habv4: use hab rom implementation of report_event

2024-01-16 Thread Sascha Hauer
On Tue, Jan 16, 2024 at 09:13:48AM +0100, Ahmad Fatoum wrote: > Hello Stefan, > > On 12.01.24 16:21, Stefan Kerkmann wrote: > > +static enum hab_status hab_sip_report_event(enum hab_status status, > > + uint32_t index, uint8_t *event, > > +

Re: [PATCH v2 2/2] habv4: use hab rom implementation of report_event

2024-01-16 Thread Ahmad Fatoum
Hello Stefan, On 12.01.24 16:21, Stefan Kerkmann wrote: > +static enum hab_status hab_sip_report_event(enum hab_status status, > + uint32_t index, uint8_t *event, > + size_t *bytes) > +{ > + struct arm_smccc_res re

Re: [PATCH v2 2/2] habv4: use hab rom implementation of report_event

2024-01-15 Thread Sascha Hauer
On Fri, Jan 12, 2024 at 05:29:58PM +0100, Stefan Kerkmann wrote: > On 12.01.24 16:21, Stefan Kerkmann wrote: > > The existing habv4 rom vector table had some mismatches in the API of > > the function pointers which broke calling into the HAB rom - mainly > > observed with the `report_event` functio

Re: [PATCH v2 2/2] habv4: use hab rom implementation of report_event

2024-01-12 Thread Stefan Kerkmann
On 12.01.24 16:21, Stefan Kerkmann wrote: The existing habv4 rom vector table had some mismatches in the API of the function pointers which broke calling into the HAB rom - mainly observed with the `report_event` function. The suspected culprit here is the `bytes` pointer which was `uint32_t*` vs

[PATCH v2 2/2] habv4: use hab rom implementation of report_event

2024-01-12 Thread Stefan Kerkmann
The existing habv4 rom vector table had some mismatches in the API of the function pointers which broke calling into the HAB rom - mainly observed with the `report_event` function. The suspected culprit here is the `bytes` pointer which was `uint32_t*` vs. the documented `size_t*`. When compiled u