Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-11-02 Thread Alexander Shiyan
On Fri, 2 Nov 2012 09:54:12 +0100 Sascha Hauer wrote: ... > > > Two last things: > > > > > > You should add pbl-y += lowlevel.o to your board Makefile. This allows > > > it to compile barebox as a compressed image. > > > > > > You shouldn't have to overwrite env/bin/mtdparts-add. Instead this >

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-11-02 Thread Sascha Hauer
On Fri, Nov 02, 2012 at 12:44:43PM +0400, Alexander Shiyan wrote: > On Fri, 2 Nov 2012 09:21:13 +0100 > Sascha Hauer wrote: > > ... > > > Well, if there are no more comments for this series, I will create a v4 > > > with > > > one more forgotten fix for serial driver (IS_ERR clock check). > > >

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-11-02 Thread Alexander Shiyan
On Fri, 2 Nov 2012 09:21:13 +0100 Sascha Hauer wrote: ... > > Well, if there are no more comments for this series, I will create a v4 with > > one more forgotten fix for serial driver (IS_ERR clock check). > > Fine, thanks. This should be the final one. > > Two last things: > > You should add

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-11-02 Thread Sascha Hauer
On Fri, Nov 02, 2012 at 10:24:19AM +0400, Alexander Shiyan wrote: > On Thu, 1 Nov 2012 08:32:51 +0100 > Sascha Hauer wrote: > > > On Thu, Nov 01, 2012 at 09:20:38AM +0400, Alexander Shiyan wrote: > > > On Wed, 31 Oct 2012 22:36:08 +0100 > > > Sascha Hauer wrote: > > > > > > ... > > > > > + > >

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-11-01 Thread Alexander Shiyan
On Thu, 1 Nov 2012 08:32:51 +0100 Sascha Hauer wrote: > On Thu, Nov 01, 2012 at 09:20:38AM +0400, Alexander Shiyan wrote: > > On Wed, 31 Oct 2012 22:36:08 +0100 > > Sascha Hauer wrote: > > > > ... > > > > + > > > > + asm("mov pc, #0"); > > > > > > Or is it because you do not have a real

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-11-01 Thread Sascha Hauer
On Thu, Nov 01, 2012 at 09:20:38AM +0400, Alexander Shiyan wrote: > On Wed, 31 Oct 2012 22:36:08 +0100 > Sascha Hauer wrote: > > ... > > > + > > > + asm("mov pc, #0"); > > > > Or is it because you do not have a real reset function and have to jump > > through zero instead? Still common_reset() s

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-10-31 Thread Alexander Shiyan
On Wed, 31 Oct 2012 22:36:08 +0100 Sascha Hauer wrote: ... > > + > > + asm("mov pc, #0"); > > Or is it because you do not have a real reset function and have to jump > through zero instead? Still common_reset() shouldn't be necessary. What Yes. > you may have to do here is to make sure the MMU

Re: [PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-10-31 Thread Sascha Hauer
On Tue, Oct 30, 2012 at 08:08:30PM +0400, Alexander Shiyan wrote: > This patch adds new architecture (CLPS711X) into barebox. > The core-logic functionality of the device is built around an ARM720T > processor running at clock speeds up to 90 MHz. > [...] > +++ b/arch/arm/mach-clps711x/reset.c >

[PATCH v3 1/3] ARM: Add CLPS711X architecture

2012-10-30 Thread Alexander Shiyan
This patch adds new architecture (CLPS711X) into barebox. The core-logic functionality of the device is built around an ARM720T processor running at clock speeds up to 90 MHz. Signed-off-by: Alexander Shiyan --- arch/arm/Kconfig |6 + arch/arm/Makefile