Re: [PATCH 047/112] string: reduce strjoin runtime, drop trailing separator

2024-01-07 Thread Sascha Hauer
On Mon, Jan 08, 2024 at 08:18:46AM +0100, Ahmad Fatoum wrote: > On 08.01.24 08:11, Sascha Hauer wrote: > > On Wed, Jan 03, 2024 at 07:12:07PM +0100, Ahmad Fatoum wrote: > >> The implementation of strjoin is a bit suboptimal. The destination > >> string is traversed from the beginning due to strcat

Re: [PATCH 047/112] string: reduce strjoin runtime, drop trailing separator

2024-01-07 Thread Ahmad Fatoum
On 08.01.24 08:11, Sascha Hauer wrote: > On Wed, Jan 03, 2024 at 07:12:07PM +0100, Ahmad Fatoum wrote: >> The implementation of strjoin is a bit suboptimal. The destination >> string is traversed from the beginning due to strcat and we have a >> left-over separator at the end, while it should only

Re: [PATCH 047/112] string: reduce strjoin runtime, drop trailing separator

2024-01-07 Thread Sascha Hauer
On Wed, Jan 03, 2024 at 07:12:07PM +0100, Ahmad Fatoum wrote: > The implementation of strjoin is a bit suboptimal. The destination > string is traversed from the beginning due to strcat and we have a > left-over separator at the end, while it should only be in-between. > > Fix this. > >