Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-27 Thread Alexander Aring
On Thu, Jun 26, 2014 at 10:42:32PM +0200, Sascha Hauer wrote: On Thu, Jun 26, 2014 at 10:49:15AM +0200, Holger Schurig wrote: ... and it's defined only when CONFIG_OFTREE_MEM_GENERIC is on. Signed-off-by: Holger Schurig holgerschu...@gmail.com --- drivers/of/base.c |6 ++ 1

Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-26 Thread Alexander Aring
Hi Holger, can you please check if this is also a solution for this? diff --git a/include/of.h b/include/of.h index e6993fd..76845e7 100644 --- a/include/of.h +++ b/include/of.h @@ -227,7 +227,14 @@ int of_parse_partitions(struct cdev *cdev, struct device_node *node); int

Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-26 Thread Alexander Aring
On Thu, Jun 26, 2014 at 11:37:01AM +0200, Alexander Aring wrote: Hi Holger, can you please check if this is also a solution for this? diff --git a/include/of.h b/include/of.h index e6993fd..76845e7 100644 --- a/include/of.h +++ b/include/of.h @@ -227,7 +227,14 @@ int

Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-26 Thread Holger Schurig
Your patch alone isn't all that's needed, the definition must still be uncommented. Otherwise we'll get: drivers/of/base.c:1700:5: error: redefinition of 'of_add_memory' include/of.h:233:50: note: previous definition of 'of_add_memory' was here ___

Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-26 Thread Alexander Aring
On Thu, Jun 26, 2014 at 11:37:01AM +0200, Alexander Aring wrote: Hi Holger, can you please check if this is also a solution for this? diff --git a/include/of.h b/include/of.h index e6993fd..76845e7 100644 --- a/include/of.h +++ b/include/of.h @@ -227,7 +227,14 @@ int

Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-26 Thread Alexander Aring
On Thu, Jun 26, 2014 at 11:43:10AM +0200, Holger Schurig wrote: Your patch alone isn't all that's needed, the definition must still be uncommented. Otherwise we'll get: drivers/of/base.c:1700:5: error: redefinition of 'of_add_memory' include/of.h:233:50: note: previous definition of

Re: [PATCH 2/4] sandbox: only access of_add_memory_bank if it's defined

2014-06-26 Thread Sascha Hauer
On Thu, Jun 26, 2014 at 10:49:15AM +0200, Holger Schurig wrote: ... and it's defined only when CONFIG_OFTREE_MEM_GENERIC is on. Signed-off-by: Holger Schurig holgerschu...@gmail.com --- drivers/of/base.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/of/base.c