Re: memcmp command is broken

2019-07-08 Thread Andrey Smirnov
On Thu, Jul 4, 2019 at 9:56 AM Peter Mamonov wrote: > > Hi, Andrey, > > Current `memcmp` command implementation is broken and fails with the error > message "read: Bad file number" when calls `read_full(destfd, ...)`. Guess > this > is because `memcpy_parse_options()` opens `destfd` with `O_WRONL

memcmp command is broken

2019-07-04 Thread Peter Mamonov
Hi, Andrey, Current `memcmp` command implementation is broken and fails with the error message "read: Bad file number" when calls `read_full(destfd, ...)`. Guess this is because `memcpy_parse_options()` opens `destfd` with `O_WRONLY` flag. Anyway reverting "ddf4cca339 commands: Introduce memcpy