Re: [BBDB] ChangLog 2011-04-16

2011-04-16 Thread David Engster
Roland Winkler writes: > I extended (and fixed) this patch to inherit from special-mode. > Now bbdb-mode is also derived from special-mode. Note that Emacs v22 doesn't have special-mode, so this change will make it break on that version (or earlier, of course). -David --

Re: [BBDB] ChangLog 2011-04-16 (addendum)

2011-04-16 Thread Roland Winkler
Two many changes today. I lost track! 2011-04-16 Roland Winkler * lisp/bbdb.el (bbdb-create-hook, bbdb-change-hook): Use defvar. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidatio

Re: [BBDB] Changelog 2010-04-10

2011-04-16 Thread Roland Winkler
On Sun Apr 17 2011 Nix wrote: > We could do the same job with a new hook which is called only once per > record, no matter how many times it is spotted by a given call to > bbdb-update-records, or with a new guarantee that the bbdb-notice-hook > would only fire once per record per call to bbdb-upda

Re: [BBDB] Changelog 2010-04-10

2011-04-16 Thread Nix
On 17 Apr 2011, Roland Winkler stated: > On Sun Apr 17 2011 Nix wrote: >> >> (I'll also see if bbdb-expire works with v3.0x and make it work if >> >> it doesn't.) >> > >> > I believe this was some kind of add-on for BBDB. >> >> It was, making heavy use of advisements to do its job. If it isn't >>

Re: [BBDB] Changelog 2010-04-10

2011-04-16 Thread Roland Winkler
On Sun Apr 17 2011 Nix wrote: > >> (I'll also see if bbdb-expire works with v3.0x and make it work if > >> it doesn't.) > > > > I believe this was some kind of add-on for BBDB. > > It was, making heavy use of advisements to do its job. If it isn't > broken I'd be astonished. :) If possible, I'd l

[BBDB] builtbot (was: bbdb-mode-map should inherit from special-mode-map)

2011-04-16 Thread Roland Winkler
On Thu Apr 14 2011 David Engster wrote: > I shortly tested compilation, and it works more or less fine for GNU > Emacs22 to the latest GNU emacs-snapshot. > > XEmacs is another matter, though. I attached the current logs for XEmacs > 21.4 and 21.5. Note that your 'PUSHPATH' eval doesn't work for X

Re: [BBDB] Changelog 2010-04-10

2011-04-16 Thread Nix
On 17 Apr 2011, Roland Winkler told this: > On Mon Apr 11 2011 Nix wrote: >> (I'll also see if bbdb-expire works with v3.0x and make it work if >> it doesn't.) > > I believe this was some kind of add-on for BBDB. It was, making heavy use of advisements to do its job. If it isn't broken I'd be ast

Re: [BBDB] Changelog 2010-04-10

2011-04-16 Thread Roland Winkler
On Mon Apr 11 2011 Nix wrote: > On 11 Apr 2011, Roland Winkler told this: > > - Finally, I fixed various bugs and improved the documentation. > > I just noticed that BBDB development has restarted. Unfortunately > BBDB 3.0 has removed a good few features, including one I definitely > rely on: bbdb

Re: Non-nil default value in hook variables

2011-04-16 Thread Roland Winkler
On Fri Apr 15 2011 Leo wrote: > When people use add-hook they think they are adding another function to > a hook so if this isn't the case it will surprise them. People who are > setting hook to nil is in a different thinking. There are add-hook and remove-hook. The latter fails (now) if you want

Re: Replace bbdb-defstruct with defstruct?

2011-04-16 Thread Roland Winkler
On Fri Apr 15 2011 Leo wrote: > I wonder if it makes sense to replace bbdb-defstruct with defstruct? What benefit(s) would you expect from that? I guess that bbdb-defstruct is about as efficient and effective as possible for the needs of BBDB. Roland

Re: Is the feature to add/update record when sending emails useful?

2011-04-16 Thread Roland Winkler
On Fri Apr 15 2011 Leo wrote: > I personally haven't used this much in Emacs. But since gmail does this > and I have found it useful at times, I wonder if this feature should be > part of the bbdb-mua feature set. I am sorry, it's not clear to me what you want to say here. The new BBDB treats outg

[BBDB] Contributing to the new BBDB

2011-04-16 Thread Roland Winkler
Several people on this list have started to contribute to the new BBDB in one or the other way. I am quite happy to see that! I'd like to outline my view / strategy for that: I'd be happy to see a proper release of the new BBDB in the not to far future. To make BBDB really free software, I'd be

[BBDB] ChangLog 2011-04-16

2011-04-16 Thread Roland Winkler
I tried to incoprorate a bunch of smaller issues that came up on this list the past couple of days. Thanks to everyone who contributed to this in one or the other way. On Wed Apr 13 2011 Sam Steingold wrote: > if you do not care about obsolete emacsen, please apply this instead. I extended (and

Add timezone in bbdb-time-stamp-format

2011-04-16 Thread Leo
I propose the following change that includes the timezone info so that 3rd library does not need to know the time is actually UTC. diff --git a/lisp/bbdb.el b/lisp/bbdb.el index d2c72fb9..89e890c3 100644 --- a/lisp/bbdb.el +++ b/lisp/bbdb.el @@ -222,7 +222,7 @@ (defcustom bbdb-change-hook 'bbdb-t