On Mon Sep 10 2012 Leo wrote:
> On 2012-09-10 12:21 +0800, Roland Winkler wrote:
> > Is this all?? Let's see what pops up next...
>
> There is one buglet that is pretty annoying i.e. after
> bbdb-transpose-fields point is moved to the beginning of the record. I
> think it should stay in the same field of the record before and after
> the transposition.
I agree that this is annoying. The culprit is the function
bbdb-redisplay-record. When it redisplays a record after whatever
modification, it puts point at the beginning of the record. It would
be better if it restored point as close as possible to where it was
before the alteration of the record.
Currently I do not have a good (robust) idea how to fix this. It is
on my to-do list. Yet I do not give this the highest priority. But
patches are welcome.
> I have these commits sitting in my local git repo and I think they might
> be good for upstream so I am posting them here.
> +(run-hooks 'bbdb-load-hook)
Please use `eval-after-load'. This implements "load hooks" for any
emacs package.
> (defmacro bbdb-mua-wrapper (&rest body)
> "Perform BODY in a MUA buffer."
> + (declare (debug t))
Thanks, done.
> @@ -574,9 +574,11 @@ (defun bbdb-insinuate-gnus ()
> ;; `gnus-article-read-summary-keys' provides an additional wrapper
> ;; that restores the window configuration.
> (define-key gnus-summary-mode-map ":" 'bbdb-mua-display-sender)
> + (define-key gnus-article-mode-map ":" 'bbdb-mua-display-sender)
> ;; For `bbdb-mua-edit-field-sender' it is probably OK if
> ;;`gnus-article-read-summary-keys' restores the window configuration.
> (define-key gnus-summary-mode-map ";" 'bbdb-mua-edit-field-sender)
> + (define-key gnus-article-mode-map ";" 'bbdb-mua-edit-field-sender)
Thanks, done.
> (defun bbdb-grab-url (record url)
> "Grab URL and store it in RECORD."
> - (interactive (list (bbdb-completing-read-record "Add URL for: ")
> - (browse-url-url-at-point)))
> + (interactive (let ((url (or (browse-url-url-at-point)
> + (error "No url at point"))))
> + (list (bbdb-completing-read-record
> + (format "Add %s for: " url)) url)))
Thanks, done.
2012-12-27 Roland Winkler <wink...@gnu.org>
* lisp/bbdb-mua.el (bbdb-mua-wrapper): Add edebug support.
Suggested by Leo <sdl....@gmail.com>.
* lisp/bbdb-gnus (bbdb-insinuate-gnus): Fix keybindings for
gnus-article-mode. Suggested by Leo <sdl....@gmail.com>.
* lisp/bbdb-com.el (bbdb-grab-url): Fail early if no URL at point.
Suggested by Leo <sdl....@gmail.com>.
BBDB is available at
http://savannah.nongnu.org/projects/bbdb/
To check it out, use
git clone git://git.savannah.nongnu.org/bbdb.git
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
