I found a bug: Using (first . last) name arg to bbdb-create-internal fails.
An example of the error::
(error "type mismatch: expect (or nil (cons string string)), got `(Bob .
Dole)'")
The code for checking type '(or ... ) is conditioned that each element
is not nill, so it immediately fails it's check.
With this patch applied, I've tested that bbdb-create-internal still
works with a name "string", nil and now works with ("first" . "last").
- Ian Kelling
>From c5157a5ba673fcca7185100e494f58c35db4a72f Mon Sep 17 00:00:00 2001
From: Ian Kelling <i...@iankelling.org>
Date: Tue, 8 Apr 2014 09:31:29 -0700
Subject: [PATCH 2/2] fix bug: Using (first . last) name arg to
bbdb-create-internal fails.
---
lisp/bbdb-com.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/bbdb-com.el b/lisp/bbdb-com.el
index ddaafdb..ca080d6 100644
--- a/lisp/bbdb-com.el
+++ b/lisp/bbdb-com.el
@@ -750,7 +750,7 @@ If CHECK is non-nil throw an error if an argument is not syntactically correct."
;; name
(cond ((stringp name)
(setq name (bbdb-divide-name name)))
- (check (bbdb-check-type name '(or nil (cons string string)) t)))
+ (check (bbdb-check-type name '(cons string string) t)))
(let ((firstname (car name))
(lastname (cdr name))
(record-type (cdr bbdb-record-type)))
--
1.7.10.4
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
