[PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Michael Buesch
This masks the PHY TX error interrupt, if debugging is disabled. Currently we have a bug somewhere which triggers this interrupt once in a while. (Depends on the network noise/quality). While this is nonfatal, it scares the hell out of users and we frequently receive bugreports that incorrectly

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Michael Buesch
On Thursday 19 March 2009 19:27:21 Michael Buesch wrote: This patch adds a workaround for the issue by just enabling the interrupt if debugging is disabled (by Kconfig or by modparam). Of course I meant just disabling the interrupt -- Greetings, Michael.

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Francesco Gringoli
On Mar 19, 2009, at 7:27 PM, Michael Buesch wrote: This masks the PHY TX error interrupt, if debugging is disabled. Currently we have a bug somewhere which triggers this interrupt once in a while. (Depends on the network noise/quality). While this is nonfatal, Michael, some time ago I

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Michael Buesch
On Thursday 19 March 2009 20:00:45 Francesco Gringoli wrote: some time ago I begin seeing several of these errors, never seen before on one of my host, with both proprietary and open firmwares. As I never noticed those errors before, I wondered if they could be due to some strange frame

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Francesco Gringoli
On Mar 19, 2009, at 8:13 PM, Michael Buesch wrote: On Thursday 19 March 2009 20:00:45 Francesco Gringoli wrote: Yeah well. This confirms my thoughts. There are other ways to voluntarily trigger the errors. For example try covering the antennae with your bare hands. Try to move the device

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Michael Buesch
On Thursday 19 March 2009 20:56:52 Francesco Gringoli wrote: I would agree with you, but there is this bizarre issue with PHY errors in monitoring mode that makes me thinking about what we call PHY errors. I would say they are not only due to transmission, they are general PHY errors,

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Francesco Gringoli
On Mar 19, 2009, at 9:10 PM, Michael Buesch wrote: On Thursday 19 March 2009 20:56:52 Francesco Gringoli wrote: I would agree with you, but there is this bizarre issue with PHY errors in monitoring mode that makes me thinking about what we call PHY errors. I would say they are not only due

Re: [PATCH] b43: Mask PHY TX error interrupt, if not debugging

2009-03-19 Thread Larry Finger
Michael Buesch wrote: The problem is that the code basically is undocumented and we only write blob values to the registers. So from reading the code you won't even know where these values are written. But the specs give some useful hints. ;) I might be able to help with the last part. Not