[PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Lorenzo Nava
This patch fixes the return type of b43_plcp_get_bitrate_idx_ofdm. If the plcp contains an error, the function return value is 255 instead of -1, and the packet was not dropped. This causes a warning in __ieee80211_rx function because rate idx is out of range. Index: wireless-testing/driver

Re: [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Michael Buesch
On Sunday 22 March 2009 17:32:35 Lorenzo Nava wrote: > This patch fixes the return type of b43_plcp_get_bitrate_idx_ofdm. If > the plcp contains an error, the function return value is 255 instead > of -1, and the packet was not dropped. This causes a warning in > __ieee80211_rx function becau

Re: [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Lorenzo Nava
Hi Michael, what do you mean with "non-mangled" version? I also noticed that most of the plcp rate errors seem due to an incorrect padding value passed by the firmware. The plcp looks correct but improperly shifted. Any ideas about that? cheers Lorenzo. On Mar 22, 2009, at 5:34 PM, Michael

Re: [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Michael Buesch
On Sunday 22 March 2009 17:45:58 Lorenzo Nava wrote: > Hi Michael, > > what do you mean with "non-mangled" version? The patch is line wrapped. Fix your email client settings. > I also noticed that most of the plcp rate errors seem due to an > incorrect padding value passed by the firmware. The

[PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Lorenzo Nava
I hope it is ok. Reported-by: Lorenzo Nava Signed-off-by: Lorenzo Nava Index: wireless-testing/drivers/net/wireless/b43/xmit.c === --- wireless-testing.orig/drivers/net/wireless/b43/xmit.c 2009-03-22 17:25:19.0 +0100

Re: [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Michael Buesch
On Sunday 22 March 2009 18:07:28 Lorenzo Nava wrote: > I hope it is ok. > > Reported-by: Lorenzo Nava > Signed-off-by: Lorenzo Nava > > Index: wireless-testing/drivers/net/wireless/b43/xmit.c > === > --- wireless-testing.orig/driver

[PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Lorenzo Nava
Once again... Reported-by: Lorenzo Nava Signed-off-by: Lorenzo Nava Index: wireless-testing/drivers/net/wireless/b43/xmit.c === --- wireless-testing.orig/drivers/net/wireless/b43/xmit.c 2009-03-22 17:25:19.0 +0100 +++ wirele

Re: [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Michael Buesch
On Sunday 22 March 2009 19:00:38 Lorenzo Nava wrote: > Once again... The patch still is whitespace damaged. m...@homer:~/develop/git/wireless-testing$ patch -p1 --dry-run Reported-by: Lorenzo Nava > Signed-off-by: Lorenzo Nava > > Index: wireless-testing/drivers/net/wireless/b43/xmit.c > =

[PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Michael Buesch
From: Lorenzo Nava This patch fixes the return type of b43_plcp_get_bitrate_idx_ofdm. If the plcp contains an error, the function return value is 255 instead of -1, and the packet was not dropped. This causes a warning in __ieee80211_rx function because rate idx is out of range. Cc: sta...

Re: [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type

2009-03-22 Thread Larry Finger
Lorenzo Nava wrote: > Once again... > > Reported-by: Lorenzo Nava > Signed-off-by: Lorenzo Nava Cc: Stable [2.6.28, 2.6.27] Sorry to join this party late, but the line above should be added as this bug goes back at least to 2.6.27 and should be applied to stable. I didn't check any further.

Re: [PATCH 1/1] ath5k: fix hw rate index condition

2009-03-22 Thread Stefan Lippers-Hollmann
Hi On Sonntag, 15. März 2009, Stefan Lippers-Hollmann wrote: > Hi > > On Mittwoch, 7. Januar 2009, Jiri Slaby wrote: > > On 01/07/2009 02:51 PM, Jiri Slaby wrote: > > > Dhaval Giani wrote: > > >> I see this on current git. Not sure how to reproduce it, has happened on > > >> two random occasions.

Re: I need some help stabalizing b43 for a 4306

2009-03-22 Thread mtcstle
Well, after raging at the wind for three weeks, I've taken your advice., found a mini-PCI Intel Pro Wireless 2200, and popped it in, in place of the BCM4306. Once I found out where to find the firmware, I was in business Thanks for the help, you guys. John --Original Message-- From: