Re: [PATCH 2/6] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-11 Thread Michael Buesch
On Monday 11 January 2010 03:38:53 Larry Finger wrote: > Yes, my fault. The specs are now corrected so that these statements are > > ((s8)((s[1] >> 8) & 0x3F) << 2) >> 2 > > I think that is right. No it is not. You need to do this: (s8)(((s[1] >> 8) & 0x3F) << 2) >> 2 Alternatively add another

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Rafał Miłecki
2010/1/10 Michael Buesch : > On Sunday 10 January 2010 23:13:34 Rafał Miłecki wrote: >> +     s32 results_min[4]; >> +     u8 vcm_final[4]; >> +     s32 results[4][4]; >> +     s32 miniq[4][2]; >> +     memset(results_min, 0, sizeof(s32) * 4); >> +     memset(vcm_final, 0, sizeof(u8) * 4); >> +    

[PATCH 2/6 V2] b43: N-PHY: add RSSI functions: poll and set 2055 vcm

2010-01-11 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/net/wireless/b43/phy_n.c | 96 ++ 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c index a44fca1..214cf54 100644 --- a/drivers/net/wi

[PATCH 3/6 V2] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki http://bcm-v4.sipsolutions.net/802.11/PHY/N/RSSICal */ static void b43_nphy_rev2_rssi_cal(struct b43_wldev *dev, u8 type) { - //TODO + int i, j; + u8 state[4]; + u8 code, val; + u16 class, override; + u8 regs_save_radio[2]; +

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Michael Buesch
On Monday 11 January 2010 22:13:31 Rafał Miłecki wrote: > 2010/1/10 Michael Buesch : > > On Sunday 10 January 2010 23:13:34 Rafał Miłecki wrote: > >> +     s32 results_min[4]; > >> +     u8 vcm_final[4]; > >> +     s32 results[4][4]; > >> +     s32 miniq[4][2]; > >> +     memset(results_min, 0, siz

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Johannes Berg
On Mon, 2010-01-11 at 23:13 +0100, Michael Buesch wrote: > No I don't think so. > It's C standard that uninitialized elements on automatic variables are > initialized > to zero, _if_ at least one element is initialized to something. > So if you init one element to 0, all others will be 0, too. AF

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Michael Buesch
On Monday 11 January 2010 23:19:52 Johannes Berg wrote: > On Mon, 2010-01-11 at 23:13 +0100, Michael Buesch wrote: > > > No I don't think so. > > It's C standard that uninitialized elements on automatic variables are > > initialized > > to zero, _if_ at least one element is initialized to somethin

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Rafał Miłecki
W dniu 11 stycznia 2010 23:13 użytkownik Michael Buesch napisał: > On Monday 11 January 2010 22:13:31 Rafał Miłecki wrote: >> 2010/1/10 Michael Buesch : >> > On Sunday 10 January 2010 23:13:34 Rafał Miłecki wrote: >> >> +     s32 results_min[4]; >> >> +     u8 vcm_final[4]; >> >> +     s32 result

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Michael Buesch
On Monday 11 January 2010 23:27:18 Rafał Miłecki wrote: > Whoops, I should have explained what I mean. I am not sure what CFLAGS > "make" picks for compiled but I get: > > CC [M] drivers/net/wireless/b43/phy_n.o > drivers/net/wireless/b43/phy_n.c: In function ‘b43_nphy_rev2_rssi_cal’: > drivers

Re: [PATCH 3/6] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Rafał Miłecki
W dniu 11 stycznia 2010 23:42 użytkownik Michael Buesch napisał: > On Monday 11 January 2010 23:27:18 Rafał Miłecki wrote: >> Whoops, I should have explained what I mean. I am not sure what CFLAGS >> "make" picks for compiled but I get: >> >>   CC [M]  drivers/net/wireless/b43/phy_n.o >> drivers/

[PATCH 3/6 V3] b43: N-PHY: add RSSI calculation for PHY rev < 3

2010-01-11 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki http://bcm-v4.sipsolutions.net/802.11/PHY/N/RSSICal */ static void b43_nphy_rev2_rssi_cal(struct b43_wldev *dev, u8 type) { - //TODO + int i, j; + u8 state[4]; + u8 code, val; + u16 class, override; + u8 regs_save_radio[2]; +