Re: [PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-20 Thread Michael Buesch
On Friday 20 November 2009 00:55:07 Larry Finger wrote: On 11/18/2009 11:21 PM, William Bourque wrote: Also, just saying, but it seems Larry's pm_qos_update_requirement patch had some good effects; I can hardly get any connectivity without it. With the patch, the wireless seems to be

Re: [PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-20 Thread Larry Finger
On 11/20/2009 03:29 AM, Michael Buesch wrote: On Friday 20 November 2009 00:55:07 Larry Finger wrote: If the pm_qos patch has some positive benefits, I'll push it; however, I think this is just a band aid, not a real fix. It also has the bad side effect of keeping the CPU from going into

Re: [PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-20 Thread John W. Linville
On Thu, Nov 19, 2009 at 05:55:07PM -0600, Larry Finger wrote: On 11/18/2009 11:21 PM, William Bourque wrote: Also, just saying, but it seems Larry's pm_qos_update_requirement patch had some good effects; I can hardly get any connectivity without it. With the patch, the wireless seems to

Re: [PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-19 Thread Michael Buesch
On Thursday 19 November 2009 06:21:45 William Bourque wrote: Michael Buesch wrote: Enforce all device constraints on the descriptor memory region. There are several constraints on the descriptor memory, as documented in the specification. The current code does not enforce them and/or

Re: [PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-19 Thread Larry Finger
On 11/18/2009 11:21 PM, William Bourque wrote: Also, just saying, but it seems Larry's pm_qos_update_requirement patch had some good effects; I can hardly get any connectivity without it. With the patch, the wireless seems to be stable for a few minutes before generating DMA errors...

[PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-18 Thread Michael Buesch
Enforce all device constraints on the descriptor memory region. There are several constraints on the descriptor memory, as documented in the specification. The current code does not enforce them and/or incorrectly enforces them. Those constraints are: - The address limitations on 30/32bit

Re: [PATCH] b43: Enforce DMA descriptor memory constraints

2009-11-18 Thread Larry Finger
On 11/18/2009 01:53 PM, Michael Buesch wrote: Enforce all device constraints on the descriptor memory region. There are several constraints on the descriptor memory, as documented in the specification. The current code does not enforce them and/or incorrectly enforces them. Those