Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-15 Thread David Woodhouse
On Thu, 2007-04-12 at 20:22 -0500, Larry Finger wrote: > Your tester needs to get a copy of David's hack that prints out the address > of the offending > register. That is the only way to tell what is happening. Once we know the > address, then it will be > a matter of getting printk's into the

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-15 Thread David Woodhouse
On Mon, 2007-04-16 at 01:06 +0100, David Woodhouse wrote: > On Fri, 2007-04-13 at 17:17 +0200, Johannes Berg wrote: > > With phy rev == 1, the gmode bit is assumed unset when initialising a > > G PHY. Maybe that is the crucial difference. David will send me some > > backtraces of this problem, once

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-15 Thread David Woodhouse
On Fri, 2007-04-13 at 17:17 +0200, Johannes Berg wrote: > With phy rev == 1, the gmode bit is assumed unset when initialising a > G PHY. Maybe that is the crucial difference. David will send me some > backtraces of this problem, once he does I'll look at it again. http://david.woodhou.se/bcm43xx-m

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-13 Thread Johannes Berg
On Fri, 2007-04-13 at 10:06 -0500, Larry Finger wrote: > I look forward to your rewrite of the setup and init routines. Perhaps they > will even let my 4311 > work with mac80211, but I will be very surprised if the PPC machine check > problem goes away. With phy rev == 1, the gmode bit is assu

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-13 Thread Larry Finger
Stefano Brivio wrote: > On Wed, 11 Apr 2007 11:08:53 -0500 > Larry Finger <[EMAIL PROTECTED]> wrote: > >> On PPC architecture with phy->rev == 1, machine checks occur during >> initialization of the "Extended G PHY registers". This problem was >> also seen on bcm43xx-softmac, and was fixed by cond

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-13 Thread Stefano Brivio
On Wed, 11 Apr 2007 11:08:53 -0500 Larry Finger <[EMAIL PROTECTED]> wrote: > On PPC architecture with phy->rev == 1, machine checks occur during > initialization of the "Extended G PHY registers". This problem was > also seen on bcm43xx-softmac, and was fixed by conditionally skipping > over certa

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-12 Thread Larry Finger
John W. Linville wrote: > On Wed, Apr 11, 2007 at 11:08:53AM -0500, Larry Finger wrote: >> On PPC architecture with phy->rev == 1, machine checks occur during >> initialization of the "Extended G PHY registers". This problem was >> also seen on bcm43xx-softmac, and was fixed by conditionally skippi

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-12 Thread Pavel Roskin
On Thu, 2007-04-12 at 20:09 -0400, John W. Linville wrote: > I added this patch to the Fedora rawhide kernels, but our Fedora QA > lead reports that he still has this crash: > > http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233011 > > I had diagnosed this to be the same crash as this

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-12 Thread John W. Linville
On Wed, Apr 11, 2007 at 11:08:53AM -0500, Larry Finger wrote: > On PPC architecture with phy->rev == 1, machine checks occur during > initialization of the "Extended G PHY registers". This problem was > also seen on bcm43xx-softmac, and was fixed by conditionally skipping > over certain reads/write

Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-11 Thread Michael Buesch
On Wednesday 11 April 2007 18:08, Larry Finger wrote: > On PPC architecture with phy->rev == 1, machine checks occur during > initialization of the "Extended G PHY registers". This problem was > also seen on bcm43xx-softmac, and was fixed by conditionally skipping > over certain reads/writes of the

[PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs

2007-04-11 Thread Larry Finger
On PPC architecture with phy->rev == 1, machine checks occur during initialization of the "Extended G PHY registers". This problem was also seen on bcm43xx-softmac, and was fixed by conditionally skipping over certain reads/writes of these registers. The same solution has been applied here with te