Re: [PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
On Thursday 01 May 2008 19:27:35 Jesse Barnes wrote: > On Thursday, May 01, 2008 10:16 am Michael Buesch wrote: > > > So it makes sense to > > > just update the current code to fallback, and update drivers wanting > > > specific mask values to check afterwards. I hate to inflict that kind of > > >

Re: [PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
On Thursday 01 May 2008 19:22:55 Jesse Barnes wrote: > On Thursday, May 01, 2008 10:16 am Michael Buesch wrote: > > Ok, will redo the patches with that added and the name changed. > > > > > Most drivers just do the fallback themselves, right? > > > > Right. > > > > > So it makes sense to > > > just

Re: [PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
On Thursday 01 May 2008 18:30:04 Jesse Barnes wrote: > On Thursday, May 01, 2008 9:07 am Michael Buesch wrote: > > On Thursday 01 May 2008 17:58:26 Christoph Hellwig wrote: > > > On Thu, May 01, 2008 at 05:47:26PM +0200, Michael Buesch wrote: > > > > We've discussed that and this behaviour is not a

Re: [PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
On Thursday 01 May 2008 17:58:26 Christoph Hellwig wrote: > On Thu, May 01, 2008 at 05:47:26PM +0200, Michael Buesch wrote: > > We've discussed that and this behaviour is not acceptable, as the driver > > must know about a possible fallback in case it can do 32bit DMA > > more efficiently than 64bi

Re: [PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
On Thursday 01 May 2008 17:43:58 Christoph Hellwig wrote: > On Thu, May 01, 2008 at 05:42:04PM +0200, Michael Buesch wrote: > > Yeah. because it has to be done in every driver. > > So we put the implementation into a central place, instead of > > reimplementing the wheel over and over again. This w

Re: [PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
On Thursday 01 May 2008 17:36:18 Christoph Hellwig wrote: > On Thu, May 01, 2008 at 04:38:15PM +0200, Michael Buesch wrote: > > This patchset adds API and one user for a "weak" dma_set_mask(). > > Weak means that it will fallback to smaller masks in case the > > DMA subsystem rejects a big mask. >

[PATCH 0/3] Add API for weak DMA masks

2008-05-01 Thread Michael Buesch
This patchset adds API and one user for a "weak" dma_set_mask(). Weak means that it will fallback to smaller masks in case the DMA subsystem rejects a big mask. Currently such rejection may happen if the driver requests a 64bit mask on a VIA machine, for example. dma_set_mask_weak() will fallback t