Re: [RFC] ssb: Add code for SPROM Rev 4

2007-11-05 Thread Michael Buesch
On Saturday 03 November 2007 16:19:46 Larry Finger wrote: The BCM4328 has a revision 4 SPROM. The necessary changes to handle the layout and different size of this revision are implemented. The size of the SPROM is now stored in the ssb_bus struct and used from that location whenever possible.

Re: [RFC] ssb: Add code for SPROM Rev 4

2007-11-05 Thread Larry Finger
Michael Buesch wrote: Larry, I did not forget your patch. But I need to think a little bit more about this. I knew that this one would take some time. The union above is not really what I'd like to have here. In fact, I think to get the v4 sprom implemented the sprom struct has to be

Re: [RFC] ssb: Add code for SPROM Rev 4

2007-11-05 Thread Michael Gerdau
Am Samstag, 3. November 2007 schrieb Larry Finger: The BCM4328 has a revision 4 SPROM. The necessary changes to handle the layout and different size of this revision are implemented. The size of the SPROM is now stored in the ssb_bus struct and used from that location whenever possible. For

Re: [RFC] ssb: Add code for SPROM Rev 4

2007-11-05 Thread Michael Buesch
On Monday 05 November 2007 17:03:47 Larry Finger wrote: u8 path_data0[SPROM_PATH_DATA_SIZE]; u8 path_data1 ... where SPROM_PATH_DATA_SIZE = 0x26. Once we see how the data are used, it may make more sense to have these data be u16, or even a union so that we can have it both

[RFC] ssb: Add code for SPROM Rev 4

2007-11-03 Thread Larry Finger
The BCM4328 has a revision 4 SPROM. The necessary changes to handle the layout and different size of this revision are implemented. The size of the SPROM is now stored in the ssb_bus struct and used from that location whenever possible. For those routines that need the size, but do not have access