Re: Code Review Needed!

2001-07-03 Thread Kevin Hancock
Hi Dave Please do post all feedback to the list so we can all benefit. Thanks Kevin > > I am particularly interested in feedback about: > Any common newbie blunders you may find > Security issues > Specific areas where the code could be more > efficient > A critique on my use of o

Re: Code Review Needed!

2001-06-29 Thread dave hoover
At the suggestion of a few people I've converted the program into text files to make things easier for reviewers. Here are the four files: http://www.redsquirreldesign.com/soapbox/Soapbox.pm.txt http://www.redsquirreldesign.com/soapbox/main.txt http://www.redsquirreldesign.com/soapbox/soap.txt h

Re: Re: Code Review

2001-06-26 Thread Aaron Craig
At 08:42 26.06.2001 -0700, Curtis Poe wrote: > > > > open (IN, "file") || die("Couldn't open file $!"); > > while() > > { > > chomp; > > my @asLines = split(/[\t\s]+/, $_); > > Load_Stat_Rec(\@asLines); > > } > > close IN; > >I'd be a trifle concerned a

Re: Re: Code Review

2001-06-26 Thread Curtis Poe
--- Aaron Craig <[EMAIL PROTECTED]> wrote: > At 14:44 25.06.2001 -0400, Brian Bukeavich wrote: > >Thanks for the input. > >My input data (which is coming out of a flat ascii file) looks similar to: > >Jones, John 35 20 02 05/02/2001 F 060506050705040405047 11 04 01 > >Jones, John

Re: Re: Code Review

2001-06-26 Thread Aaron Craig
At 14:44 25.06.2001 -0400, Brian Bukeavich wrote: >Thanks for the input. >My input data (which is coming out of a flat ascii file) looks similar to: >Jones, John 35 20 02 05/02/2001 F 060506050705040405047 11 04 01 >Jones, John 35 20 02 05/09/2001 F 050604050705040405045 10 1

Re: Re: Code Review

2001-06-25 Thread Brian Bukeavich
%3u", @hole[$q]); printf OF2 (" %3u", @hole[$q]); ? Thanks again. Original Message Follows From: Aaron Craig <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: Re: Re: Code Review Date: Mon, 25 Jun 2001 11:47:34 +0200 At 15:42 22.06.2001 -0400, Brian Bukeavich wr

Re: Re: Code Review

2001-06-25 Thread Aaron Craig
At 15:42 22.06.2001 -0400, Brian Bukeavich wrote: >Sorry, I just thought the text would be too long. > >= >#! /perl/bin/perl first of all, you need to use strict! this is going to cause your program to fail, because you hav

Re: Re: Code Review

2001-06-22 Thread Brian Bukeavich
OF (" ACE : %2u %6.2f BOGEY: %2u %6.2f PLUS 5: %2u %6.2f\n", @over[0], @percent[0], @over[4], @percent[4], @over[8], @percent[8]); printf OF (" EAGLE : %2u %6.2f DOUBLE : %2u %6.2f PLUS 6: %2u %6.2f\n", @over[1], @percent[1], @over[5], @percent[5], @

Re: Re: Code Review

2001-06-22 Thread Mark Bergeron
Just insert your code insode the email itself so we can have a look that way. Mark Bergeron -Original Message- From: "Al Hospers"<[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Date: Fri Jun 22 11:08:23 PDT 2001 Subject: Re: Code Review >PLEASE do N

RE: Code Review

2001-06-22 Thread Al Hospers
PLEASE do NOT send attachments to the list. Al Hospers CamberSoft, Inc. alcambersoftcom http://www.cambersoft.com A famous linguist once said: "There is no language wherein a double positive can form a negative." YEAH, RIGHT

Re: Code Review

2001-06-22 Thread Brian Bukeavich
Original Message Follows From: Aaron Craig <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: Re: Code Review Date: Fri, 22 Jun 2001 17:31:53 +0200 Send it to the list. :) At 11:30 22.06.2001 -0400, Brian Bukeavich wrote: >I'm new to Perl and have written a simple pro

Re: Code Review

2001-06-22 Thread Aaron Craig
Send it to the list. :) At 11:30 22.06.2001 -0400, Brian Bukeavich wrote: >I'm new to Perl and have written a simple program to create 2 statistical >reports for our golf league. I'm looking for someone to review my code >and tell me what can be improved and how. This app was written for the