thanks for your advice of the naming style. I'll stick to it in later patchsets.
Regarding the unit test, it might be a bit hacky to provide such a unit test in
our library, because this new api needs a bo handle name. (i could just create
a new buffer and use it as the stub for bo handle name.)
BTW, please use commit id 81a7569b... to reproduce this bug.
On Thu, Sep 26, 2013 at 04:14:59PM +0800, Zhigang Gong wrote:
> You need to focus on the specific uint64 instruction in
> reg_insn_selection.cpp, and analyze the src/dst register carefully,
>
> Two possible root causes there:
> 1. Wron
Ruiling tell me that llvm3.4 has not been released yet, so we may not switch
to LLVM 3.4 immediately.
But we will switch it eventually. For now, just test it with the llvm 3.4
svn trunk is good enough for us.
And as it will not break llvm 3.3, after the regression test pass, we can
accept this pat
You need to focus on the specific uint64 instruction in
reg_insn_selection.cpp, and analyze the src/dst register carefully,
Two possible root causes there:
1. Wrongly set a register as a source but you will touch it in that
instruction.
2. Incorrectly set the register type, for example, you want
Test pass, the patch LGTM.
-Original Message-
From: beignet-bounces+ruiling.song=intel@lists.freedesktop.org
[mailto:beignet-bounces+ruiling.song=intel@lists.freedesktop.org] On Behalf
Of Homer Hsing
Sent: Monday, September 23, 2013 9:12 AM
To: beignet@lists.freedesktop.org
Subje
Test pass, the patchset looks good to me, thanks.
-Original Message-
From: beignet-bounces+rong.r.yang=intel@lists.freedesktop.org
[mailto:beignet-bounces+rong.r.yang=intel@lists.freedesktop.org] On Behalf
Of Zhigang Gong
Sent: Wednesday, September 25, 2013 7:13 PM
To: beignet@li
