Re: [Beignet] [PATCH] GBE: improve asin/acos precision

2013-12-04 Thread Zhigang Gong
Tested OK. Pushed, thanks. On Thu, Dec 05, 2013 at 02:21:19AM +, Song, Ruiling wrote: > Ping for review. Thanks > > -Original Message- > From: Song, Ruiling > Sent: Friday, November 29, 2013 4:04 PM > To: beignet@lists.freedesktop.org > Cc: Song, Ruiling > Subject: [PATCH] GBE: impro

[Beignet] [PATCH] Disable the PCH valid check to save a lot of compiling time.

2013-12-04 Thread junyan . he
From: Junyan He In clang, The PCH file will be used as an AST source, so the check is strict. The macro define is also checked, and if anything is different, the PCH is invalid and the build processing will start from scratch. Disable Clang's PCH valid check and do the compatible check by ourself

Re: [Beignet] [PATCH] GBE: improve asin/acos precision

2013-12-04 Thread Song, Ruiling
Ping for review. Thanks -Original Message- From: Song, Ruiling Sent: Friday, November 29, 2013 4:04 PM To: beignet@lists.freedesktop.org Cc: Song, Ruiling Subject: [PATCH] GBE: improve asin/acos precision Signed-off-by: Ruiling Song --- backend/src/ocl_stdlib.tmpl.h | 77

Re: [Beignet] Sample program crash with beignet 0.3 on IVB

2013-12-04 Thread Robert Jobbagy
if I use opencv 2.4.7.1 branch head , I gave differenct sigsev : #1 0x7733fb1e in (anonymous namespace)::opencl_fn9<62, int, _cl_command_queue*, _cl_mem*, void const*, unsigned long, unsigned long, unsigned long, unsigned int, _cl_event* const*, _cl_event**>::switch_fn (p1=0x73fb00, p2=0x

Re: [Beignet] Newbie - Building beignet

2013-12-04 Thread Robert Jobbagy
I updated the opencl 1.2 branch to head ,clean project and rebuild , but I gave same error if I used different version llvm and clang Anyway cmake doesnt works with llvm-3.2 just 3.3 But if I replaced with clang 3.3, it works fine :) 2013/12/3 Zou, Nanhai > Still seems to be something wron

Re: [Beignet] Sample program crash with beignet 0.3 on IVB

2013-12-04 Thread Robert Jobbagy
Earlier I made an issue in opencv track here : http://code.opencv.org/issues/3412 Thanks your patch. I will try compile with llvm 3.3 2013/12/4 Robert Jobbagy > I use Ubuntu 13.10 default 3.2 llvm > > > 2013/12/4 Zhigang Gong > >> I just tried the same way as you. But the sympton is not the

Re: [Beignet] Sample program crash with beignet 0.3 on IVB

2013-12-04 Thread Robert Jobbagy
I use Ubuntu 13.10 default 3.2 llvm 2013/12/4 Zhigang Gong > I just tried the same way as you. But the sympton is not the same, I met a > region check bug which I just sent a patch to fix. > > After that fix, the squares example could run to complete but the result > is incorrect, the acuracy c

Re: [Beignet] [PATCH] Start looking for LLVM from highest version down

2013-12-04 Thread Zhigang Gong
Simon, Currently, the most stable version is llvm-3.3 and then llvm-3.2. Although the clang 3.4 fixes one know vector related bug, but it seems that it bring some severer regressions as below: http://llvm.org/bugs/show_bug.cgi?id=18119 http://llvm.org/bugs/show_bug.cgi?id=18120 We hope they can b

Re: [Beignet] Sample program crash with beignet 0.3 on IVB

2013-12-04 Thread Zhigang Gong
I just tried the same way as you. But the sympton is not the same, I met a region check bug which I just sent a patch to fix. After that fix, the squares example could run to complete but the result is incorrect, the acuracy check is also failed. I will continue to investigate this issue. The llv

Re: [Beignet] [PATCH 1/2] Fix float to ulong/long fail.

2013-12-04 Thread Zhigang Gong
LGTM, pushed, thanks. On Mon, Dec 02, 2013 at 05:10:26PM +0800, Yang Rong wrote: > > Signed-off-by: Yang Rong > --- > backend/src/backend/gen_context.cpp| 51 > -- > backend/src/backend/gen_context.hpp| 1 + > .../src/backend/gen_insn_gen7_s

Re: [Beignet] [PATCH 2/2] Add a forgot break when calc local_sz.

2013-12-04 Thread Zhigang Gong
On Mon, Dec 02, 2013 at 05:10:27PM +0800, Yang Rong wrote: > > Signed-off-by: Yang Rong > --- > src/cl_api.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/cl_api.c b/src/cl_api.c > index 54701aa..bc8ee1d 100644 > --- a/src/cl_api.c > +++ b/src/cl_api.c > @@ -24

[Beignet] [PATCH] Runtime: fixed the region check for three rect region related APIs.

2013-12-04 Thread Zhigang Gong
Signed-off-by: Zhigang Gong --- src/cl_api.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/cl_api.c b/src/cl_api.c index 1c1c941..e8e22e5 100644 --- a/src/cl_api.c +++ b/src/cl_api.c @@ -1423,7 +1423,9 @@ clEnqueueReadBufferRect(cl_command_queue comma

[Beignet] [PATCH] Disable the PCH valid check to save a lot of compiling time.

2013-12-04 Thread junyan . he
From: Junyan He In clang, The PCH file will be used as an AST source, so the check is strict. The macro define is also checked, and if anything is different, the PCH is invalid and the build processing will start from scratch. Disable the PCH valid check now to solve this problem now but not thor

Re: [Beignet] Sample program crash with beignet 0.3 on IVB

2013-12-04 Thread Robert Jobbagy
I attached my output log. 2013/12/4 zhigang gong > > > On Wed, Dec 4, 2013 at 3:23 AM, Robert Jobbagy > wrote: > >> Thanks your help, it works. >> >> I tried this opencl example : >> >> http://wiki.tiker.net/OpenCLHowTo#Testing >> >> and it shows these supported extensions by IVB: >> >> NAME:

Re: [Beignet] Sample program crash with beignet 0.3 on IVB

2013-12-04 Thread zhigang gong
On Wed, Dec 4, 2013 at 3:23 AM, Robert Jobbagy wrote: > Thanks your help, it works. > > I tried this opencl example : > > http://wiki.tiker.net/OpenCLHowTo#Testing > > and it shows these supported extensions by IVB: > > NAME: Intel HD Graphics Family > VENDOR: Intel > PROFILE: FULL_PROFILE > VERSI