Re: [Beignet] [PATCH] Accelerate utest.

2013-12-12 Thread Zhigang Gong
On Fri, Dec 13, 2013 at 07:19:07AM +, Song, Ruiling wrote: > Good idea. > But you use 'KEEP_PROGRAM' together with 'needDestroyProgram', if you use > keepProgram all thru the patch, it will be more clear. This is not a big > issue. > Another problem: I used needDestroyProgram when I modified

[Beignet] [PATCH 1/3] Add one script for generating the PCH files.

2013-12-12 Thread junyan . he
From: Junyan He The gen_ocl_pch will be used to generate the PCH files based on the different CL options. the -u file will be used to force update the PCH files, ignore the Clang version Signed-off-by: Junyan He --- backend/src/gen_ocl_pch.sh | 117 +

[Beignet] [PATCH 2/3] Modify the CMakeLists file for PCH build

2013-12-12 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- backend/src/CMakeLists.txt | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/backend/src/CMakeLists.txt b/backend/src/CMakeLists.txt index 36bf688..3d16038 100644 --- a/backend/src/CMakeLists.txt +

[Beignet] [PATCH 3/3] Modify the PCH using in the building process.

2013-12-12 Thread junyan . he
From: Junyan He The source building process will first find the PCH version based on the CL option and then do the conformance check. If passed, the PCH will be used and if failed, it will fallback to building from scratch. Signed-off-by: Junyan He --- backend/src/backend/program.cpp | 206 +++

[Beignet] [PATCH] GBE: fix clang's "incorrect" optimization for barrier call.

2013-12-12 Thread Zhigang Gong
Clang may duplicate one barrier call to multiple branches which breaks opencl's spec and may cause gpu hang. To fix this issue, we have to implement the barrier in a llvm module file and specify the function attribute to noduplicate, and we have to link this pre-compiled module before we compile th

Re: [Beignet] [PATCH] Accelerate utest.

2013-12-12 Thread Song, Ruiling
Good idea. But you use 'KEEP_PROGRAM' together with 'needDestroyProgram', if you use keepProgram all thru the patch, it will be more clear. This is not a big issue. Another problem: I think you need only change UTest::runAll() and UTest::runAllNoIssue() as ' cl_kernel_destroy(utest.needDestroyPro