Re: [Beignet] [PATCH] GBE: Fix a bug at constant GEP processing.

LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, January 07, 2014 10:41 AM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: Fix a bug at c

Re: [Beignet] [PATCH] GBE: handle the first index of GEP correctly.

LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, January 07, 2014 12:18 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: handle the fir

Re: [Beignet] [PATCH] GBE: clang's FE doesn't support static, we just ignore it.

LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, January 07, 2014 12:37 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: clang's FE doe

[Beignet] [PATCH] GBE: clang's FE doesn't support static, we just ignore it.

Although opencl spec does support static global variable or non-kernel function, clang doesn't support them currently. We simply ignore it currently. Signed-off-by: Zhigang Gong --- backend/src/ocl_stdlib.tmpl.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/backend/src/ocl_stdlib.tmpl

[Beignet] [PATCH] GBE: handle the first index of GEP correctly.

The first index of GEP instruction is to step over the pointer[0] to the index. We just need to calculate the *pointer's size, and step over *pointer's size * Index to reach the position of the data strucutre. Then we start to iterate the composite data type. Signed-off-by: Zhigang Gong --- back

Re: [Beignet] [PATCH] Refine calculation for ULP.

LGTM, thanks. -Original Message- From: Sun, Yi Sent: Monday, January 06, 2014 4:52 PM To: beignet@lists.freedesktop.org; Yang, Rong R Cc: Sun, Yi Subject: [Beignet][PATCH] Refine calculation for ULP. Signed-off-by: Yi Sun --- utests/utest_helper.cpp |9 + 1 files changed, 5

Re: [Beignet] [PATCH] Fix the multi-thread crash problem of batch buffer release.

Test pass, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of junyan...@inbox.com Sent: Monday, January 06, 2014 5:07 PM To: beignet@lists.freedesktop.org Cc: Junyan He Subject: [Beignet] [PATCH] Fix the multi

[Beignet] [PATCH] GBE: Fix a bug at constant GEP processing.

We need to initialize the offset to zero for each new operand. Signed-off-by: Zhigang Gong --- backend/src/llvm/llvm_gen_backend.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/llvm/llvm_gen_backend.cpp b/backend/src/llvm/llvm_gen_backend.cpp index 18e6967

[Beignet] [PATCH] Move the memory allocate size check to the callee.

Because image's alignment, the alloc size may exceed the CL_DEVICE_MAX_MEM_ALLOC_SIZE if the image's size is calculate from it. So move the size check from cl_mem_allocate to the callee, and slightly enlarge the limit size when check in allocate image. Signed-off-by: Yang Rong --- src/cl_gt_de

Re: [Beignet] [PATCH] GBE: optimize the CMP instruction.

A nice patch, LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 03, 2014 5:20 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: op

Re: [Beignet] [PATCH] GBE: optimize JMP instruction.

LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Friday, January 03, 2014 5:18 PM To: beignet@lists.freedesktop.org Cc: Gong, Zhigang Subject: [Beignet] [PATCH] GBE: optimize JMP ins

[Beignet] [PATCH] Fix the multi-thread crash problem of batch buffer release.

From: Junyan He The case causes like this: our thread hold the ref of the batch buffer, but have called cl_driver_delete to delete the bufmgr. So when we release the buffer object next time, the bufmgr's function pointer is invalid and cause the crash. We now release the batch buffer before every

[Beignet] [PATCH] Refine calculation for ULP.

Signed-off-by: Yi Sun --- utests/utest_helper.cpp |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/utests/utest_helper.cpp b/utests/utest_helper.cpp index a738599..91633f0 100644 --- a/utests/utest_helper.cpp +++ b/utests/utest_helper.cpp @@ -664,14 +664,15 @@ type