[Beignet] [PATCH OpenCL 2.0] Backend: Update the workgroup instructions for llvm backend to gen.

2015-03-23 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- backend/src/llvm/llvm_gen_ocl_function.hxx | 87 1 file changed, 87 insertions(+) diff --git a/backend/src/llvm/llvm_gen_ocl_function.hxx b/backend/src/llvm/llvm_gen_ocl_function.hxx index 9536a3c..947fadc 100644 ---

Re: [Beignet] [PATCH] Don't crash if device inaccessible

2015-03-23 Thread Zhigang Gong
LGTM, will push latter, thanks. On Sat, Mar 21, 2015 at 07:37:00AM +, Rebecca N. Palmer wrote: > If /dev/dri/cardX is inaccessible, return CL_DEVICE_NOT_FOUND, > don't assert-fail. > > Signed-off-by: Rebecca Palmer > > diff --git a/src/x11/dricommon.c b/src/x11/dricommon.c > index 03f542c..

Re: [Beignet] FindLLVM: allow LLVM/Clang 3.6

2015-03-23 Thread Zhigang Gong
LGTM, will push latter, thanks. On Sat, Mar 21, 2015 at 07:35:56AM +, Rebecca N. Palmer wrote: > As beignet now works with LLVM/Clang 3.6, accept this version > when searching for llvm-config. > > Signed-off-by: Rebecca Palmer > > diff --git a/CMake/FindLLVM.cmake b/CMake/FindLLVM.cmake > i

Re: [Beignet] [PATCH] Use matching versions of clang/llvm and libclang/libllvm

2015-03-23 Thread Zhigang Gong
LGTM, will push latter. Thanks. On Sat, Mar 21, 2015 at 07:34:22AM +, Rebecca N. Palmer wrote: > Compile the OpenCL standard library with the same version of clang > as will compile OpenCL user code, not plain "clang" (i.e. the > system default version, which may be different). > > Signed-off

[Beignet] [PATCH] Fix: Event callback that were not executed when command was already CL_COMPLETE + thread safety for callbacks

2015-03-23 Thread David Couturier
When trying to register a callback on the clEnqueueReadBuffer command, since it is processed synchroniously all the time, the command was marked CL_COMPLETE every time. If the event returned by clEnqueueReadBuffer was then used to register a callback function, the callback function did no check

Re: [Beignet] [PATCH] Fix: Event callback that not executed when command already marked CL_COMPLETE

2015-03-23 Thread Zhigang Gong
Right, the patch embedded in previous email has format problem. Could you use "git send-email" to send the patch again? Thanks for your contribution. On Tue, Mar 24, 2015 at 04:58:10AM +, Yang, Rong R wrote: > The patch looks good to me. Can you send this patch individually? > Thanks. > > >

Re: [Beignet] [PATCH] Fix: Event callback that not executed when command already marked CL_COMPLETE

2015-03-23 Thread Yang, Rong R
The patch looks good to me. Can you send this patch individually? Thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > David Couturier > Sent: Saturday, March 21, 2015 05:09 > To: beignet@lists.freedesktop.org > Subject: Re: [Beignet]

Re: [Beignet] [Patch V2] BDW: Refine I64HADD and I64RHADD.

2015-03-23 Thread He Junyan
That's OK On 2015年03月23日 17:09, Yang Rong wrote: HADD is equal to (src0>>1) + (src1>>1) + ((src0&0x1) & (src1&0x1)), and RHADD is equal to (src0>>1) + (src1>>1) + ((src0&0x1) | (src1&0x1)). V2: Save 1 register for both, and 1 AND for I64HADD. Signed-off-by: Yang Rong --- backend/src/backend

[Beignet] [Patch V2] BDW: Refine I64HADD and I64RHADD.

2015-03-23 Thread Yang Rong
HADD is equal to (src0>>1) + (src1>>1) + ((src0&0x1) & (src1&0x1)), and RHADD is equal to (src0>>1) + (src1>>1) + ((src0&0x1) | (src1&0x1)). V2: Save 1 register for both, and 1 AND for I64HADD. Signed-off-by: Yang Rong --- backend/src/backend/gen8_context.cpp | 123

[Beignet] [PATCH OpenCL 2.0] libocl: Add the module for work_group functions.

2015-03-23 Thread junyan . he
From: Junyan He Signed-off-by: Junyan He --- backend/src/libocl/CMakeLists.txt |2 +- backend/src/libocl/include/ocl_work_group.h | 118 + backend/src/libocl/src/ocl_work_group.cl| 126 +++ 3 files changed, 245 insertions(+), 1

Re: [Beignet] [PATCH] BDW: Refine I64HADD and I64RHADD.

2015-03-23 Thread He Junyan
OK, it's a better way to avid the usage of addc. I think tmp_dst can also be avoided here to save one tmp register. On 2015年03月23日 15:44, Song, Ruiling wrote: Good idea, the patch LGTM. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Yang R

Re: [Beignet] [PATCH] BDW: Refine I64HADD and I64RHADD.

2015-03-23 Thread Song, Ruiling
Good idea, the patch LGTM. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Yang Rong > Sent: Monday, March 23, 2015 2:26 PM > To: beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: [Beignet] [PATCH] BDW: Refine I64HADD and I64RHA