From: Luo Xionghu xionghu@intel.com
should define and use M_180_PI_F directly instead of using 180/M_PI_F.
Signed-off-by: Luo Xionghu xionghu@intel.com
---
backend/src/libocl/include/ocl_float.h | 1 +
backend/src/libocl/tmpl/ocl_common.tmpl.cl | 2 +-
2 files changed, 2
From: Luo Xionghu xionghu@intel.com
should define and use M_180_PI_F directly instead of using 180/M_PI_F.
v2: half degrees also need this.
Signed-off-by: Luo Xionghu xionghu@intel.com
---
backend/src/libocl/include/ocl_float.h | 1 +
backend/src/libocl/tmpl/ocl_common.tmpl.cl | 4
I was surprised by this, so I wrote a program to test. Indeed, 180 /
(float)M_PI is
less precise:
(float)(180 / M_PI) = 57.2957763671875 (0x1.ca5dc0p+5) (0x42652ee0)
(180 / (float)M_PI) = 57.2957763671875 (0x1.ca5dc0p+5) (0x42652ee0)
57.295779513082321F = 57.29578018188476562
On Thu, Aug 6, 2015 at 12:57 AM, xionghu@intel.com wrote:
From: Luo Xionghu xionghu@intel.com
should define and use M_180_PI_F directly instead of using 180/M_PI_F.
Signed-off-by: Luo Xionghu xionghu@intel.com
---
backend/src/libocl/include/ocl_float.h | 1 +
LGTM, thx.
-Original Message-
From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
xionghu@intel.com
Sent: Thursday, August 6, 2015 3:58 PM
To: beignet@lists.freedesktop.org
Cc: xionghu@intel.com
Subject: [Beignet] [PATCH] libocl: fix degrees function
I sent the v2 patch which include half degrees function fix, please push that
one and ignore this. Thanks.
Luo Xionghu
Best Regards
-Original Message-
From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com]
Sent: Thursday, August 6, 2015 4:27 PM
To: Luo, Xionghu;
