Re: [Beignet] [PATCH] Use syslog for device self-test errors

2015-10-11 Thread Yang, Rong R
It is good idea print warnings to syslog avoid application confuse. But for errors, I think also need print to stdout, give the clear hint to application. Any other consideration? > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of >

Re: [Beignet] [PATCH] GBE: fix kernel arguments uploading bug.

2015-10-11 Thread Yang, Rong R
LGTM, pushed, thanks. > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Zhigang Gong > Sent: Saturday, October 10, 2015 9:11 > To: beignet@lists.freedesktop.org > Cc: Gong, Zhigang > Subject: [Beignet] [PATCH] GBE: fix kernel arguments