[Beignet] [PATCH] utest: do not check the padding componenet for 3-component vector data types

2016-07-24 Thread Guo Yejun
Per OPenCL 1.2 spec 6.1.5: For 3-component vector data types, the size of the data type is 4 * sizeof(component). The spec does not explicitly say what the padding componenet will be, it should be implementation-dependent, so, do not check the padding componenet in the unit test. Signed-off-by: Gu

Re: [Beignet] [PATCH] Runtime: fix a string overflow.

2016-07-24 Thread Song, Ruiling
LGTM Thanks! Ruiling > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Yang Rong > Sent: Monday, July 18, 2016 12:45 PM > To: beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: [Beignet] [PATCH] Runtime: fix a string overflow. >

Re: [Beignet] [PATCH 2/4] Backend: Optimization internal math, lower polynomials

2016-07-24 Thread Lupescu, Grigore
I acknowledge the problems with lgamma/lgamma_r. It is indeed because of the polynomial reduction - while conformance passes the utests fail. I wasn't able to keep the lgamma/lgamma_r polynomial reduction and still pass utest. It looks like it is very sensitive and precision is at its limit with