Re: [Beignet] [PATCH v2] Enable OpenCL 2.0 only where supported

2017-01-22 Thread Pan, Xiuli
I am writing these changes now and will try to start test soon. And I will spilt the patch into runtime change and utest change. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Pan, Xiuli Sent: Monday, January 23, 2017 10:45 AM To: Rebecca N.

[Beignet] [PATCH] GBE: use shift for PowerOf2 size when lowering GEP.

2017-01-22 Thread Ruiling Song
For 64bit address, the multiply would expand to several instructions. As for most time, the size is PowerOf 2. So we can use left-shift to do this. Signed-off-by: Ruiling Song --- backend/src/llvm/llvm_passes.cpp | 19 +-- 1 file changed, 13

[Beignet] [PATCH] API: Fix local memory type to CL_LOCAL

2017-01-22 Thread Xiuli Pan
From: Pan Xiuli We are using SLM as local memory and we should return CL_LOCAL for CL_DEVICE_LOCAL_MEM_TYPE. Signed-off-by: Pan Xiuli --- src/cl_gen75_device.h | 2 +- src/cl_gen7_device.h | 2 +- src/cl_gen8_device.h | 2 +- src/cl_gen9_device.h |

Re: [Beignet] Graphical Glitches and Local Memory Performance Issue

2017-01-22 Thread Pan, Xiuli
Hi, Could you make this as a bug report to Beignet on https://bugs.freedesktop.org/ It will help us to track the status and you can also provide some more information and reproduce codes. As for the Local buffer type, it seems to be our query API's bug. Our implementation does not use the

Re: [Beignet] [PATCH v2] Enable OpenCL 2.0 only where supported

2017-01-22 Thread Pan, Xiuli
I think if we want to enable OpenCL 2.0 as default we must check if there is a LLVM 3.9 first, or there will have errors to ask people to update llvm. We may turn the OCL 20 off when no llvm39 is found. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On

Re: [Beignet] [PATCH] FindLLVM: Accept LLVM 3.9

2017-01-22 Thread Pan, Xiuli
LGTM. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Rebecca N. Palmer Sent: Monday, January 23, 2017 1:07 AM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] FindLLVM: Accept LLVM 3.9 Signed-off-by: Rebecca N. Palmer

Re: [Beignet] [PATCH] Fix typo

2017-01-22 Thread Pan, Xiuli
LGTM, thanks. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Rebecca N. Palmer Sent: Monday, January 23, 2017 1:09 AM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH] Fix typo Signed-off-by: Rebecca N. Palmer

[Beignet] [PATCH] Make CL-GL sharing available via ICD

2017-01-22 Thread Rebecca N. Palmer
Signed-off-by: Rebecca N. Palmer --- (Warning: has not been tested) diff --git a/src/cl_khr_icd.c b/src/cl_khr_icd.c index 7b3600c..e4daf79 100644 --- a/src/cl_khr_icd.c +++ b/src/cl_khr_icd.c @@ -18,10 +18,14 @@ #include "cl_platform_id.h" #include "CL/cl_intel.h"

[Beignet] [PATCH] Clarify status of cl_khr_gl_sharing

2017-01-22 Thread Rebecca N. Palmer
Signed-off-by: Rebecca N. Palmer --- > -The release notes say cl_khr_gl_sharing is now supported, but > docs/Beignet.mdwn still says it isn't. It exists but is off by default, probably because it isn't finished: clEnqueueAcquireGLObjects / clEnqueueReleaseGLObjects are

Re: [Beignet] Building beignet with OpenCL 2.0 support in distros

2017-01-22 Thread Bruno Pagani
Hi, Le 22/01/2017 à 06:46, Pan, Xiuli a écrit : > Hi all, > > Thank you for pay close attention to our latest release. We are very sorry > that we are not very thoughtful about the package making things. > > We did not have a performance test for OCL2.0 so we did not set it as a > default

[Beignet] [PATCH] Fix typo

2017-01-22 Thread Rebecca N. Palmer
Signed-off-by: Rebecca N. Palmer --- a/backend/src/llvm/llvm_gen_backend.cpp +++ b/backend/src/llvm/llvm_gen_backend.cpp @@ -308,7 +308,7 @@ namespace gbe if(StrTy) return getTypeByteSize(unit,StrTy); } - GBE_ASSERTM(false, "Unspported

[Beignet] [PATCH] FindLLVM: Accept LLVM 3.9

2017-01-22 Thread Rebecca N. Palmer
Signed-off-by: Rebecca N. Palmer -- (Possibly should be higher in the priority order, since it's required for OpenCL 2.0?) --- a/CMake/FindLLVM.cmake +++ b/CMake/FindLLVM.cmake @@ -8,12 +8,12 @@ # LLVM_FOUND - True if llvm found. if (LLVM_INSTALL_DIR)

[Beignet] [PATCH v2] Enable OpenCL 2.0 only where supported

2017-01-22 Thread Rebecca N. Palmer
This allows a single beignet binary to both offer 2.0 where available, and still work on older hardware. (2.0 uses 64 bit pointers, which assert-fail on Ivybridge: backend/src/backend/gen_context.cpp:2259). V2: Default to 1.2 when -cl-std is not set (required by the OpenCL spec, and also likely

[Beignet] Graphical Glitches and Local Memory Performance Issue

2017-01-22 Thread Artyom Beilis
Hello, I'm trying to use Beignet driver to use OpenCL: I have tested in on two platforms: Platform #1 i5-3470 with Intel® HD Graphics 2500 -- Some of clinfo output: Platform Profile: