Re: [Beignet] [PATCH v2] Enable OpenCL 2.0 only where supported

2017-01-23 Thread Rebecca N. Palmer
> regarding whether OpenCL 2.0 > is compiled or not I would rather think of something like that: > > – if llvm39 and libdrm2466 are found, compile with OpenCL 2.0 by default. > – if they’re not, compile without it. Issue an error message if > -DENABLE_OPENCL_20=1 was passed. Agreed - we actually

Re: [Beignet] [PATCH] Make CL-GL sharing available via ICD

2017-01-23 Thread Weng, Chuanbo
This patch LGTM, and I did a basic test on this patch. Thanks for your patch. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Rebecca N. Palmer Sent: Monday, January 23, 2017 7:11 AM To: beignet@lists.freedesktop.org Subject: [Beignet] [PATCH]

Re: [Beignet] [PATCH] Clarify status of cl_khr_gl_sharing

2017-01-23 Thread Weng, Chuanbo
Hi Rebecca, cl_khr_gl_sharing is partially supported (the most commonly used part). I have just sent out a patchset that show how to use cl_khr_gl_sharing on Beignet. The patchset also detect GL and EGL version and turn cl_khr_gl_sharing ON if version >= 13.0.0. So the first

[Beignet] [PATCH 2/2] Add document of using cl_khr_gl_sharing to do gl buffer sharing.

2017-01-23 Thread Chuanbo Weng
Signed-off-by: Chuanbo Weng --- docs/howto/gl-buffer-sharing-howto.mdwn | 79 + 1 file changed, 79 insertions(+) create mode 100644 docs/howto/gl-buffer-sharing-howto.mdwn diff --git a/docs/howto/gl-buffer-sharing-howto.mdwn

[Beignet] [PATCH 1/2] Add example of using cl_khr_gl_sharing to do gl buffer sharing.

2017-01-23 Thread Chuanbo Weng
Signed-off-by: Chuanbo Weng --- CMakeLists.txt | 34 +++ examples/CMakeLists.txt | 80 ++-- examples/gl_buffer_sharing/gl_buffer_sharing.cpp | 115 +++

Re: [Beignet] [PATCH] FindLLVM: Accept LLVM 3.9

2017-01-23 Thread Simon Richter
Hi, On Sun, Jan 22, 2017 at 05:07:07PM +, Rebecca N. Palmer wrote: > - NAMES llvm-config-37 llvm-config-3.7 llvm-config-36 > llvm-config-3.6 llvm-config-38 llvm-config-3.8 llvm-config llvm-config-35 > llvm-config-3.5 llvm-config-34 llvm-config-3.4 > + NAMES

Re: [Beignet] [PATCH v2] Enable OpenCL 2.0 only where supported

2017-01-23 Thread Bruno Pagani
Yes indeed, I think Rebecca patch is not ideal in that direction. Removing the lspci thing is right (by the way, I think that GetGenID.sh should be removed too at this point), but regarding whether OpenCL 2.0 is compiled or not I would rather think of something like that: – if llvm39 and