Re: [Beignet] [PATCH] Fix a compare immediate optimize error.

2013-11-14 Thread Zhigang Gong
Pushed, thanks. On Fri, Nov 15, 2013 at 11:40:30AM +0800, Yang Rong wrote: > When do LOADI/compare -> compare optimize, IMM src1 will using LOADI type, > but LOADI doesn't care unsigned or signed. Should use the compare type. > > Signed-off-by: Yang Rong > --- > backend/src/backend/gen_insn_sel

Re: [Beignet] [PATCH] Fix a compare immediate optimize error.

2013-11-14 Thread Xing, Homer
Good patch. Looks good to me. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Yang Rong Sent: Friday, November 15, 2013 11:41 AM To: beignet@lists.freedesktop.org Cc: Yang, Rong R Subject: [Beignet] [PATCH] Fix a

[Beignet] [PATCH] Fix a compare immediate optimize error.

2013-11-14 Thread Yang Rong
When do LOADI/compare -> compare optimize, IMM src1 will using LOADI type, but LOADI doesn't care unsigned or signed. Should use the compare type. Signed-off-by: Yang Rong --- backend/src/backend/gen_insn_selection.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/backend/src/backend/ge