Re: [Beignet] [PATCH] GBE: fix printf class static variable bug

2015-11-10 Thread Yang, Rong R
Ruiling; beignet@lists.freedesktop.org > Cc: Yang, Rong R > Subject: RE: [Beignet] [PATCH] GBE: fix printf class static variable bug > > Ping for pushed. > The getAnalysis seems doesn't work for this situation. Maybe we should > refine these passes to pass info by unit later. > >

Re: [Beignet] [PATCH] GBE: fix printf class static variable bug

2015-11-09 Thread Pan, Xiuli
ber 6, 2015 11:27 AM To: Song, Ruiling ; beignet@lists.freedesktop.org Subject: Re: [Beignet] [PATCH] GBE: fix printf class static variable bug Yes, but the problem is that if two thread has kernel with printf functions, the map printfs will be cleared in construction and destructor. This will caus

Re: [Beignet] [PATCH] GBE: fix printf class static variable bug

2015-11-05 Thread Pan, Xiuli
Pan, Xiuli ; beignet@lists.freedesktop.org Subject: RE: [Beignet] [PATCH] GBE: fix printf class static variable bug Thread_local is not needed to pass data from one llvm pass to another. You can still access the info after pass that has already run. In a later llvm pass, you can use getAnalysis() to

Re: [Beignet] [PATCH] GBE: fix printf class static variable bug

2015-11-05 Thread Song, Ruiling
Pan, Xiuli; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] GBE: fix printf class static variable bug > > Ping for review. > > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Pan Xiuli > Sent: Tuesday, November 3, 2015 1

Re: [Beignet] [PATCH] GBE: fix printf class static variable bug

2015-11-05 Thread Pan, Xiuli
Ping for review. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Pan Xiuli Sent: Tuesday, November 3, 2015 11:30 AM To: beignet@lists.freedesktop.org Cc: Pan, Xiuli Subject: [Beignet] [PATCH] GBE: fix printf class static variable bug The

[Beignet] [PATCH] GBE: fix printf class static variable bug

2015-11-02 Thread Pan Xiuli
The PrintfParse::printfs static is not thread safe and maybe reset or adding something wrong when runing in mutlithread. Fix the problem by change the printfs to a thread local variable. Signed-off-by: Pan Xiuli --- backend/src/llvm/llvm_printf_parser.cpp | 9 - 1 file changed, 4 inserti