[Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

2013-10-29 Thread Zhigang Gong
For most vector relational builtin functions, we need to return -1 if the element result is true, return 0 if the element result is 0. So we can simply put a - in front of the scalar version of function for each element. Reported by Yang Rong. Signed-off-by: Zhigang Gong --- backend/src/gen_bui

Re: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

2013-10-29 Thread Yang, Rong R
LGTM, thanks. -Original Message- From: beignet-boun...@lists.freedesktop.org [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Zhigang Gong Sent: Tuesday, October 29, 2013 3:07 PM To: beignet@lists.freedesktop.org Cc: Zhigang Gong Subject: [Beignet] [PATCH] GBE: fixed one bug

Re: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

2013-10-29 Thread Sun, Yi
p.org] On Behalf Of > Yang, Rong R > Sent: Tuesday, October 29, 2013 3:44 PM > To: Zhigang Gong; beignet@lists.freedesktop.org > Subject: Re: [Beignet] [PATCH] GBE: fixed one bug for vector relational > builtin > functions. > > LGTM, thanks. > > -Ori

Re: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions.

2013-10-29 Thread Yang, Rong R
Sent: Tuesday, October 29, 2013 4:35 PM To: Yang, Rong R; Zhigang Gong; beignet@lists.freedesktop.org Cc: Jin, Gordon Subject: RE: [Beignet] [PATCH] GBE: fixed one bug for vector relational builtin functions. It seems this patch introduced a regression issue: ./piglit-run.py -t float-isnan-1.0