LGTM, thanks.
On Fri, Nov 08, 2013 at 10:51:34AM +0800, Homer Hsing wrote:
> if an parameter is nan, then returns another parameter.
>
> Signed-off-by: Homer Hsing
> ---
> backend/src/ocl_stdlib.tmpl.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/backend/src/ocl_stdlib.tmpl.h b
Two additional comments:
1. This patch should only for the float data type.
2. For the float data type, according to IVB spec.
Nan compare with any other data will get a false,
so we can reduce one nan checking, and the following
should be good enough.
{
if (inan(b))
return a;
return a > b ?
Good. Thanks for the comments.
-Original Message-
From: Zhigang Gong [mailto:zhigang.g...@linux.intel.com]
Sent: Friday, November 8, 2013 2:23 PM
To: Xing, Homer
Cc: beignet@lists.freedesktop.org
Subject: Re: [Beignet] [PATCH] fix builtin function "fmax"
Two additional co
if an parameter is nan, then returns another parameter.
Signed-off-by: Homer Hsing
---
backend/src/ocl_stdlib.tmpl.h | 4
1 file changed, 4 insertions(+)
diff --git a/backend/src/ocl_stdlib.tmpl.h b/backend/src/ocl_stdlib.tmpl.h
index bff2b1c..ec9ed60 100644
--- a/backend/src/ocl_stdlib.tm
