2:23 PM
To: Pan, Xiuli <xiuli@intel.com>; beignet@lists.freedesktop.org
Cc: Pan, Xiuli <xiuli@intel.com>
Subject: RE: [Beignet] [PATCH 5/7] Backend: Refine LLVM version check macro
> -#if LLVM_VERSION_MAJOR == 3 && LLVM_VERSION_MINOR >= 9
> +#if LLVM_VERSION_MAJ
> -#if LLVM_VERSION_MAJOR == 3 && LLVM_VERSION_MINOR >= 9
> +#if LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR >= 39
I think it is better to add "LLVM_VERSION" in llvm_includes.hpp:
#define LLVM_VERSION (LLVM_VERSION_MAJOR * 10 + LLVM_VERSION_MINOR)
So at each place we only check LLVM_VERSION
From: Pan Xiuli
LLVM 4.0 is coming, we should refine our version check to fit the
LLVM_MAJOR_VERSION bump to 4.
Signed-off-by: Pan Xiuli
---
backend/src/backend/gen_program.cpp | 12 ++---
backend/src/backend/program.cpp